Skip to contentSkip to conversation

swsusp: avoid emergency disk parking in "platform" mode

PATCH Stefan Seyfried 1 participant 1 message Aug 20, 2004

Subsystems (2)
lore
Share & tools
lore
#0 lore raw

Hi,

although the issue seems fixed on normal shutdown and with swsusp in "shutdown" mode, i still get the ugly "clunk" of my emergency-parking disk in platform mode.
The attached patch fixes this for me, although i am not sure this is the correct way to do. Probably some device_suspend(SOMETHING) would be better and maybe the device_power_down is no longer needed, but something needs to be done at this point.

Stefan

kernel/power/disk.c +1 -0
diff -ru --exclude '*.o' linux-orig/kernel/power/disk.c linux/kernel/power/disk.c
@@ -49,6 +49,7 @@
 	local_irq_save(flags);
 	switch(mode) {
 	case PM_DISK_PLATFORM:
+		device_shutdown();
 		device_power_down(PM_SUSPEND_DISK);
 		error = pm_ops->enter(PM_SUSPEND_DISK);
 		break;