Skip to contentSkip to conversation

Problem with cdrom-range-fixes-patch in 2.6.9-rc1-mm2

DISCUSSION Grant Wilson 2 participants 2 messages Sep 2, 2004 – Sep 3, 2004

lore
Share & tools
lore
#0 lore raw

Hi,
With this patch applied a CDROMVOLREAD ioctl returns EINVAL. I believe that this is because of an error in the 'sanity check' added by the patch:

if ((buffer[offset] & 0x3f) == GPMODE_AUDIO_CTL_PAGE ||

                            ^^
                 should be  !=

Yours,
Grant Wilson

#1 lore raw
Quoted 6 lines · Grant Wilson

Hi,
With this patch applied a CDROMVOLREAD ioctl returns EINVAL. I believe that this is because of an error in the 'sanity check' added by the patch:

if ((buffer[offset] & 0x3f) == GPMODE_AUDIO_CTL_PAGE ||

                            ^^
                 should be  !=

Yes, absolutely. It should be != GPMODE_AUDIO_CTL_PAGE. Thanks! A.