Skip to contentSkip to conversation

: fix unbalances spin_unlock_bh in __xfrm_find_acq_byseq

PATCH In review Patrick McHardy 2 participants 2 messages Sep 23, 2004

Subsystems (2)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 : fix unbalances spin_unlock_bh in __xfrm_find_acq_byseq

This patch fixes an unbalanced spin_unlock_bh in
__xfrm_find_acq_byseq left over from the larval
state SA fix.

Regards
Patrick

# This is a BitKeeper generated diff -Nru style patch. #
# ChangeSet
# 2004/09/23 06:05:52+02:00 [email protected]
# [XFRM]: Fix unbalanced spin_unlock_bh
#
# Signed-off-by: Patrick McHardy <[email protected]>
#

# net/xfrm/xfrm_state.c
#   2004/09/23 06:05:25+02:00 [email protected] +0 -1
#   [XFRM]: Fix unbalanced spin_unlock_bh
#   
#   Signed-off-by: Patrick McHardy <[email protected]>
# 
diff -Nru a/net/xfrm/xfrm_state.c b/net/xfrm/xfrm_state.c
--- a/net/xfrm/xfrm_state.c	2004-09-23 06:07:23 +02:00
+++ b/net/xfrm/xfrm_state.c	2004-09-23 06:07:23 +02:00
@@ -592,7 +592,6 @@
 		list_for_each_entry(x, xfrm_state_bydst+i, bydst) {
 			if (x->km.seq == seq) {
 				xfrm_state_hold(x);
-				spin_unlock_bh(&xfrm_state_lock);
 				return x;
 			}
 		}
maintainer
#1 lore raw
Quoted 3 lines · On Thu, 23 Sep 2004 06:10:48 +0200 Patrick McHardy <[email protected]> wrote:

This patch fixes an unbalanced spin_unlock_bh in
__xfrm_find_acq_byseq left over from the larval
state SA fix.

Good catch, patch applied.

Thanks Patrick.