Skip to contentSkip to conversation

Status of pci_find_device fixes

Kernel-janitors Tobias Klauser 3 participants 5 messages Sep 29, 2004 – Oct 4, 2004 Kernel janitors

lore
Share & tools
lore

Tobias Klauser

author
#0 lore raw

Hi

I saw this entry in the TODO list:

------------------------------------------------------------------------
From: Greg KH

- delete all pci_find_* functions from the kernel tree. Instead of pci_find_device use pci_get_device()..

Quoted 2 lines

Looking at pci.txt, it appears that if I use pci_get_device(), I will also need to use pci_dev_put().

------------------------------------------------------------------------

Since I'm interested in the PCI section in the kernel (and Greg pointed me to that when I was bugging him ;), I thought this would be a good point to start helping. While crawling through the kernel-janitor archives I noticed, that there's already work ongoing on that issue.

What's the status of this and are there drivers which still need to be fixed?

Thanks, Tobias

_______________________________________________
Kernel-janitors mailing list
[email protected]
http://lists.osdl.org/mailman/listinfo/kernel-janitors

#1 lore raw
Quoted 5 lines · --On Wednesday, September 29, 2004 03:09:52 PM +0200 Tobias Klauser…

Since I'm interested in the PCI section in the kernel (and Greg pointed me to that when I was bugging him ;), I thought this would be a good point to start helping. While crawling through the kernel-janitor archives I noticed, that there's already work ongoing on that issue.

What's the status of this and are there drivers which still need to be fixed?

Hi Tobias,

Thanks for your interest. There are a couple of us working in this area already but if we all coordinate it should help get the work done quickly. Scott is doing everything under drivers/net to start with. Greg and I finished everything under arch/i386. Right now I am working on all the drivers that can be converted to the new pci_dev_present function. That leaves over 100 drivers that need to be converted (cscope and grep are your friend).

If this sounds like something you are interested in feel free to jump in and make sure to send you patches back to the list. If you want to make sure no one else is working on the same driver before you start that would be good. Use this list, that is what it is for.

Hanna

_______________________________________________
Kernel-janitors mailing list
[email protected]
http://lists.osdl.org/mailman/listinfo/kernel-janitors

#2 lore raw
In reply to Tobias Klauser
Quoted 5 lines · Hanna Linder

Thanks for your interest. There are a couple of us working in this area already but if we all coordinate it should help get the work done quickly. Scott is doing everything under drivers/net to start with. Greg and I finished everything under arch/i386. Right now I am working on all the drivers that can be converted to the new pci_dev_present function. That leaves over 100 drivers that need to be converted (cscope and grep are your friend).

driver/net is shaping up. There are still a couple that need probe/remove conversion.

I'm heading over to drivers/scsi next, FWIW.

-scott

_______________________________________________
Kernel-janitors mailing list
[email protected]
http://lists.osdl.org/mailman/listinfo/kernel-janitors

#3 lore raw
In reply to Tobias Klauser
Quoted 8 lines · Scott Feldman
Quoted 5 lines · Hanna Linder

Thanks for your interest. There are a couple of us working in this area already but if we all coordinate it should help get the work done quickly. Scott is doing everything under drivers/net to start with. Greg and I finished everything under arch/i386. Right now I am working on all the drivers that can be converted to the new pci_dev_present function. That leaves over 100 drivers that need to be converted (cscope and grep are your friend).

Quoted 4 lines

driver/net is shaping up. There are still a couple that need probe/remove conversion.

I'm heading over to drivers/scsi next, FWIW.

No low hanging fruit in SCSI orchards! Looks like plenty of pci_driver support missing:

# grep -l scsi_module.c `grep -l -r pci_find_device drivers/scsi/*`
drivers/scsi/3w-xxxx.c
drivers/scsi/advansys.c
drivers/scsi/aic7xxx_old.c
drivers/scsi/cpqfcTSinit.c
drivers/scsi/dmx3191d.c
drivers/scsi/eata_pio.c
drivers/scsi/fdomain.c
drivers/scsi/gdth.c
drivers/scsi/ini9100u.c
drivers/scsi/pci2000.c
drivers/scsi/pci2220i.c
drivers/scsi/qla1280.c
drivers/scsi/qlogicfc.c
drivers/scsi/qlogicisp.c

What's a good driver for reference that uses the "new-style" template?

-scott

_______________________________________________
Kernel-janitors mailing list
[email protected]
http://lists.osdl.org/mailman/listinfo/kernel-janitors

#4 lore raw
In reply to Tobias Klauser
Quoted 8 lines · --On Sunday, October 03, 2004 08:43:08 PM -0700 Scott Feldman…

driver/net is shaping up. There are still a couple that need probe/remove conversion.

I'm heading over to drivers/scsi next, FWIW.

-scott

Thanks Scott,

I just finished ia64 and am moving on to the other arch's.

Hanna

_______________________________________________
Kernel-janitors mailing list
[email protected]
http://lists.osdl.org/mailman/listinfo/kernel-janitors