Skip to contentSkip to conversation

2.6.9-rc3 compile erros

PATCH Eyal Lebedinsky 2 participants 2 messages Oct 2, 2004

Subsystems (2)
lore
Share & tools
lore
#0 lore raw

I need DVB so I finaly made the move to 2.6[.9-rc3]. I get compile failures in two modules:

    drivers/isdn/i4l/isdn_tty.c
    drivers/net/wan/pc300_tty.c

Both look like careless typos - is 2,6 really stable by now?

Signature · 1 line
Eyal Lebedinsky	 ([email protected]) <http://samba.org/eyal/>
drivers/isdn/i4l/isdn_tty.c renamed from drivers/isdn/i4l/isdn_tty.c.orig +1 -1
@@ -2673,7 +2673,7 @@
 		if ((info->flags & ISDN_ASYNC_CLOSING) || (!info->tty)) {
 			return;
 		}
-		tty_ldisc_flush(tty);
+		tty_ldisc_flush(info->tty);
 		if ((info->flags & ISDN_ASYNC_CHECK_CD) &&
 		    (!((info->flags & ISDN_ASYNC_CALLOUT_ACTIVE) &&
 		       (info->flags & ISDN_ASYNC_CALLOUT_NOHUP)))) {
drivers/net/wan/pc300_tty.c renamed from drivers/net/wan/pc300_tty.c.orig +1 -1
@@ -704,7 +704,7 @@
 					ld = tty_ldisc_ref(cpc_tty);
 					if(ld)
 					{
-						if (ld->receive_buf)) {
+						if (ld->receive_buf) {
 							CPC_TTY_DBG("%s: call line disc. receive_buf\n",cpc_tty->name);
 							ld->receive_buf(cpc_tty->tty, (char *)(buf->data), &flags, buf->size);
 						}
#1 lore raw
Quoted 5 lines · Eyal Lebedinsky

I need DVB so I finaly made the move to 2.6[.9-rc3]. I get compile failures in two modules:

     drivers/isdn/i4l/isdn_tty.c
     drivers/net/wan/pc300_tty.c

Both look like careless typos - is 2,6 really stable by now?

Both already fixed and pushed upstream. The tty patch contained a couple of typos in pieces I couldn't compile/test. (or in the case of ISDN forgot to).

Should all be rippled out by rc4, and given the fact every serial driver had to change I don't think it was too bad