__init & __initdata during resume
Hi Pavel,
'make buildcheck' reports:
Error: ./arch/x86_64/ia32/syscall32.o .text refers to 0000000000000002R_X86_64_PC32 .init.data+0x000000000000152b
Error: ./arch/x86_64/ia32/syscall32.o .text refers to 0000000000000017R_X86_64_PC32 .init.data+0x000000000000152c
I'm looking at a recent (2 weeks) changeset:
[PATCH] Fix random crashes in x86-64 swsusp
in which this change was made:
-void __init syscall32_cpu_init(void)
+/* May not be __init: called during resume */
+void syscall32_cpu_init(void)
but syscall32_cpu_init() uses <use_sysenter>, which is:
static int use_sysenter __initdata = -1;
so the question is: does that "__initdata" need to removed also?
--
~Randy
Hi!
Quoted 18 lines
'make buildcheck' reports:
Error:./arch/x86_64/ia32/syscall32.o.text refers to 0000000000000002R_X86_64_PC32.init.data+0x000000000000152b
Error:./arch/x86_64/ia32/syscall32.o.text refers to 0000000000000017R_X86_64_PC32.init.data+0x000000000000152cI'm looking at a recent (2 weeks) changeset:
[PATCH] Fix random crashes in x86-64 swsuspin which this change was made:
(quoted diff) +2
-1-void __init syscall32_cpu_init(void) +/* May not be __init: called during resume */ +void syscall32_cpu_init(void)
Quoted 4 lines
but
syscall32_cpu_init()uses <use_sysenter>, which is:
static intuse_sysenter__initdata= -1;so the question is: does that "
__initdata" need to removed also?
Yes, I'm afraid that I overlooked that one.
Pavel
Signature · 2 lines
People were complaining that M$ turns users into beta-testers... ...jr ghea gurz vagb qrirybcref, naq gurl frrz gb yvxr vg gung jnl!