2.6.9 bug: linux logo not displayed in vga16fb

Hi !

I used to have a nice vga boot logo with my 2.6.7 kernel, but with the 2.6.9, my boot logo has disappeared (same .config)...
It seems to switch to VGA, and some space is reserved for the logo, but it is not displayed. The logo appears with vesafb.

Any idea / patch welcome !

Cheers,

Ludo

Ludovic DROLEZ                              Linbox / Free&ALter Soft
152 rue de Grigy - Technopole Metz 2000                   57070 METZ
tel : 03 87 50 87 90                            fax : 03 87 75 19 26

I made a few diffs between my old working 2.6.7 kernel and the 2.6.9 and found something interesting in fbmem.c:

---------------
@@ -723,7 +419,7 @@

        if (fb_logo.logo == NULL || info->state != FBINFO_STATE_RUNNING)
                return 0;

- image.depth = fb_logo.depth;

+       image.depth = 8;
        image.data = fb_logo.logo->data;

        if (fb_logo.needs_cmapreset)

---------------

So, on my 2.6.9, I replaced the '8' by 'fb_logo.depth' and now the logo is shown! (but the screen is still not cleared as before when the kernel boots).

Where's the QA guy ? I want to see him now ! ;-)

Cheers,

Ludovic DROLEZ                              Linbox / Free&ALter Soft
152 rue de Grigy - Technopole Metz 2000                   57070 METZ
tel : 03 87 50 87 90                            fax : 03 87 75 19 26

Should be fixed in the mm tree or the latest bk snapshot. Or you can try this very patch.

Tony

diff -uprN linux-2.6.9-rc1-mm4-orig/drivers/video/vga16fb.c linux-2.6.9-rc1-mm4/drivers/video/vga16fb.c
@@ -1306,7 +1306,7 @@ void vga16fb_imageblit(struct fb_info *i
 {
 	if (image->depth == 1)
 		vga_imageblit_expand(info, image);
-	else if (image->depth <= info->var.bits_per_pixel)
+	else
 		vga_imageblit_color(info, image);
 }
 

I made a few diffs between my old working 2.6.7 kernel and the 2.6.9 and found something interesting in fbmem.c:

---------------
@@ -723,7 +419,7 @@

        if (fb_logo.logo == NULL || info->state != FBINFO_STATE_RUNNING)
                return 0;

- image.depth = fb_logo.depth;

+       image.depth = 8;
        image.data = fb_logo.logo->data;

        if (fb_logo.needs_cmapreset)

---------------

So, on my 2.6.9, I replaced the '8' by 'fb_logo.depth' and now the logo is shown! (but the screen is still not cleared as before when the kernel boots).

Where's the QA guy ? I want to see him now ! ;-)

Cheers,

Ludovic DROLEZ                              Linbox / Free&ALter Soft
152 rue de Grigy - Technopole Metz 2000                   57070 METZ
tel : 03 87 50 87 90                            fax : 03 87 75 19 26
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [email protected]
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/


-------------------------------------------------------
This SF.Net email is sponsored by:
Sybase ASE Linux Express Edition - download now for FREE
LinuxWorld Reader's Choice Award Winner for best database on Linux.
http://ads.osdn.com/?ad_id=5588&alloc_id=12065&op=click