Skip to contentSkip to conversation

Compile breakage from me

DISCUSSION Jeff Garzik 2 participants 5 messages Oct 25, 2004

lore
Share & tools
lore
#0 lore raw

Argh, I thought GregKH had sent for_each_pci_dev()

Wearing a brown paper bag, can one of you please "cset -x" this changeset?

[email protected], 2004-10-21 18:47:50-04:00, [email protected]
[PATCH] hw_random.c: replace pci_find_device

As pci_find_device is going away I've replaced it with pci_get_device. for_each_pci_dev is a macro wrapper around pci_get_device. If someone with this hardware could test it I would appreciate it.

#1 lore raw
Quoted 4 lines · Jeff Garzik

Argh, I thought GregKH had sent for_each_pci_dev()

Wearing a brown paper bag, can one of you please "cset -x" this changeset?

How about just sending me the for_each_pci_dev() macro instead?

Linus

#3 lore raw
In reply to Linus Torvalds
Quoted 8 lines · Linus Torvalds
Quoted 1 line · Linus Torvalds

How about just sending me the for_each_pci_dev() macro instead?

Never mind. I just picked it up directly from my kernel mailing list archives instead - Hanna had already signed off on it.

Thanks!

Jeff

#2 lore raw
In reply to Linus Torvalds
Quoted 2 lines · Linus Torvalds

How about just sending me the for_each_pci_dev() macro instead?

Never mind. I just picked it up directly from my kernel mailing list archives instead - Hanna had already signed off on it.

Linus

#4 lore raw
Quoted 8 lines · Linus Torvalds
Quoted 1 line · Linus Torvalds

How about just sending me the for_each_pci_dev() macro instead?

Never mind. I just picked it up directly from my kernel mailing list archives instead - Hanna had already signed off on it.

hmmmm, so where do the 'gotten' references go?

drivers/char/hw_random.c 2004-10-25 16:18:50 -04:00 line 587

Quoted 11 lines
drivers/char/hw_random.c 2004-10-25 16:18:50 -04:00 +2 -1
@@ -581,7 +581,7 @@
        DPRINTK ("ENTER\n");
 
        /* Probe for Intel, AMD RNGs */
-       while ((pdev = pci_find_device(PCI_ANY_ID, PCI_ANY_ID, pdev)) != NULL) {
+       for_each_pci_dev(pdev) {
 
 
+#define for_each_pci_dev(d) while ((d = pci_get_device(PCI_ANY_ID, PCI_ANY_ID, d)) != NULL)

Jeff