Skip to contentSkip to conversation

Linux 2.4.28-rc1

DISCUSSION Applied O.Sezer 8 participants 16 messages Oct 26, 2004 – Nov 11, 2004

lore
Share & tools
lore

O.Sezer

author
#0 lore raw

There are many lost/forgotten patches posted here on lkml. Since 2.4.28 is near and 2.4 is going into "deep maintainance" mode soon, I gathered a short list of some of them. There, sure, are many more of them, but here it goes.
I think they deserve a re-review and re-consideration for inclusion.

Regards,
O. Sezer

The "list":
- Dave Jones: AMD K7 MCE changes backported from 2.6.
http://marc.theaimsgroup.com/?l=linux-kernel&m=106521456014393&w=2

- David Vrabel: TI CardBus PCI interrupt routing fix
http://marc.theaimsgroup.com/?l=linux-kernel&m=108446444125446&w=2

- Michael Mueller: opti-viper pci-chipset support
(have an updated-for-2.4.23+ patch for this)
http://marc.theaimsgroup.com/?t=106698970100002&r=1&w=2
http://marc.theaimsgroup.com/?l=linux-kernel&m=106698965700864&w=2

- Michael Frank: Highmem user-friendliness, Shutdown kernel on zone- alignment failure
(have an updated patch)
http://lkml.org/lkml/2004/2/7/51
http://marc.theaimsgroup.com/?t=107619437300052&r=1&w=2
http://marc.theaimsgroup.com/?l=linux-kernel&m=107619342911564&w=2

- Terry Hardie: 8 port SIIG serial card support
http://marc.theaimsgroup.com/?l=linux-kernel&m=107765546507508&w=2

- Mauricio Martinez/Corey Minyard: fix a problem (multiple reads of the same data) while reading from a CDU31 SONY CD-ROM drive
http://marc.theaimsgroup.com/?l=linux-kernel&m=106824345717317&w=2

- Roger Luethi: via-rhine, fix force media
http://marc.theaimsgroup.com/?l=linux-kernel&m=108507431710317&w=2

- Robert White: usbserial hangup on disconnect
http://marc.theaimsgroup.com/?t=108114071200002&r=1&w=2
http://marc.theaimsgroup.com/?l=linux-kernel&m=108114073600529&w=2

- V Ganesh: ipaq, hangup tty on usb disconnect
http://marc.theaimsgroup.com/?l=linux-usb-devel&m=109049411609590&w=2

- David M. Wilson: sis900 Wake-on-LAN support
http://marc.theaimsgroup.com/?l=linux-kernel&m=105835662823748&w=2

- Thomas Gleixner: sis5513 fix for SiS962 chipset
http://marc.theaimsgroup.com/?t=109482706500001&r=1&w=2
http://marc.theaimsgroup.com/?l=linux-kernel&m=109482716300929&w=2

- Eric Sandeen: fix for large direct I/O
http://marc.theaimsgroup.com/?l=linux-kernel&m=108197617129880&w=2

- Geert Uytterhoeven: smb_ops_unix compiler warning
http://marc.theaimsgroup.com/?l=linux-kernel&m=107659039710361&w=2

- David A. Lethe: scsi_scan.c, look for LUNs on XYRATEX RAID subsystems
http://marc.theaimsgroup.com/?l=linux-kernel&m=105534062611620&w=2

- Andrey Borzenkov: devfs deadlock on concurrent lookups on non-existent entry
http://marc.theaimsgroup.com/?l=linux-kernel&m=105630542714518&w=2

- Jim Carter: apm.c, Dell Inspiron, limit rate of power status calls (without the star to the asm code)
http://marc.theaimsgroup.com/?l=linux-kernel&m=106049225722612&w=2

- Eric Uhrhane: ATP867X PCI IDE driver: driver for the Acard/Artop PCI ATA/SATA cards (6885[LP]/6896[S]) based on the ATP867{A,B} chips.
http://marc.theaimsgroup.com/?l=linux-kernel&m=108198418515134&w=2

- Jakub Bogusz: missing include in farsync WAN driver
http://marc.theaimsgroup.com/?l=linux-kernel&m=109376793014054&w=2

- Willy Tarreau: MTU fix for tulip driver
http://marc.theaimsgroup.com/?l=linux-kernel&m=109130863303540&w=2

- Ivan Kokshaysky: alpha, make bootimage and make bootpfile failure, boot failure
http://marc.theaimsgroup.com/?t=109760337800003&r=1&w=2
http://marc.theaimsgroup.com/?l=linux-kernel&m=109820176212217&w=2

- Sam King: usbserial, down function call being made from an interrupt handler
http://marc.theaimsgroup.com/?t=109639065100005&r=1&w=2
http://marc.theaimsgroup.com/?l=linux-usb-devel&m=109639053122263&w=2

- Wolfgang Mues: auerswald-usb, kernel oops at disconnect or reconnect time because of an endless urb resubmit
http://marc.theaimsgroup.com/?l=linux-usb-devel&m=108465864428213&w=2

- Hilko Bengen: minor error in /proc/isapnp output
http://marc.theaimsgroup.com/?l=linux-kernel&m=107607982001162&w=2

- Joshua Kwan: scripts: Support output of new ld
http://marc.theaimsgroup.com/?t=109549085600003&r=1&w=2

- Joshua Kwan: kbuild: use infobox instead of msgbox and 'sleep 5'
http://marc.theaimsgroup.com/?l=linux-kernel&m=109549111519324&w=2

- Andre Hedrick: ide updates for 2.4.25
http://www.kernel.org/pub/linux/kernel/people/hedrick/ide-2.4.25/

#1 lore raw

Hi,

If you have been suddenly CC'ed to this message please search your name below - there is something which concerns you.

Replying only to the list, myself and O.Sezer is appreciated.

Quoted 3 lines · O.Sezer

There are many lost/forgotten patches posted here on lkml. Since 2.4.28 is near and 2.4 is going into "deep maintainance" mode soon, I gathered a short list of some of them.

Oh it is hard to bookkeep all of this. I hope people check and resend, but they dont do that always.

Quoted 1 line

There, sure, are many more of them, but here it goes.

Please send'em all. I really appreciate your efforts.

Quoted 8 lines

I think they deserve a re-review and re-consideration for inclusion.

Regards,
O. Sezer

The "list":
- Dave Jones: AMD K7 MCE changes backported from 2.6.
http://marc.theaimsgroup.com/?l=linux-kernel&m=106521456014393&w=2

Should be merged - Dave?

Quoted 2 lines

- David Vrabel: TI CardBus PCI interrupt routing fix
http://marc.theaimsgroup.com/?l=linux-kernel&m=108446444125446&w=2

Looks OK to me who dont have a clue about PCMCIA (it only tries to handle failure case, pretty safe).

rmk, can you take a look at this patch please?

Quoted 4 lines

- Michael Mueller: opti-viper pci-chipset support
(have an updated-for-2.4.23+ patch for this)
http://marc.theaimsgroup.com/?t=106698970100002&r=1&w=2
http://marc.theaimsgroup.com/?l=linux-kernel&m=106698965700864&w=2

Should be applied - v2.6 also lacks it AFAICS.

Quoted 6 lines

- Michael Frank: Highmem user-friendliness, Shutdown kernel on zone- alignment failure
(have an updated patch)
http://lkml.org/lkml/2004/2/7/51
http://marc.theaimsgroup.com/?t=107619437300052&r=1&w=2
http://marc.theaimsgroup.com/?l=linux-kernel&m=107619342911564&w=2

This is not really critical _and_ is the BUG is quite rare, thats why I haven't applied it.

Quoted 2 lines

- Terry Hardie: 8 port SIIG serial card support
http://marc.theaimsgroup.com/?l=linux-kernel&m=107765546507508&w=2

This one looks fine - I indeed missed it. Will apply to 2.4.29pre.

Is it present in v2.6 already?

Quoted 3 lines

- Mauricio Martinez/Corey Minyard: fix a problem (multiple reads of the same data) while reading from a CDU31 SONY CD-ROM drive
http://marc.theaimsgroup.com/?l=linux-kernel&m=106824345717317&w=2

I dont know this code at all and I'm not confident this is safe.

Maybe Jens can take a look at it?

What about v2.6?

Quoted 2 lines

- Roger Luethi: via-rhine, fix force media
http://marc.theaimsgroup.com/?l=linux-kernel&m=108507431710317&w=2

Seems fine - Roger?

Quoted 6 lines

- Robert White: usbserial hangup on disconnect
http://marc.theaimsgroup.com/?t=108114071200002&r=1&w=2
http://marc.theaimsgroup.com/?l=linux-kernel&m=108114073600529&w=2

- V Ganesh: ipaq, hangup tty on usb disconnect
http://marc.theaimsgroup.com/?l=linux-usb-devel&m=109049411609590&w=2

Pete, can you take a look at these?

Quoted 2 lines

- David M. Wilson: sis900 Wake-on-LAN support
http://marc.theaimsgroup.com/?l=linux-kernel&m=105835662823748&w=2

Jeff?

Quoted 3 lines

- Thomas Gleixner: sis5513 fix for SiS962 chipset
http://marc.theaimsgroup.com/?t=109482706500001&r=1&w=2
http://marc.theaimsgroup.com/?l=linux-kernel&m=109482716300929&w=2

Thomas?

Quoted 2 lines

- Eric Sandeen: fix for large direct I/O
http://marc.theaimsgroup.com/?l=linux-kernel&m=108197617129880&w=2

Ouch - missed that. Applied.

Quoted 2 lines

- Geert Uytterhoeven: smb_ops_unix compiler warning
http://marc.theaimsgroup.com/?l=linux-kernel&m=107659039710361&w=2

Will apply to 2.4.29pre.

Quoted 2 lines

- David A. Lethe: scsi_scan.c, look for LUNs on XYRATEX RAID subsystems
http://marc.theaimsgroup.com/?l=linux-kernel&m=105534062611620&w=2

[marcelo@logos scsi]$ grep XYRA *
scsi_scan.c: {"XYRATEX", "RS", "*", BLIST_SPARSELUN | BLIST_LARGELUN},

Seems to be present already.

Quoted 3 lines

- Andrey Borzenkov: devfs deadlock on concurrent lookups on non-existent entry
http://marc.theaimsgroup.com/?l=linux-kernel&m=105630542714518&w=2

Looks OK, will look again during 2.4.29pre.

Quoted 3 lines

- Jim Carter: apm.c, Dell Inspiron, limit rate of power status calls (without the star to the asm code)
http://marc.theaimsgroup.com/?l=linux-kernel&m=106049225722612&w=2

Dont know the code at all - seems to change generic code.

Quoted 3 lines

- Eric Uhrhane: ATP867X PCI IDE driver: driver for the Acard/Artop PCI ATA/SATA cards (6885[LP]/6896[S]) based on the ATP867{A,B} chips.
http://marc.theaimsgroup.com/?l=linux-kernel&m=108198418515134&w=2

Its a new driver - looks OK.

If the maintainer really cares about why didnt he resend me? v2.6 already has this driver?

Quoted 2 lines

- Jakub Bogusz: missing include in farsync WAN driver
http://marc.theaimsgroup.com/?l=linux-kernel&m=109376793014054&w=2

Applied.

Quoted 2 lines

- Willy Tarreau: MTU fix for tulip driver
http://marc.theaimsgroup.com/?l=linux-kernel&m=109130863303540&w=2

Jeff?

Quoted 4 lines

- Ivan Kokshaysky: alpha, make bootimage and make bootpfile failure, boot failure
http://marc.theaimsgroup.com/?t=109760337800003&r=1&w=2
http://marc.theaimsgroup.com/?l=linux-kernel&m=109820176212217&w=2

Ivan, can you please resend me this?

Quoted 8 lines

- Sam King: usbserial, down function call being made from an interrupt handler
http://marc.theaimsgroup.com/?t=109639065100005&r=1&w=2
http://marc.theaimsgroup.com/?l=linux-usb-devel&m=109639053122263&w=2

- Wolfgang Mues: auerswald-usb, kernel oops at disconnect or reconnect time because of an endless urb resubmit
http://marc.theaimsgroup.com/?l=linux-usb-devel&m=108465864428213&w=2

Pete, can you please a look.

Quoted 8 lines

- Hilko Bengen: minor error in /proc/isapnp output
http://marc.theaimsgroup.com/?l=linux-kernel&m=107607982001162&w=2

- Joshua Kwan: scripts: Support output of new ld
http://marc.theaimsgroup.com/?t=109549085600003&r=1&w=2

- Joshua Kwan: kbuild: use infobox instead of msgbox and 'sleep 5'
http://marc.theaimsgroup.com/?l=linux-kernel&m=109549111519324&w=2

2.4.29pre, all three.

Quoted 2 lines

- Andre Hedrick: ide updates for 2.4.25
http://www.kernel.org/pub/linux/kernel/people/hedrick/ide-2.4.25/

This I really dont know - I'm a complete IDE ignorant.

Alan, Bart maybe?

#14 lore raw
In reply to O.Sezer
Quoted 5 lines · O.Sezer

There are many lost/forgotten patches posted here on lkml. Since 2.4.28 is near and 2.4 is going into "deep maintainance" mode soon, I gathered a short list of some of them. There, sure, are many more of them, but here it goes.
I think they deserve a re-review and re-consideration for inclusion.

[snip]

Here's another one:
Jason Baron: 2.4.28-pre3 tty/ldisc fixes
http://marc.theaimsgroup.com/?l=linux-kernel&m=109604869516678&w=2

AFAICT the above patch is the fix for:
CAN-2004-0814: Linux terminal layer races
http://marc.theaimsgroup.com/?l=bugtraq&m=109837405025108&w=2

This patch seems to be working fine for me, but I don't know if anyone else has really tested it at all, nor do I know (one way or the other) if the security issues are serious enough to apply this for 2.4.28-rc and not 2.4.29-pre. Also, I'm running on a single-processor system with no HyperThreading, so if there are any SMP-related issues then I have no way of experiencing them.

Anyway, since it's a security fix (unless I'm mistaken), I guess it's worth considering for inclusion...

-Barry K. Nathan <[email protected]>

author
#3 lore raw
In reply to Marcelo Tosatti
Quoted 22 lines · Marcelo Tosatti

Hi,

If you have been suddenly CC'ed to this message please search your name below - there is something which concerns you.

Replying only to the list, myself and O.Sezer is appreciated.

Quoted 3 lines · O.Sezer

There are many lost/forgotten patches posted here on lkml. Since 2.4.28 is near and 2.4 is going into "deep maintainance" mode soon, I gathered a short list of some of them.

Oh it is hard to bookkeep all of this. I hope people check and resend, but they dont do that always.

Quoted 1 line

There, sure, are many more of them, but here it goes.

Please send'em all. I really appreciate your efforts.

[...]

Quoted 7 lines
Quoted 4 lines

- Michael Mueller: opti-viper pci-chipset support
(have an updated-for-2.4.23+ patch for this)
http://marc.theaimsgroup.com/?t=106698970100002&r=1&w=2
http://marc.theaimsgroup.com/?l=linux-kernel&m=106698965700864&w=2

Should be applied - v2.6 also lacks it AFAICS.

Attached is a one that's supposed to apply cleanly to and work with 2.4.23+ kernels.

arch/i386/kernel/pci-irq.c renamed from arch/i386/kernel/pci-irq.c~ +47 -2
@@ -241,18 +241,56 @@
 }
 
 static int pirq_opti_set(struct pci_dev *router, struct pci_dev *dev, int pirq, int irq)
 {
 	write_config_nybble(router, 0xb8, pirq >> 4, irq);
 	return 1;
 }
 
 /*
+ * OPTI Viper-M/N+: Bit field with 3 bits per entry.
+ * Due to the lack of a specification the information about this chipset
+ * was taken from the NetBSD source code.
+ */
+static int pirq_viper_get(struct pci_dev *router, struct pci_dev *dev, int pirq)
+{
+	static const int viper_irq_decode[] = { 0, 5, 9, 10, 11, 12, 14, 15 };
+	u32 irq;
+
+	pci_read_config_dword(router, 0x40, &irq);
+	irq >>= (pirq-1)*3;
+	irq &= 7;
+
+	return viper_irq_decode[irq];
+}
+
+static int pirq_viper_set(struct pci_dev *router, struct pci_dev *dev, int pirq, int irq)
+{
+	static const int viper_irq_map[] = { -1, -1, -1, -1, -1, 1, -1, -1, -1, 2, 3, 4, 5, -1, 6, 7 };
+	int newval = viper_irq_map[irq];
+	u32 val;
+	u32 mask = 7 << (3*(pirq-1));
+#if 0
+	mask |= 0x10000UL << (pirq-1);	/* edge triggered */
+#endif
+
+	if ( newval == -1 )
+		return 0;
+	
+	pci_read_config_dword(router, 0x40, &val);
+	val &= ~mask;
+	val |= newval << (3*(pirq-1));
+	pci_write_config_dword(router, 0x40, val);
+
+	return 1;
+}
+
+/*
  * Cyrix: nibble offset 0x5C
  */
 static int pirq_cyrix_get(struct pci_dev *router, struct pci_dev *dev, int pirq)
 {
 	return read_config_nybble(router, 0x5C, (pirq-1)^1);
 }
 
 static int pirq_cyrix_set(struct pci_dev *router, struct pci_dev *dev, int pirq, int irq)
 {
@@ -707,21 +745,28 @@
 
 static __init int opti_router_probe(struct irq_router *r, struct pci_dev *router, u16 device)
 {
 	switch(device)
 	{
 		case PCI_DEVICE_ID_OPTI_82C700:
 			r->name = "OPTI";
 			r->get = pirq_opti_get;
 			r->set = pirq_opti_set;
-			return 1;
+			break;
+		case PCI_DEVICE_ID_OPTI_82C558:
+			r->name = "OPTI VIPER";
+			r->get = pirq_viper_get;
+			r->set = pirq_viper_set;
+			break;
+		default:
+			return 0;
 	}
-	return 0;
+	return 1;
 }
 
 static __init int ite_router_probe(struct irq_router *r, struct pci_dev *router, u16 device)
 {
 	switch(device)
 	{
 		case PCI_DEVICE_ID_ITE_IT8330G_0:
 			r->name = "ITE";
 			r->get = pirq_ite_get;
#4 lore raw
Quoted 5 lines · O.Sezer

/*
+ * OPTI Viper-M/N+: Bit field with 3 bits per entry.
+ * Due to the lack of a specification the information about this chipset
+ * was taken from the NetBSD source code.
+ */

I still have a lot of olde opti stuff downloaded from their ftp site about 6 years ago, including Viper docs. If you (or anyone else) is interested let me know, and I'll send them on.

Dave

author
#5 lore raw
Quoted 7 lines · Dave Jones
Quoted 5 lines · O.Sezer

/*
+ * OPTI Viper-M/N+: Bit field with 3 bits per entry.
+ * Due to the lack of a specification the information about this chipset
+ * was taken from the NetBSD source code.
+ */

Quoted 6 lines

I still have a lot of olde opti stuff downloaded from their ftp site about 6 years ago, including Viper docs. If you (or anyone else) is interested let me know, and I'll send them on.

Dave

Would be nice to have around. (They're not online anymore, I assume?)

Ozkan.

#6 lore raw
Quoted 5 lines · O.Sezer
Quoted 3 lines

I still have a lot of olde opti stuff downloaded from their ftp site about 6 years ago, including Viper docs. If you (or anyone else) is interested let me know, and I'll send them on.

Would be nice to have around. (They're not online anymore, I assume?)

not afaik, ftp.opti.com.tw doesn't seem to be around anymore, and their .com site doesn't answer ftp. (and www is really nondescript)

I'll tar them up and send them your way.

Dave

#10 lore raw
In reply to Marcelo Tosatti
Quoted 8 lines · Marcelo Tosatti
Quoted 6 lines

- Robert White: usbserial hangup on disconnect
http://marc.theaimsgroup.com/?t=108114071200002&r=1&w=2
http://marc.theaimsgroup.com/?l=linux-kernel&m=108114073600529&w=2

- V Ganesh: ipaq, hangup tty on usb disconnect
http://marc.theaimsgroup.com/?l=linux-usb-devel&m=109049411609590&w=2

Pete, can you take a look at these?

I already did, I just keep procrastinating. Better is an enemy of good. I wanted to adopt 2.6 style refcounting, because there's a possibility of oops lurking in 2.4 code. That would move the hangup call into the close/release path.

The top part of V. Ganesh's patch with a missing initialization you already have in -rc1. The bottom part Robert's patch covers (modulo the relocation of the whole fragment).

I'll make a better 2.6 style patch as soon as I can. Maybe today even.

-- Pete

#11 lore raw
In reply to Marcelo Tosatti
Quoted 5 lines · Marcelo Tosatti
Quoted 2 lines

- David M. Wilson: sis900 Wake-on-LAN support
http://marc.theaimsgroup.com/?l=linux-kernel&m=105835662823748&w=2

Jeff?

Two principal objections:

1) 2.6 first

2) should use the already-present ethtool WOL interface rather than inventing your own

Quoted 5 lines
Quoted 2 lines

- Willy Tarreau: MTU fix for tulip driver
http://marc.theaimsgroup.com/?l=linux-kernel&m=109130863303540&w=2

Jeff?

Looks OK but I would prefer at least a 2.6 version in parallel...

Jeff

#7 lore raw
In reply to O.Sezer
Quoted 30 lines · O.Sezer
Quoted 22 lines · Marcelo Tosatti

Hi,

If you have been suddenly CC'ed to this message please search your name below - there is something which concerns you.

Replying only to the list, myself and O.Sezer is appreciated.

Quoted 3 lines · O.Sezer

There are many lost/forgotten patches posted here on lkml. Since 2.4.28 is near and 2.4 is going into "deep maintainance" mode soon, I gathered a short list of some of them.

Oh it is hard to bookkeep all of this. I hope people check and resend, but they dont do that always.

Quoted 1 line

There, sure, are many more of them, but here it goes.

Please send'em all. I really appreciate your efforts.

[...]

Quoted 6 lines
Quoted 4 lines

- Michael Mueller: opti-viper pci-chipset support
(have an updated-for-2.4.23+ patch for this)
http://marc.theaimsgroup.com/?t=106698970100002&r=1&w=2
http://marc.theaimsgroup.com/?l=linux-kernel&m=106698965700864&w=2

Quoted 4 lines
Quoted 1 line

Should be applied - v2.6 also lacks it AFAICS.

Attached is a one that's supposed to apply cleanly to and work with 2.4.23+ kernels.

Ozkan,

Someone needs to check v2.6.

Can you or Michael do that please?

I'll save it to 2.4.29pre.

#15 lore raw
In reply to Barry K. Nathan
Quoted 23 lines · Barry K. Nathan
Quoted 5 lines · O.Sezer

There are many lost/forgotten patches posted here on lkml. Since 2.4.28 is near and 2.4 is going into "deep maintainance" mode soon, I gathered a short list of some of them. There, sure, are many more of them, but here it goes.
I think they deserve a re-review and re-consideration for inclusion.

[snip]

Here's another one:
Jason Baron: 2.4.28-pre3 tty/ldisc fixes
http://marc.theaimsgroup.com/?l=linux-kernel&m=109604869516678&w=2

AFAICT the above patch is the fix for:
CAN-2004-0814: Linux terminal layer races
http://marc.theaimsgroup.com/?l=bugtraq&m=109837405025108&w=2

This patch seems to be working fine for me, but I don't know if anyone else has really tested it at all, nor do I know (one way or the other) if the security issues are serious enough to apply this for 2.4.28-rc and not 2.4.29-pre. Also, I'm running on a single-processor system with no HyperThreading, so if there are any SMP-related issues then I have no way of experiencing them.

Quoted 2 lines

Anyway, since it's a security fix (unless I'm mistaken), I guess it's worth considering for inclusion...

Hi Barry,

I think this should be applied as well. The next
-pre makes me more comfortable.

Jason, Alan?

#12 lore raw
In reply to Marcelo Tosatti
Quoted 7 lines · Marcelo Tosatti
Quoted 2 lines

- David Vrabel: TI CardBus PCI interrupt routing fix
http://marc.theaimsgroup.com/?l=linux-kernel&m=108446444125446&w=2

Looks OK to me who dont have a clue about PCMCIA (it only tries to handle failure case, pretty safe).

rmk, can you take a look at this patch please?

I think this should be rejected, but since I'm not in posession of 2.4 source code anymore, I don't really know.

We did a lot of work in 2.6 to fix these issues properly. I don't think a "simple" fix is acceptable. However, changing "irqmux" to be u32 is obviously correct whatever.

Signature · 4 lines
Russell King
 Linux kernel    2.6 ARM Linux   - http://www.arm.linux.org.uk/
 maintainer of:  2.6 PCMCIA      - http://pcmcia.arm.linux.org.uk/
                 2.6 Serial core
author
#8 lore raw
In reply to Marcelo Tosatti
Quoted 43 lines · Marcelo Tosatti
Quoted 35 lines · O.Sezer
Quoted 24 lines · Marcelo Tosatti

Hi,

If you have been suddenly CC'ed to this message please search your name below - there is something which concerns you.

Replying only to the list, myself and O.Sezer is appreciated.

Quoted 3 lines · O.Sezer

There are many lost/forgotten patches posted here on lkml. Since 2.4.28 is near and 2.4 is going into "deep maintainance" mode soon, I gathered a short list of some of them.

Oh it is hard to bookkeep all of this. I hope people check and resend, but they dont do that always.

Quoted 1 line

There, sure, are many more of them, but here it goes.

Please send'em all. I really appreciate your efforts.

[...]

Quoted 6 lines
Quoted 4 lines

- Michael Mueller: opti-viper pci-chipset support
(have an updated-for-2.4.23+ patch for this)
http://marc.theaimsgroup.com/?t=106698970100002&r=1&w=2
http://marc.theaimsgroup.com/?l=linux-kernel&m=106698965700864&w=2

Quoted 4 lines
Quoted 1 line

Should be applied - v2.6 also lacks it AFAICS.

Attached is a one that's supposed to apply cleanly to and work with 2.4.23+ kernels.

Quoted 8 lines

Ozkan,

Someone needs to check v2.6.

Can you or Michael do that please?

I'll save it to 2.4.29pre.

2.6 doesn't have it but I don't know if it needs it (it should, but...) I don't have the hardware anymore, so Michael can look after it, I'm sure.

author
#9 lore raw
Quoted 55 lines · O.Sezer
Quoted 53 lines · Marcelo Tosatti
Quoted 39 lines · O.Sezer
Quoted 26 lines · Marcelo Tosatti

Hi,

If you have been suddenly CC'ed to this message please search your name below - there is something which concerns you.

Replying only to the list, myself and O.Sezer is appreciated.

Quoted 3 lines · O.Sezer

There are many lost/forgotten patches posted here on lkml. Since 2.4.28 is near and 2.4 is going into "deep maintainance" mode soon, I gathered a short list of some of them.

Oh it is hard to bookkeep all of this. I hope people check and resend, but they dont do that always.

Quoted 1 line

There, sure, are many more of them, but here it goes.

Please send'em all. I really appreciate your efforts.

[...]

Quoted 7 lines
Quoted 4 lines

- Michael Mueller: opti-viper pci-chipset support
(have an updated-for-2.4.23+ patch for this)
http://marc.theaimsgroup.com/?t=106698970100002&r=1&w=2
http://marc.theaimsgroup.com/?l=linux-kernel&m=106698965700864&w=2

Quoted 5 lines
Quoted 1 line

Should be applied - v2.6 also lacks it AFAICS.

Attached is a one that's supposed to apply cleanly to and work with 2.4.23+ kernels.

Ozkan,

Someone needs to check v2.6.

Quoted 9 lines
Quoted 3 lines

Can you or Michael do that please?

I'll save it to 2.4.29pre.

2.6 doesn't have it but I don't know if it needs it (it should, but...) I don't have the hardware anymore, so Michael can look after it, I'm sure.

OK, out of curiosity, I did a quick re-diff of the patch, applied onto the correct file, and did a real quick compile test (and nothing more). Nothing went bad. Can't say anything about functionality (Michael?). It is attached. Whom to send it? Linus, akpm?

arch/i386/pci/irq.c renamed from arch/i386/pci/irq.c~ +47 -2
@@ -250,6 +250,44 @@
 }
 
 /*
+ * OPTI Viper-M/N+: Bit field with 3 bits per entry.
+ * Due to the lack of a specification the information about this chipset
+ * was taken from the NetBSD source code.
+ */
+static int pirq_viper_get(struct pci_dev *router, struct pci_dev *dev, int pirq)
+{
+	static const int viper_irq_decode[] = { 0, 5, 9, 10, 11, 12, 14, 15 };
+	u32 irq;
+
+	pci_read_config_dword(router, 0x40, &irq);
+	irq >>= (pirq-1)*3;
+	irq &= 7;
+
+	return viper_irq_decode[irq];
+}
+
+static int pirq_viper_set(struct pci_dev *router, struct pci_dev *dev, int pirq, int irq)
+{
+	static const int viper_irq_map[] = { -1, -1, -1, -1, -1, 1, -1, -1, -1, 2, 3, 4, 5, -1, 6, 7 };
+	int newval = viper_irq_map[irq];
+	u32 val;
+	u32 mask = 7 << (3*(pirq-1));
+#if 0
+	mask |= 0x10000UL << (pirq-1);	/* edge triggered */
+#endif
+
+	if ( newval == -1 )
+		return 0;
+	
+	pci_read_config_dword(router, 0x40, &val);
+	val &= ~mask;
+	val |= newval << (3*(pirq-1));
+	pci_write_config_dword(router, 0x40, val);
+
+	return 1;
+}
+
+/*
  * Cyrix: nibble offset 0x5C
  * 0x5C bits 7:4 is INTB bits 3:0 is INTA 
  * 0x5D bits 7:4 is INTD bits 3:0 is INTC
@@ -567,9 +605,16 @@
 			r->name = "OPTI";
 			r->get = pirq_opti_get;
 			r->set = pirq_opti_set;
-			return 1;
+			break;
+		case PCI_DEVICE_ID_OPTI_82C558:
+			r->name = "OPTI VIPER";
+			r->get = pirq_viper_get;
+			r->set = pirq_viper_set;
+			break;
+		default:
+			return 0;
 	}
-	return 0;
+	return 1;
 }
 
 static __init int ite_router_probe(struct irq_router *r, struct pci_dev *router, u16 device)
#13 lore raw
In reply to Marcelo Tosatti
Quoted 2 lines · Marcelo Tosatti

If you have been suddenly CC'ed to this message please search your name below - there is something which concerns you.

It might have helped to CC me, too :-/.

Quoted 4 lines
Quoted 2 lines

- Roger Luethi: via-rhine, fix force media
http://marc.theaimsgroup.com/?l=linux-kernel&m=108507431710317&w=2

Seems fine - Roger?

ACK. It's not a big deal either way, but it should go in if only for correctness' sake.

Roger