iSCSI transport class

PATCH In review Mike Christie 2 participants 2 messages Oct 29, 2004 – Nov 10, 2004

Subsystems (2)

SCSI iSCSI

lore

Share & tools

lore

Mike Christie

author

2004-10-29 12:15 UTC #0 lore raw

PATCH 1/1 iSCSI transport class

The attached patch adds an iSCSI transport class. It was built against scsi-misc-2.6. It allows the software/virtual iSCSI driver to remove at least one of its ioctl commands. The patch also assumes the no multipath/failover rule in llds applies to iSCSI drivers, so when we remove our portal/portal_group failover support it will allow us to kill all our ioctl commands execpt the session creation one (that will take more thought).

We would like to build some functions like the unblock/block capabilites into the iscsi transport class like James Smart has done with FC class. but initially we would like to begin with this smaller patch that only provides an iscsi sysfs interface.

Comments? Suggestions?

I put some patches to convert our driver here
http://www.cs.wisc.edu/~michaelc/iscsi/sysfs/
if you want to test the class out. Those patches were made against the current linux-iscsi cvs tree.

Mike Christie

drivers/scsi/Kconfig +8 -0

diff -Naurp scsi-misc-2.6.orig/drivers/scsi/Kconfig scsi-misc-2.6.work/drivers/scsi/Kconfig
@@ -203,6 +203,14 @@ config SCSI_FC_ATTRS
 	  each attached FiberChannel device to sysfs, say Y.
 	  Otherwise, say N.
 
+config SCSI_ISCSI_ATTRS
+	tristate "iSCSI Transport Attributes"
+	depends on SCSI
+	help
+	  If you wish to export transport-specific information about
+	  each attached iSCSI device to sysfs, say Y.
+	  Otherwise, say N.
+
 endmenu
 
 menu "SCSI low-level drivers"

drivers/scsi/Makefile +1 -1

diff -Naurp scsi-misc-2.6.orig/drivers/scsi/Makefile scsi-misc-2.6.work/drivers/scsi/Makefile
@@ -28,7 +28,7 @@ obj-$(CONFIG_SCSI)		+= scsi_mod.o
 # --------------------------
 obj-$(CONFIG_SCSI_SPI_ATTRS)	+= scsi_transport_spi.o
 obj-$(CONFIG_SCSI_FC_ATTRS) 	+= scsi_transport_fc.o
-
+obj-$(CONFIG_SCSI_ISCSI_ATTRS)	+= scsi_transport_iscsi.o
 
 obj-$(CONFIG_SCSI_AMIGA7XX)	+= amiga7xx.o	53c7xx.o
 obj-$(CONFIG_A3000_SCSI)	+= a3000.o	wd33c93.o

drivers/scsi/scsi_transport_iscsi.c +355 -0

355 lines not on this page · raw message

include/scsi/scsi_transport_iscsi.h +178 -0

178 lines not on this page · raw message

Smitha Narayanaswamy (smithan)

2004-11-10 14:17 UTC #1 lore raw

I think the patch looks fine.

Thanks,
Smitha

Quoted 35 lines

-----Original Message-----
From: [email protected] [mailto:[email protected]] On Behalf Of Mike Christie
Sent: Friday, October 29, 2004 5:45 PM
To: [email protected]; [email protected]; [email protected]; James Dykman
Subject: [linux-iscsi-devel] [PATCH] iSCSI transport class
The attached patch adds an iSCSI transport class. It was built against scsi-misc-2.6. It allows the software/virtual iSCSI driver to remove at least one of its ioctl commands. The patch also assumes the no multipath/failover rule in llds applies to iSCSI drivers, so when we remove our portal/portal_group failover support it will allow us to kill all our ioctl commands execpt the session creation one (that will take more thought).
We would like to build some functions like the unblock/block capabilites into the iscsi transport class like James Smart has done with FC class. but initially we would like to begin with this smaller patch that only provides an iscsi sysfs interface.
Comments? Suggestions?
I put some patches to convert our driver here
http://www.cs.wisc.edu/~michaelc/iscsi/sysfs/
if you want to test the class out. Those patches were made against the current linux-iscsi cvs tree.
Mike Christie