Skip to contentSkip to conversation

mxb driver and i2c helper cleanup

PATCH New Michael Hunold 1 participant 1 message Nov 4, 2004 Media (V4L/DVB)

lore
Share & tools
lore

Michael Hunold

author
#0 lore raw

PATCH 1/1 mxb driver and i2c helper cleanup

Hi all,

the attached patch cleans up my Video4Linux "MXB" driver and the i2c helper chipset drivers used by that cards.

I ran Lindent on the files and fixed some other coding style violations, which makes the patch rather big.

But besides the MODULE_PARM => module_param there have been no crucial changes.

Please apply.

Thanks
Michael.

- [V4L] mxb: replace MODULE_PARM with module_param
- [V4L] saa7111: replace MODULE_PARM with module_param
- [V4L] tda9840: replace MODULE_PARM with module_param, re-indent code with Lindent, remove unnecessary header includes, code simplification
- [V4L] tea6415c: replace MODULE_PARM with module_param, re-indent code with Lindent, remove unnecessary header includes, code simplification
- [V4L] tea6420: replace MODULE_PARM with module_param, re-indent code with Lindent, remove unnecessary header includes, code simplification

Signed-off-by Michael Hunold <[email protected]>
drivers/media/video/mxb.c +4 -4
diff -ura b/drivers/media/video/mxb.c linux-2.6.10-rc1-bk9-debug/drivers/media/video/mxb.c
@@ -1,5 +1,5 @@
 /*
-    mxb.c - v4l2 driver for the Multimedia eXtension Board
+    mxb - v4l2 driver for the Multimedia eXtension Board
     
     Copyright (C) 1998-2003 Michael Hunold <[email protected]>
 

@@ -43,12 +43,12 @@
    in verden (lower saxony, germany) 4148 is a
    channel called "phoenix" */
 static int freq = 4148;
-MODULE_PARM(freq,"i");
+module_param(freq, int, 0644);
 MODULE_PARM_DESC(freq, "initial frequency the tuner will be tuned to while setup");
 
 static int debug = 0;
-MODULE_PARM(debug,"i");
-MODULE_PARM_DESC(debug, "debug verbosity");
+module_param(debug, int, 0644);
+MODULE_PARM_DESC(debug, "Turn on/off device debugging (default:off).");
 
 #define MXB_INPUTS 4
 enum { TUNER, AUX1, AUX3, AUX3_YC };
drivers/media/video/saa7111.c +1 -1
diff -ura b/drivers/media/video/saa7111.c linux-2.6.10-rc1-bk9-debug/drivers/media/video/saa7111.c
@@ -60,7 +60,7 @@
 #include <linux/video_decoder.h>
 
 static int debug = 0;
-MODULE_PARM(debug, "i");
+module_param(debug, int, 0644);
 MODULE_PARM_DESC(debug, "Debug level (0-1)");
 
 #define dprintk(num, format, args...) \
drivers/media/video/tda9840.c +141 -172

413 lines not on this page · raw message

drivers/media/video/tea6415c.c +109 -118

336 lines not on this page · raw message

drivers/media/video/tea6420.c +82 -93

281 lines not on this page · raw message