Skip to contentSkip to conversation

boot option for CONFIG_EDD_SKIP_MBR?

DISCUSSION Carl-Daniel Hailfinger 3 participants 4 messages Nov 4, 2004

lore
Share & tools
lore
#0 lore raw

Hi Matt,

[please CC: me on replies]
having had problems (inifinte hang on boot) with some Fujitsu Siemens Scenic computers when EDD was enabled, I asked myself if it would be possible to add a boot option edd=nombr and possibly also another boot option edd=off to the EDD code in the kernel. These would correspond to CONFIG_EDD_SKIP_MBR and CONFIG_EDD, respectively.
That way, distributors could use the benefits of enabled EDD on working machines and provide customers with the ability to switch off EDD on broken machines, all with the same kernel.
Yes, option parsing before entering protected mode is ugly, but the vga setup code does it, too.

What do you think?

Regards,
Carl-Daniel

Signature · 1 line
http://www.hailfinger.org/
#1 lore raw
Quoted 8 lines · Carl-Daniel Hailfinger

[please CC: me on replies]
having had problems (inifinte hang on boot) with some Fujitsu Siemens Scenic computers when EDD was enabled, I asked myself if it would be possible to add a boot option edd=nombr and possibly also another boot option edd=off to the EDD code in the kernel. These would correspond to CONFIG_EDD_SKIP_MBR and CONFIG_EDD, respectively.

Quoted 4 lines

Yes, option parsing before entering protected mode is ugly, but the vga setup code does it, too.

What do you think?

I'd love it. I hadn't done it as I thought it would be ugly, and so far I could blame buggy BIOSes for the delay. If you want to work up a patch, I'll gladly review and apply something that does such.

Thanks,
Matt

Signature · 4 lines
Matt Domsch
Sr. Software Engineer, Lead Engineer
Dell Linux Solutions linux.dell.com & www.dell.com/linux
Linux on Dell mailing lists @ http://lists.us.dell.com
#2 lore raw
Quoted 9 lines · Matt Domsch
Quoted 8 lines · Carl-Daniel Hailfinger

[please CC: me on replies]
having had problems (inifinte hang on boot) with some Fujitsu Siemens Scenic computers when EDD was enabled, I asked myself if it would be possible to add a boot option edd=nombr and possibly also another boot option edd=off to the EDD code in the kernel. These would correspond to CONFIG_EDD_SKIP_MBR and CONFIG_EDD, respectively.

Quoted 8 lines
Quoted 4 lines

Yes, option parsing before entering protected mode is ugly, but the vga setup code does it, too.

What do you think?

I'd love it. I hadn't done it as I thought it would be ugly, and so far I could blame buggy BIOSes for the delay. If you want to work up a patch, I'll gladly review and apply something that does such.

But would this actually be useful for the cases where EDD has been broken so far ? AFAIR, the bootparam parsing happens /after/ we do the 16-bit EDD asm foo.

Dave

#3 lore raw
Quoted 15 lines · Dave Jones
Quoted 14 lines · Matt Domsch
Quoted 12 lines · Carl-Daniel Hailfinger

[please CC: me on replies]
having had problems (inifinte hang on boot) with some Fujitsu Siemens Scenic computers when EDD was enabled, I asked myself if it would be possible to add a boot option edd=nombr and possibly also another boot option edd=off to the EDD code in the kernel. These would correspond to CONFIG_EDD_SKIP_MBR and CONFIG_EDD, respectively.

Yes, option parsing before entering protected mode is ugly, but the vga setup code does it, too.

What do you think?

Quoted 7 lines
Quoted 3 lines

I'd love it. I hadn't done it as I thought it would be ugly, and so far I could blame buggy BIOSes for the delay. If you want to work up a patch, I'll gladly review and apply something that does such.

But would this actually be useful for the cases where EDD has been broken so far ? AFAIR, the bootparam parsing happens /after/ we do the 16-bit EDD asm foo.

AFAIR the VGA setup code does its bootparam parsing by hand because it suffers from the same problem.

Regards,
Carl-Daniel

Signature · 1 line
http://www.hailfinger.org/