Skip to contentSkip to conversation

sr module_param conversion

PATCH In review Jan Dittmer 2 participants 2 messages Nov 13, 2004 – Nov 21, 2004 SCSI

lore
Share & tools
lore

Jan Dittmer

author
#0 lore raw

PATCH 1/1 sr module_param conversion

module_param conversion for SCSI cdrom driver

Signed-off-by Jan Dittmer <[email protected]>
drivers/scsi/sr.c +0 -3
diff -Nru a/drivers/scsi/sr.c b/drivers/scsi/sr.c
@@ -59,9 +59,6 @@
 #include "sr.h"
 
 
-MODULE_PARM(xa_test, "i");	/* see sr_ioctl.c */
-
-
 #define SR_DISKS	256
 
 #define MAX_RETRIES	3
drivers/scsi/sr_ioctl.c +3 -0
diff -Nru a/drivers/scsi/sr_ioctl.c b/drivers/scsi/sr_ioctl.c
@@ -29,6 +29,9 @@
  * It is off by default and can be turned on with this module parameter */
 static int xa_test = 0;
 
+module_param(xa_test, int, S_IRUGO | S_IWUSR);
+
+
 #define IOCTL_RETRIES 3
 
 /* ATAPI drives don't have a SCMD_PLAYAUDIO_TI command.  When these drives
#1 lore raw
Quoted 8 lines · Jan Dittmer

module_param conversion for SCSI cdrom driver

Signed-off-by Jan Dittmer <[email protected]>

diff -Nru a/drivers/scsi/sr_ioctl.c b/drivers/scsi/sr_ioctl.c

drivers/scsi/sr_ioctl.c line 34

Quoted 6 lines
drivers/scsi/sr_ioctl.c +3 -0
@@ -29,6 +29,9 @@
  * It is off by default and can be turned on with this module parameter */
 static int xa_test = 0;
 
+module_param(xa_test, int, S_IRUGO | S_IWUSR);
+
+

I think it should be "bool" instead of "int". And one newline should be enough for everyone.

You should CC [email protected] and James Bottomley <[email protected]> to get this applied.

Eike