Skip to contentSkip to conversation

Patch for ADSVIX single board computer with PXA27x processor

U-Boot-Users Robert Whaley 2 participants 4 messages Nov 29, 2004 – Apr 7, 2005

lore
Share & tools
lore
#1 lore raw
Quoted 2 lines · In message <[email protected]> you wrote:

This patch adds support for the ADSVIX SBC with PXA27x processor.

Mostly added.

Please provide a proper patch next time (CHANGELOG entry), and stick to the Coding Style (indentation by TAB, no trailing white space, etc.)

Here is what I rejected:

common/cmd_pcmcia.c +9 -0
diff -urN u-boot/common/cmd_pcmcia.c u-boot.vix/common/cmd_pcmcia.c
@@ -382,6 +382,11 @@
 
 #endif /* EXADRON 1 */
 
+#ifdef CONFIG_ADSVIX
+	void pcmcia_power_on(void);
+	pcmcia_power_on();
+#endif
+
 	rc = check_ide_device (0);	/* use just slot 0 */
 
 	return rc;

@@ -445,6 +450,10 @@
 #ifdef CONFIG_PXA_PCMCIA
 static int pcmcia_off (void)
 {
+#ifdef CONFIG_ADSVIX
+        void pcmcia_power_off(void);
+        pcmcia_power_off();
+#endif
 	return 0;
 }
 #endif

Please implement this in a board independent way, something like

#ifdef CONFIG_BOARD_PCMCIA_POWERON
	boardpcmcia_power_on();

#endif

or so.

examples/Makefile +5 -1
diff -urN u-boot/examples/Makefile u-boot.vix/examples/Makefile
@@ -30,7 +30,11 @@
 endif
 
 ifeq ($(ARCH),arm)
-LOAD_ADDR = 0xc100000
+ifeq ($(CPU),pxa)
+LOAD_ADDR = 0xa1000000
+else
+LOAD_ADDR = 0xc1000000
+endif
 endif

Please don't mess with other boards.

Best regards,

Wolfgang Denk

Signature · 4 lines
Software Engineering:  Embedded and Realtime Systems,  Embedded Linux
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
In general, if you think something isn't in Perl, try it out, because
it usually is :-) - Larry Wall in <[email protected]>
author
#2 lore raw
Quoted 10 lines · Wolfgang Denk
Quoted 1 line · In message <[email protected]> you wrote:

This patch adds support for the ADSVIX SBC with PXA27x processor.

Mostly added.

Please provide a proper patch next time (CHANGELOG entry), and stick to the Coding Style (indentation by TAB, no trailing white space, etc.)

Sorry.

Quoted 3 lines

Here is what I rejected:

...

Quoted 7 lines

diff -urN u-boot/examples/Makefile u-boot.vix/examples/Makefile

examples/Makefile +0 -0
@@ -30,7 +30,11 @@
 endif

examples/Makefile line 39

Quoted 10 lines
examples/Makefile +5 -1
 
 ifeq ($(ARCH),arm)
-LOAD_ADDR = 0xc100000
+ifeq ($(CPU),pxa)
+LOAD_ADDR = 0xa1000000
+else
+LOAD_ADDR = 0xc1000000
+endif
 endif

OK, but note that PXA DRAM can't be at 0xCxxxxxxx (that is a reserved address) it has to be at 0xAxxxxxxx.

Signature · 3 lines
Robert Whaley
Applied Data Systems            www.applieddata.net
434-244-9504		    rwhaley at applieddata.net
#3 lore raw
Quoted 7 lines · In message <[email protected]> you wrote:
Quoted 7 lines

diff -urN u-boot/examples/Makefile u-boot.vix/examples/Makefile

examples/Makefile +0 -0
@@ -30,7 +30,11 @@
 endif
Quoted 12 lines

examples/Makefile line 39

Quoted 9 lines
examples/Makefile +5 -1
 ifeq ($(ARCH),arm)
-LOAD_ADDR = 0xc100000
+ifeq ($(CPU),pxa)
+LOAD_ADDR = 0xa1000000
+else
+LOAD_ADDR = 0xc1000000
+endif
 endif

OK, but note that PXA DRAM can't be at 0xCxxxxxxx (that is a reserved address) it has to be at 0xAxxxxxxx.

Maybe. But then please don't mess with other baords (and don't tell me that 0xc1000000 is the same as 0xc100000).

Best regards,

Wolfgang Denk

Signature · 3 lines
Software Engineering:  Embedded and Realtime Systems,  Embedded Linux
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
Sorry, but my karma just ran over your dogma.