[Fwd: Re: do_posix_clock_monotonic_gettime() returns negative nsec]
Just adding my sign off. Using forward to avoid the dreaded ">" marks
-------- Original Message --------
Subject: Re: do_posix_clock_monotonic_gettime() returns negative nsec
Date: Fri, 3 Dec 2004 18:22:03 +0100
From: Herbert Poetzl <[email protected]>
To: George Anzinger <[email protected]>
CC: Andrew Morton <[email protected]>, [email protected]
References: <[email protected]> <[email protected]> <[email protected]> <[email protected]>
Quoted 64 lines · George Anzinger
Quoted 56 lines · Herbert Poetzl
Quoted 34 lines · Andrew Morton
Quoted 32 lines · Herbert Poetzl
Hi Folks!
recent kernels (tested 2.6.10-rc2 and 2.6.10-rc2-bk15) produce funny output in
/proc/uptimelike this:# cat /proc/uptime 12.4294967218 9.05 # cat /proc/uptime 13.4294967251 10.33 # cat /proc/uptime 14.4294967295 11.73a short investigation of the issue, ended at
do_posix_clock_monotonic_gettime()which can (and often does) return negative nsec values (within one second), so while the actual 'time' returned
is correct, some parts of the kernel assume that
those part is within the range (0 -NSEC_PER_SEC)len = sprintf(page,"%lu.%02lu %lu.%02lu\n", (unsigned long) uptime.tv_sec, (uptime.tv_nsec / (NSEC_PER_SEC / 100)),as the function itself corrects overflows, it would
make sense to me to correct underflows too, for example with the following patch:kernel/posix-timers.c renamed from kernel/posix-timers.c.orig +0
-0@@ -1208,7 +1208,10 @@ int do_posix_clock_monotonic_gettime(str tp->tv_sec += wall_to_mono.tv_sec; tp->tv_nsec += wall_to_mono.tv_nsec;Quoted 11 lines
kernel/posix-timers.c int do_posix_clock_monotonic_gettime(str · line 1217
Quoted 8 lines
kernel/posix-timers.c renamed from kernel/posix-timers.c.orig +4
-1-if ((tp->tv_nsec -NSEC_PER_SEC ) >0 ) { +if (tp->tv_nsec <0 ) { + tp->tv_nsec +=NSEC_PER_SEC ; + tp->tv_sec--; + }else if ((tp->tv_nsec -NSEC_PER_SEC ) >0 ) { tp->tv_nsec -=NSEC_PER_SEC ; tp->tv_sec++; }Doesn't this imply that
do_posix_clock_monotonic_gettime_parts()is returning a negativetv_nsec?nope, not necessarily, because after that ...
tp->tv_sec += wall_to_mono.tv_sec; tp->tv_nsec += wall_to_mono.tv_nsec;might add a negative value, which explains the
underflow ...Quoted 6 lines
and if you look closer:
xtime.tv_sec = get_cmos_time(); wall_to_monotonic.tv_sec = -xtime.tv_sec; xtime.tv_nsec = (INITIAL_JIFFIES % HZ) * (NSEC_PER_SEC / HZ); wall_to_monotonic.tv_nsec = -xtime.tv_nsec;
Quoted 5 lines
Yep, that IS the problem. It should be normalized here, I.e.
set_normalized_timespec(wall_to_monotonic, wall_to_monotonic.tv_sec - xtime.tv_sec, wall_to_monotonic.tv_nsec - xtime.tv_nsec);with the obvious delets :)
agreed, especially as almost all archs do it
properly (jsut i386 and m32r miss that)
Quoted 1 line
Still, this should be corrected by the first settimeofday, which most systems do on the way up, or is that just those who use NTP?
correct, but not all use settimeofday() ...
here is a better patch:
Fix the non-normalized wall_to_monotonic for i386 and m32r (The other archs seem to get it right)
arch/i386/kernel/time.c +4 -4
@@ -381,9 +381,9 @@ extern void (*late_time_init)(void);void __init hpet_time_init (void ) { xtime.tv_sec =get_cmos_time (); - wall_to_monotonic.tv_sec = -xtime.tv_sec; xtime.tv_nsec = (INITIAL_JIFFIES %HZ ) * (NSEC_PER_SEC /HZ ); - wall_to_monotonic.tv_nsec = -xtime.tv_nsec; +set_normalized_timespec (&wall_to_monotonic, + -xtime.tv_sec, -xtime.tv_nsec);if (hpet_enable () >=0 ) {printk ("Using HPET for base-timer\n" );
@@ -409,9 +409,9 @@ void __init time_init(void) }#endif xtime.tv_sec =get_cmos_time (); - wall_to_monotonic.tv_sec = -xtime.tv_sec; xtime.tv_nsec = (INITIAL_JIFFIES %HZ ) * (NSEC_PER_SEC /HZ ); - wall_to_monotonic.tv_nsec = -xtime.tv_nsec; +set_normalized_timespec (&wall_to_monotonic, + -xtime.tv_sec, -xtime.tv_nsec); cur_timer =select_timer ();printk (KERN_INFO "Using %s for high-res timesource\n" ,cur_timer->name);
arch/m32r/kernel/time.c +2 -2
@@ -275,8 +275,8 @@ void __init time_init(void) xtime.tv_sec =mktime (year, mon, day, hour, min, sec); xtime.tv_nsec = (INITIAL_JIFFIES %HZ ) * (NSEC_PER_SEC /HZ ); - wall_to_monotonic.tv_sec = -xtime.tv_sec; - wall_to_monotonic.tv_nsec = -xtime.tv_nsec; +set_normalized_timespec (&wall_to_monotonic, + -xtime.tv_sec, -xtime.tv_nsec);#if defined(CONFIG_CHIP_M32102 ) || defined(CONFIG_CHIP_XNUX2 ) \ || defined(CONFIG_CHIP_VDEC2 ) || defined(CONFIG_CHIP_M32700 ) \
best,
Herbert
Signature · 2 lines
George Anzinger [email protected] High-res-timers: http://sourceforge.net/projects/high-res-timers/