Skip to contentSkip to conversation

fork historic module

RFC Manfred Spraul 2 participants 2 messages Dec 17, 2004

lore
Share & tools
lore
#0 lore raw
Quoted 9 lines · Andi

Review

Quoted 5 lines
(quoted diff) +5 -0
+/* IOCTL numbers */
+/* If you add a new IOCTL number don't forget to update FH_MAXNR */
+#define FH_MAGIC	0x35
+#define FH_REGISTER	_IO(FH_MAGIC,0)
+#define FH_UNREGISTER	_IO(FH_MAGIC,1)

Is this really unique? 32bit emulation currently needs unique ioctl numbers.

Are there plans to fix that? Perhaps move the emulation callback into struct file?

--
Manfred

#1 lore raw
Quoted 12 lines · Manfred Spraul
Quoted 10 lines · Andi

Review

Quoted 5 lines
(quoted diff) +5 -0
+/* IOCTL numbers */
+/* If you add a new IOCTL number don't forget to update FH_MAXNR */
+#define FH_MAGIC	0x35
+#define FH_REGISTER	_IO(FH_MAGIC,0)
+#define FH_UNREGISTER	_IO(FH_MAGIC,1)

Is this really unique? 32bit emulation currently needs unique ioctl numbers.

Quoted 2 lines

Are there plans to fix that? Perhaps move the emulation callback into struct file?

Yes. See the thread on l-k i started two days ago.

Actually the main reason is that the current conversion setup has a unfixable module unload race.

-Andi