fix double sync_page_range() in generic_file_aio_write()
Subsystems (2)
PATCH 1/1 fix double sync_page_range() in generic_file_aio_write()
Hello.
generic_file_aio_write():
generic_file_aio_write_nolock(): if (SYNC) sync_page_range_nolock(); if (SYNC) sync_page_range();
I think that generic_file_aio_write() should use__generic_file_aio_write_nolock() instead.
Oleg.
Signed-off-by Oleg Nesterov <[email protected]>
mm/filemap.c renamed from mm/filemap.c~ +1 -1
@@ -2149,7 +2149,7 @@ ssize_t generic_file_aio_write(struct kiBUG_ON (iocb->ki_pos != pos);down (&inode->i_sem); - ret =generic_file_aio_write_nolock (iocb, &local_iov,1 , + ret =__generic_file_aio_write_nolock (iocb, &local_iov,1 , &iocb->ki_pos);up (&inode->i_sem);
Sorry I missed this one - Thanks for spotting it !
Regards
Suparna
Quoted 24 lines · Oleg Nesterov
Hello.
generic_file_aio_write():generic_file_aio_write_nolock(): if (SYNC) sync_page_range_nolock(); if (SYNC) sync_page_range();I think that
generic_file_aio_write()should use__generic_file_aio_write_nolock()instead.Oleg.
Signed-off-by Oleg Nesterov <[email protected]>mm/filemap.c renamed from mm/filemap.c~ +1
-1@@ -2149,7 +2149,7 @@ ssize_t generic_file_aio_write(struct kiBUG_ON (iocb->ki_pos != pos);down (&inode->i_sem); - ret =generic_file_aio_write_nolock (iocb, &local_iov,1 , + ret =__generic_file_aio_write_nolock (iocb, &local_iov,1 , &iocb->ki_pos);up (&inode->i_sem);
Signature · 3 lines
Suparna Bhattacharya ([email protected]) Linux Technology Center IBM Software Lab, India