Skip to contentSkip to conversation

2.6.10-ac3 compile failure

DISCUSSION Eyal Lebedinsky 4 participants 4 messages Jan 5, 2005 – Jan 6, 2005

lore
Share & tools
lore
#0 lore raw

CC [M] drivers/char/agp/intel-agp.o
drivers/char/agp/intel-agp.c: In function `intel_i915_configure':
drivers/char/agp/intel-agp.c:640: error: too many arguments to function `writel' make[3]: *** [drivers/char/agp/intel-agp.o] Error 1

FYI

Signature · 2 lines
Eyal Lebedinsky ([email protected]) <http://samba.org/eyal/>
	If attaching .zip rename to .dat
#1 lore raw
Quoted 4 lines · Eyal Lebedinsky

CC [M] drivers/char/agp/intel-agp.o
drivers/char/agp/intel-agp.c: In function `intel_i915_configure':
drivers/char/agp/intel-agp.c:640: error: too many arguments to function `writel' make[3]: *** [drivers/char/agp/intel-agp.o] Error 1

Applying this patch worked for me

Cheers

Adam

char/agp/intel-agp.c renamed from char/agp/intel-agp.c-orig +1 -1
@@ -637,7 +637,7 @@
 	gmch_ctrl |= I830_GMCH_ENABLED;
 	pci_write_config_word(agp_bridge->dev,I830_GMCH_CTRL,gmch_ctrl);
 
-	writel(agp_bridge->gatt_bus_addr | I810_PGETBL_ENABLED, intel_i830_private.registers,I810_PGETBL_CTL);
+	writel(agp_bridge->gatt_bus_addr | I810_PGETBL_ENABLED, intel_i830_private.registers+I810_PGETBL_CTL);
 	readl(intel_i830_private.registers+I810_PGETBL_CTL);	/* PCI Posting. */
 	
 	if (agp_bridge->driver->needs_scratch_page) {
#2 lore raw
In reply to Eyal Lebedinsky
Quoted 4 lines · Eyal Lebedinsky

CC [M] drivers/char/agp/intel-agp.o
drivers/char/agp/intel-agp.c: In function `intel_i915_configure':
drivers/char/agp/intel-agp.c:640: error: too many arguments to function `writel' make[3]: *** [drivers/char/agp/intel-agp.o] Error 1

Already fixed in -ac4. Its one reason -ac3 wasnt publically announced. I figured I'd get enough mail as it was with that error

#3 lore raw
Quoted 2 lines · Alan Cox

Already fixed in -ac4. Its one reason -ac3 wasnt publically announced. I figured I'd get enough mail as it was with that error

Was -ac4 ever announced? Couldn't find it in the archives and it'd be nice to have a changelog :)

-- Cal