radeonfb: fix init/exit section usage

PATCH In review Randy.Dunlap 2 participants 3 messages Jan 7, 2005 Framebuffer layer

Share & tools

Randy.Dunlap

author

2005-01-07 20:12 UTC #0 lore raw

PATCH 1/1 radeonfb: fix init/exit section usage

Fix 3 instances of calling exit section function from text or init:
Error: ./drivers/video/aty/radeon_base.o .text refers to 000029e5 R_386_PC32 .exit.text
Error: ./drivers/video/aty/radeon_base.o .text refers to 00002a60 R_386_PC32 .exit.text
Error: ./drivers/video/aty/radeon_base.o .init.text refers to 00000192 R_386_PC32 .exit.text

Signed-off-by Randy Dunlap <[email protected]>

diffstat:=

 drivers/video/aty/radeon_base.c |    2 +-
 1 files changed, 1 insertion(+), 1 deletion(-)

---

drivers/video/aty/radeon_base.c renamed from drivers/video/aty/radeon_base.c~radeonfb_initexit +1 -1

diff -Naurp ./drivers/video/aty/radeon_base.c~radeonfb_initexit ./drivers/video/aty/radeon_base.c
@@ -261,7 +261,7 @@ static struct backlight_controller radeo
 
 #endif /* CONFIG_PPC_OF */
 
-static void __devexit radeon_unmap_ROM(struct radeonfb_info *rinfo, struct pci_dev *dev)
+static void radeon_unmap_ROM(struct radeonfb_info *rinfo, struct pci_dev *dev)
 {
 	if (!rinfo->bios_seg)
 		return;

Kronos

2005-01-07 21:54 UTC #1 lore raw

Il Fri, Jan 07, 2005 at 11:28:07AM -0800, Randy.Dunlap ha scritto:

Quoted 22 lines

Fix 3 instances of calling exit section function from text or init:
Error: ./drivers/video/aty/radeon_base.o .text refers to 000029e5
R_386_PC32 .exit.text
Error: ./drivers/video/aty/radeon_base.o .text refers to 00002a60
R_386_PC32 .exit.text
Error: ./drivers/video/aty/radeon_base.o .init.text refers to 00000192
R_386_PC32 .exit.text
Signed-off-by Randy Dunlap <[email protected]>
diffstat:=
 drivers/video/aty/radeon_base.c |    2 +-
 1 files changed, 1 insertion(+), 1 deletion(-)
---
diff -Naurp ./drivers/video/aty/radeon_base.c~radeonfb_initexit ./drivers/video/aty/radeon_base.c

drivers/video/aty/radeon_base.c static struct backlight_controller radeo · line 267

Quoted 8 lines

drivers/video/aty/radeon_base.c renamed from drivers/video/aty/radeon_base.c~radeonfb_initexit +1 -1

@@ -261,7 +261,7 @@ static struct backlight_controller radeo
 
 #endif /* CONFIG_PPC_OF */
 
-static void __devexit radeon_unmap_ROM(struct radeonfb_info *rinfo, struct pci_dev *dev)
+static void radeon_unmap_ROM(struct radeonfb_info *rinfo, struct pci_dev *dev)
 {
 	if (!rinfo->bios_seg)
 		return;

I see that radeon_unmap_ROM is called in radeonfb_pci_register (error path). Is this the problem?

Oh btw, the maintainer of the new radeonfb is Ben Herrenschmidt, not Ani Joshi.

Luca

Signature · 8 lines

Home: http://kronoz.cjb.net
Carpe diem, quam minimum credula postero. (Q. Horatius Flaccus)


-------------------------------------------------------
The SF.Net email is sponsored by: Beat the post-holiday blues
Get a FREE limited edition SourceForge.net t-shirt from ThinkGeek.
It's fun and FREE -- well, almost....http://www.thinkgeek.com/sfshirt

Randy.Dunlap

author

2005-01-07 22:10 UTC #2 lore raw

Quoted 23 lines · Kronos

Il Fri, Jan 07, 2005 at 11:28:07AM -0800, Randy.Dunlap ha scritto:
Quoted 21 lines
Fix 3 instances of calling exit section function from text or init:
Error: ./drivers/video/aty/radeon_base.o .text refers to 000029e5 R_386_PC32 .exit.text
Error: ./drivers/video/aty/radeon_base.o .text refers to 00002a60 R_386_PC32 .exit.text
Error: ./drivers/video/aty/radeon_base.o .init.text refers to 00000192 R_386_PC32 .exit.text
Signed-off-by Randy Dunlap <[email protected]>
diffstat:=
drivers/video/aty/radeon_base.c | 2 +-
1 files changed, 1 insertion(+), 1 deletion(-)
---
diff -Naurp ./drivers/video/aty/radeon_base.c~radeonfb_initexit ./drivers/video/aty/radeon_base.c
drivers/video/aty/radeon_base.c renamed from drivers/video/aty/radeon_base.c~radeonfb_initexit +0 -0
@@ -261,7 +261,7 @@ static struct backlight_controller radeo
 
 #endif /* CONFIG_PPC_OF */
 

Quoted 9 lines

drivers/video/aty/radeon_base.c static struct backlight_controller radeo · line 267
Quoted 5 lines
drivers/video/aty/radeon_base.c renamed from drivers/video/aty/radeon_base.c~radeonfb_initexit +1 -1
-static void __devexit radeon_unmap_ROM(struct radeonfb_info *rinfo, struct pci_dev *dev)
+static void radeon_unmap_ROM(struct radeonfb_info *rinfo, struct pci_dev *dev)
 {
 	if (!rinfo->bios_seg)
 		return;
I see that radeon_unmap_ROM is called in radeonfb_pci_register (error path). Is this the problem?

Yes. It was called from radeon_map_ROM() [which is __init] and from radeonfb_pci_register().

Quoted 2 lines

Oh btw, the maintainer of the new radeonfb is Ben Herrenschmidt, not Ani Joshi.

OK, thanks for the info. Be nice if someone would update MAINTAINERS with that info...

Quoted 1 line

Luca

Signature · 7 lines

~Randy


-------------------------------------------------------
The SF.Net email is sponsored by: Beat the post-holiday blues
Get a FREE limited edition SourceForge.net t-shirt from ThinkGeek.
It's fun and FREE -- well, almost....http://www.thinkgeek.com/sfshirt