Skip to contentSkip to conversation

: Fix stack leakage in ip6tables

PATCH In review Patrick McHardy 1 participant 1 message Jan 11, 2005 netfilter

lore
Share & tools
lore
#0 lore raw

PATCH 1/6 : Fix stack leakage in ip6tables

# This is a BitKeeper generated diff -Nru style patch. #
# ChangeSet
# 2005/01/11 03:41:31+01:00 [email protected]
# [NETFILTER]: Fix stack leakage in ip6tables
#
# ip6tables version of Rusty's iptables fix.
#
# Signed-off-by: Patrick McHardy <[email protected]>
#

# net/ipv6/netfilter/ip6_tables.c
#   2005/01/11 03:41:24+01:00 [email protected] +1 -1
#   [NETFILTER]: Fix stack leakage in ip6tables
#   
#   ip6tables version of Rusty's iptables fix.
#   
#   Signed-off-by: Patrick McHardy <[email protected]>
# 
diff -Nru a/net/ipv6/netfilter/ip6_tables.c b/net/ipv6/netfilter/ip6_tables.c
--- a/net/ipv6/netfilter/ip6_tables.c	2005-01-11 13:39:37 +01:00
+++ b/net/ipv6/netfilter/ip6_tables.c	2005-01-11 13:39:37 +01:00
@@ -1373,7 +1373,7 @@
 			       sizeof(info.underflow));
 			info.num_entries = t->private->number;
 			info.size = t->private->size;
-			strcpy(info.name, name);
+			memcpy(info.name, name, sizeof(info.name));

if (copy_to_user(user, &info, *len) != 0)
ret = -EFAULT;