Skip to contentSkip to conversation

: speedstep-lib: fix frequency multiplier for Pentium4 models 0&1

PATCH In review Matthias-Christian Ott 2 participants 3 messages Jan 22, 2005

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 : speedstep-lib: fix frequency multiplier for Pentium4 models 0&1

The Pentium4 models 0&1 have a longer MSR_EBC_FREQUENCY_ID register as the models 2&3, so the bit shift must be bigger.

arch/i386/kernel/cpu/cpufreq/speedstep-lib.c 2005-01-22 10:58:34.000000000 +0100 renamed from arch/i386/kernel/cpu/cpufreq/speedstep-lib.c.orig 2005-01-21 13:55:37.000000000 +0100 +0 -0
@@ -160,7 +160,14 @@
        printk(KERN_DEBUG "speedstep-lib: couldn't detect FSB speed. 

Please send an e-mail to <[email protected]>\n");

    /* Multiplier. */
-    mult = msr_lo >> 24;
+    if (c->x86_model < 2)
+        {
+        mult = msr_lo >> 27;
+        }
+    else
+        {
+        mult = msr_lo >> 24;
+        }

dprintk("P4 - FSB %u kHz; Multiplier %u; Speed %u kHz\n", fsb,
mult, (fsb * mult));

#1 lore raw
Quoted 2 lines · Matthias-Christian Ott

The Pentium4 models 0&1 have a longer MSR_EBC_FREQUENCY_ID register as the models 2&3, so the bit shift must be bigger.

I would feel safer if this checked that it was actually a p4 as well...

#2 lore raw
Quoted 7 lines · Arjan van de Ven
Quoted 3 lines · Matthias-Christian Ott

The Pentium4 models 0&1 have a longer MSR_EBC_FREQUENCY_ID register as the models 2&3, so the bit shift must be bigger.

Quoted 9 lines

I would feel safer if this checked that it was actually a p4 as well... -
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [email protected]
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/

Hi!
If mean my CPU, it's a pentium4 model 1 and the patch is checked with it.
All other tests which check if it's a pentium4 are performed by other instances of the cpufreq driver.

Matthias-Christian Ott