Skip to contentSkip to conversation

ray_cs: reduce stack usage (sockaddr)

PATCH Applied Randy.Dunlap 2 participants 2 messages Jan 28, 2005 – Feb 2, 2005

Subsystems (3)
Networking Network drivers Networking drivers (wireless)
lore
Share & tools
lore

Randy.Dunlap

author
#0 lore raw

PATCH 2/2 ray_cs: reduce stack usage (sockaddr)

ray_cs: reduce local stack size in ray_dev_ioctl() from 468
to 340 bytes by having only 1 of these 128-byte arrays (which is now at function scope):

	struct sockaddr       address[IW_MAX_SPY];
		16			 * 8	= 128
Signed-off-by Randy Dunlap <[email protected]>

diffstat:=

 drivers/net/wireless/ray_cs.c |    5 +++--
 1 files changed, 3 insertions(+), 2 deletions(-)
drivers/net/wireless/ray_cs.c renamed from drivers/net/wireless/ray_cs.c~raycs_sockaddr +3 -2
diff -Naurp ./drivers/net/wireless/ray_cs.c~raycs_sockaddr ./drivers/net/wireless/ray_cs.c
@@ -1215,6 +1215,9 @@ static int ray_dev_ioctl(struct net_devi
 #if WIRELESS_EXT > 7
     struct iwreq *wrq = (struct iwreq *) ifr;
 #endif	/* WIRELESS_EXT > 7 */
+#ifdef WIRELESS_SPY
+    struct sockaddr	address[IW_MAX_SPY];
+#endif	/* WIRELESS_SPY */
 
     if (!(link->state & DEV_PRESENT)) {
         DEBUG(2,"ray_dev_ioctl - device not present\n");

@@ -1517,7 +1520,6 @@ static int ray_dev_ioctl(struct net_devi
       /* If there is some addresses to copy */
       if(local->spy_number > 0)
 	{
-	  struct sockaddr	address[IW_MAX_SPY];
 	  int			i;
 
 	  /* Copy addresses to the driver */

@@ -1557,7 +1559,6 @@ static int ray_dev_ioctl(struct net_devi
       /* If the user want to have the addresses back... */
       if((local->spy_number > 0) && (wrq->u.data.pointer != (caddr_t) 0))
 	{
-	  struct sockaddr	address[IW_MAX_SPY];
 	  int			i;
 
 	  /* Copy addresses from the lp structure */