Skip to contentSkip to conversation

drivers/block/* - compile warning cleanup

PATCH In review Stephen Biggs 1 participant 1 message Feb 10, 2005

Subsystems (2)
lore
Share & tools
lore
#0 lore raw

PATCH 2/26 drivers/block/* - compile warning cleanup

Description: compile warning cleanups - handle error return from scsi_add_host, cast argument to sprintf to silence warning

drivers/block/cciss_scsi.c +2 -1
diff -Nurdp -X dontdiff-osdl linux-2.6.11-rc3-mm-original/drivers/block/cciss_scsi.c linux-2.6.11-rc3-mm/drivers/block/cciss_scsi.c
@@ -706,7 +706,8 @@ cciss_scsi_detect(int ctlr)
 	sh->hostdata[0] = (unsigned long) hba[ctlr];
 	sh->irq = hba[ctlr]->intr;
 	sh->unique_id = sh->irq;
-	scsi_add_host(sh, &hba[ctlr]->pdev->dev); /* XXX handle failure */
+	if(scsi_add_host(sh, &hba[ctlr]->pdev->dev))
+		return 0;
 	scsi_scan_host(sh);
 
 	return 1;

diff -Nurdp -X dontdiff-osdl linux-2.6.11-rc3-mm-original/drivers/block/sx8.c linux-2.6.11-rc3-mm/drivers/block/sx8.c
--- linux-2.6.11-rc3-mm-original/drivers/block/sx8.c 2005-02-03
03:57:16.000000000 +0200
+++ linux-2.6.11-rc3-mm/drivers/block/sx8.c 2005-02-07 15:35:49.000000000 +0200
@@ -1503,7 +1503,7 @@ static int carm_init_disks(struct carm_h
}

port->disk = disk;
- sprintf(disk->disk_name, DRV_NAME "/%u", (host->id * CARM_MAX_PORTS) + i);
+ sprintf(disk->disk_name, DRV_NAME "/%u", (unsigned int)((host->id * CARM_MAX_PORTS) + i));
sprintf(disk->devfs_name, DRV_NAME "/%u_%u", host->id, i); disk->major = host->major;
disk->first_minor = i * CARM_MINORS_PER_MAJOR;

_______________________________________________
Kernel-janitors mailing list
[email protected]
http://lists.osdl.org/mailman/listinfo/kernel-janitors