Skip to contentSkip to conversation

[13/ 21] drivers/scsi/sym53c8xx_2/* - compile

PATCH In review Stephen Biggs 2 participants 3 messages Feb 14, 2005 – Feb 15, 2005

Subsystems (3)
SCSI Kernel janitors LSI Logic/symbios/ncr 53C8XX and 53C1010 PCI-SCSI drivers
lore
Share & tools
lore

Stephen Biggs

author
#0 lore raw

PATCH 1/1 [13/ 21] drivers/scsi/sym53c8xx_2/* - compile

Description: compile warning cleanup - stop compilation of unused structure member unless proper symbol is defined

Signed-off-by Stephen Biggs <[email protected]>
drivers/scsi/sym53c8xx_2/sym_glue.c +2 -0
diff -Nurdp -X dontdiff-osdl linux-2.6.11-rc3-mm2-original/drivers/scsi/sym53c8xx_2/sym_glue.c linux-2.6.11-rc3-mm2/drivers/scsi/sym53c8xx_2/sym_glue.c
@@ -1817,7 +1817,9 @@ static int __devinit sym_check_supported
 	struct pci_dev *pdev = device->pdev;
 	u_char revision;
 	unsigned long io_port = device->s.io_port;
+#ifndef SYM_CONF_IOMAPPED
 	unsigned long base = device->s.base;
+#endif
 	int i;
 
 	/*

_______________________________________________
Kernel-janitors mailing list
[email protected]
http://lists.osdl.org/mailman/listinfo/kernel-janitors

#1 lore raw

Re: [KJ] [PATCH][RESUBMIT][13/ 21] drivers/scsi/sym53c8xx_2/* -

Quoted 2 lines · Stephen Biggs

Description: compile warning cleanup - stop compilation of unused structure member unless proper symbol is defined

I'll fix this one in a different way. Thanks.

Signature · 6 lines
"Next the statesmen will invent cheap lies, putting the blame upon 
the nation that is attacked, and every man will be glad of those
conscience-soothing falsities, and will diligently study them, and refuse
to examine any refutations of them; and thus he will by and by convince 
himself that the war is just, and will thank God for the better sleep 
he enjoys after this process of grotesque self-deception." -- Mark Twain

_______________________________________________
Kernel-janitors mailing list
[email protected]
http://lists.osdl.org/mailman/listinfo/kernel-janitors

author
#2 lore raw

Re: [KJ] [PATCH][RESUBMIT][13/ 21] drivers/scsi/sym53c8xx_2/* -

In reply to Stephen Biggs
Quoted 5 lines · Matthew Wilcox
Quoted 2 lines · Stephen Biggs

Description: compile warning cleanup - stop compilation of unused structure member unless proper symbol is defined

I'll fix this one in a different way. Thanks.

Not a problem. My fix was more quick-and-dirty than anything else: that is, it works but might not be the optimal or best way to fix it.

Quoted 9 lines
Signature · 7 lines
-- 
"Next the statesmen will invent cheap lies, putting the blame upon 
the nation that is attacked, and every man will be glad of those
conscience-soothing falsities, and will diligently study them, and refuse
to examine any refutations of them; and thus he will by and by convince 
himself that the war is just, and will thank God for the better sleep 
he enjoys after this process of grotesque self-deception." -- Mark Twain

_______________________________________________
Kernel-janitors mailing list
[email protected]
http://lists.osdl.org/mailman/listinfo/kernel-janitors