scsi_device::single_lun name change
While looking at struct scsi_target in a recent lk 2.6 kernel I was confused by this sentence:
"scsi_target: representation of a scsi target, for now,
this is only used for single_lun devices." This is just above
the definition of the scsi_target structure in scsi_device.h
Elsewhere in that file scsi_device::single_lun is defined with this comment:
"Indicates we should only allow I/O to one of the luns for
the device at a time."
That implies that the target must have multiple lus when single_lun is set :-)
Is it too late to rename that field to something like:
serialize_lu_io or single_lu_io ?
Doug Gilbert
Quoted 3 lines · Douglas Gilbert
"
scsi_target: representation of a scsi target, for now,
this is only used forsingle_lundevices." This is just above
the definition of thescsi_targetstructure inscsi_device.h
Yes, I suppose that's historical junk now.
Quoted 9 lines
Elsewhere in that file
scsi_device::single_lunis defined with this comment:
"Indicates we should only allow I/O to one of the luns for
the device at a time."
That implies that the target must have multiple lus whensingle_lunis set :-)Is it too late to rename that field to something like:
serialize_lu_ioorsingle_lu_io?
Well, it corresponds to BLIST_SINGLELUN flag, so the naming scheme is currently internally consistent.
James