Skip to contentSkip to conversation

Cleanup in AT91RM9200.h ?

U-Boot-Users Steven Scholz 2 participants 4 messages Mar 2, 2005 – Sep 25, 2005

lore
Share & tools
lore
#0 lore raw

Dear Wolfgang,

the formating/indenting in include/asm-arm/arch-at91rm9200/AT91RM9200.h looks terrible.

Would use except a patch that only does whitspace fixing in this file?

--
Steven

#1 lore raw
Quoted 3 lines · In message <[email protected]> you wrote:

the formating/indenting in include/asm-arm/arch-at91rm9200/AT91RM9200.h looks terrible.

It does, but I think I can detect some kind of logic in this formatting.

Quoted 1 line

Would use except a patch that only does whitspace fixing in this file?

If it really improves the readbility while still keeping all structural information, sure.

Best regards,

Wolfgang Denk

Signature · 4 lines
Software Engineering:  Embedded and Realtime Systems,  Embedded Linux
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
There are bugs and then there are bugs.  And then there are bugs.
                                                    - Karl Lehenbauer
#2 lore raw

Hi,

Quoted 5 lines
Quoted 2 lines

the formating/indenting in include/asm-arm/arch-at91rm9200/AT91RM9200.h looks terrible.

It does, but I think I can detect some kind of logic in this formatting.

;-)

Quoted 4 lines
Quoted 1 line

Would use except a patch that only does whitspace fixing in this file?

If it really improves the readbility while still keeping all structural information, sure.

Ok. Here's the first attempt. Tested with 'MAKEALL ARM9'. I send the complete new AT91RM9200.h. Diff makes no sense.

* Patch by Steven Scholz, 02 March 2005:
Fix formating in include/asm-arm/arch-at91rm9200/AT91RM9200.h

--
Steven

-------------- next part --------------
A non-text attachment was scrubbed...
Name: AT91RM9200.h.bz2
Type: application/octet-stream
Size: 7333 bytes
Desc: not available
Url : http://lists.denx.de/pipermail/u-boot/attachments/20050302/e4edc24a/attachment.obj

#3 lore raw
Quoted 3 lines · In message <[email protected]> you wrote:

* Patch by Steven Scholz, 02 March 2005:

   Fix formating in include/asm-arm/arch-at91rm9200/AT91RM9200.h

Added, thanks.

Best regards,

Wolfgang Denk

Signature · 5 lines
Software Engineering:  Embedded and Realtime Systems,  Embedded Linux
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
Roses are red
Violets are blue
Some poems rhyme