Skip to contentSkip to conversation

: Fix ICMP tempsel

PATCH In review Patrick McHardy 2 participants 2 messages Mar 5, 2005

Subsystems (2)
lore
Share & tools
lore
#0 lore raw

PATCH 1/3 : Fix ICMP tempsel

Hi Dave,

there was a lot of discussion going on last time I posted these patches, these are the patches everyone agreed on. They are based on your 2.6.12 tree.

# This is a BitKeeper generated diff -Nru style patch. #
# ChangeSet
# 2005/03/05 01:57:26+01:00 [email protected]
# [XFRM]: Fix ICMP tempsel
#
# Signed-off-by: Patrick McHardy <[email protected]>
#

# net/ipv6/xfrm6_state.c
#   2005/03/05 01:57:18+01:00 [email protected] +2 -2
#   [XFRM]: Fix ICMP tempsel
#   
#   Signed-off-by: Patrick McHardy <[email protected]>
# 
# net/ipv4/xfrm4_state.c
#   2005/03/05 01:57:18+01:00 [email protected] +2 -2
#   [XFRM]: Fix ICMP tempsel
#   
#   Signed-off-by: Patrick McHardy <[email protected]>
# 
diff -Nru a/net/ipv4/xfrm4_state.c b/net/ipv4/xfrm4_state.c
--- a/net/ipv4/xfrm4_state.c	2005-03-05 13:03:27 +01:00
+++ b/net/ipv4/xfrm4_state.c	2005-03-05 13:03:27 +01:00
@@ -20,9 +20,9 @@
 {
 	x->sel.daddr.a4 = fl->fl4_dst;
 	x->sel.saddr.a4 = fl->fl4_src;
-	x->sel.dport = fl->fl_ip_dport;
+	x->sel.dport = xfrm_flowi_dport(fl);
 	x->sel.dport_mask = ~0;
-	x->sel.sport = fl->fl_ip_sport;
+	x->sel.sport = xfrm_flowi_sport(fl);
 	x->sel.sport_mask = ~0;
 	x->sel.prefixlen_d = 32;
 	x->sel.prefixlen_s = 32;
diff -Nru a/net/ipv6/xfrm6_state.c b/net/ipv6/xfrm6_state.c
--- a/net/ipv6/xfrm6_state.c	2005-03-05 13:03:27 +01:00
+++ b/net/ipv6/xfrm6_state.c	2005-03-05 13:03:27 +01:00
@@ -27,9 +27,9 @@
 	 * to current session. */
 	ipv6_addr_copy((struct in6_addr *)&x->sel.daddr, &fl->fl6_dst);
 	ipv6_addr_copy((struct in6_addr *)&x->sel.saddr, &fl->fl6_src);
-	x->sel.dport = fl->fl_ip_dport;
+	x->sel.dport = xfrm_flowi_dport(fl);
 	x->sel.dport_mask = ~0;
-	x->sel.sport = fl->fl_ip_sport;
+	x->sel.sport = xfrm_flowi_sport(fl);
 	x->sel.sport_mask = ~0;
 	x->sel.prefixlen_d = 128;
 	x->sel.prefixlen_s = 128;