move SA_xxx defines to linux/signal.h
PATCH 1/1 move SA_xxx defines to linux/signal.h
Hi Andrew.
The attached patch moves the IRQ-related SA_xxx flags (namely, SA_PROBE, SA_SAMPLE_RANDOM and SA_SHIRQ) from all the arch-specific headers to linux/signal.h.
This looks like a left-over after the irq-handling code was consolidated. The code was moved to kernel/irq/*, but the flags are still left per-arch.
Right now, adding a new IRQ flag to the arch-specific header, like this patch does:
http://cvs.sourceforge.net/viewcvs.py/*checkout*/alsa/alsa-driver/utils/patches/pcsp-kernel-2.6.10-03.diff?rev=1.1
no longer works, it breaks the compilation for all other arches, unless you add that flag to all the other arch-specific headers too. So I think such a clean-up makes sense.
Can this please be applied? Unfortunately I have tested it on x86 only.
Signed-off-by Stas Sergeev <[email protected]>
include/asm-alpha/signal.h +0 -14
@@ -109,20 +109,6 @@#define MINSIGSTKSZ 4096#define SIGSTKSZ 16384 - -#ifdef __KERNEL__ -/* -* These values of sa_flags are used only by the kernel as part of the -* irq handling routines. -* -* SA_INTERRUPT is also used by the irq handling routines. -* SA_SHIRQ is for shared interrupt support on PCI and EISA. -*/ -#define SA_PROBE SA_ONESHOT -#define SA_SAMPLE_RANDOM SA_RESTART -#define SA_SHIRQ 0x40000000 -#endif -#define SIG_BLOCK 1/* for blocking signals */ #define SIG_UNBLOCK 2/* for unblocking signals */ #define SIG_SETMASK 3/* for setting the signal mask */
include/asm-arm/signal.h +0 -11
@@ -114,18 +114,7 @@#define SIGSTKSZ 8192#ifdef __KERNEL__ - -/* -* These values of sa_flags are used only by the kernel as part of the -* irq handling routines. -* -* SA_INTERRUPT is also used by the irq handling routines. -* SA_SHIRQ is for shared interrupt support on PCI and EISA. -*/ -#define SA_PROBE 0x80000000 -#define SA_SAMPLE_RANDOM 0x10000000#define SA_IRQNOMASK 0x08000000 -#define SA_SHIRQ 0x04000000#endif #define SIG_BLOCK 0/* for blocking signals */
include/asm-arm26/signal.h +0 -11
@@ -114,18 +114,7 @@#define SIGSTKSZ 8192#ifdef __KERNEL__ - -/* -* These values of sa_flags are used only by the kernel as part of the -* irq handling routines. -* -* SA_INTERRUPT is also used by the irq handling routines. -* SA_SHIRQ is for shared interrupt support on PCI and EISA. -*/ -#define SA_PROBE 0x80000000 -#define SA_SAMPLE_RANDOM 0x10000000#define SA_IRQNOMASK 0x08000000 -#define SA_SHIRQ 0x04000000#endif #define SIG_BLOCK 0/* for blocking signals */
include/asm-cris/signal.h +0 -14
@@ -108,20 +108,6 @@#define MINSIGSTKSZ 2048#define SIGSTKSZ 8192 -#ifdef __KERNEL__ - -/* -* These values of sa_flags are used only by the kernel as part of the -* irq handling routines. -* -* SA_INTERRUPT is also used by the irq handling routines. -* SA_SHIRQ is for shared interrupt support -*/ -#define SA_PROBE SA_ONESHOT -#define SA_SAMPLE_RANDOM SA_RESTART -#define SA_SHIRQ 0x04000000 -#endif -#define SIG_BLOCK 0/* for blocking signals */ #define SIG_UNBLOCK 1/* for unblocking signals */ #define SIG_SETMASK 2/* for setting the signal mask */
include/asm-frv/signal.h +0 -14
@@ -107,20 +107,6 @@#define MINSIGSTKSZ 2048#define SIGSTKSZ 8192 -#ifdef __KERNEL__ - -/* -* These values of sa_flags are used only by the kernel as part of the -* irq handling routines. -* -* SA_INTERRUPT is also used by the irq handling routines. -* SA_SHIRQ is for shared interrupt support on PCI and EISA. -*/ -#define SA_PROBE SA_ONESHOT -#define SA_SAMPLE_RANDOM SA_RESTART -#define SA_SHIRQ 0x04000000 -#endif -#define SIG_BLOCK 0/* for blocking signals */ #define SIG_UNBLOCK 1/* for unblocking signals */ #define SIG_SETMASK 2/* for setting the signal mask */
include/asm-h8300/signal.h +0 -13
@@ -107,19 +107,6 @@#define MINSIGSTKSZ 2048#define SIGSTKSZ 8192 -#ifdef __KERNEL__ -/* -* These values of sa_flags are used only by the kernel as part of the -* irq handling routines. -* -* SA_INTERRUPT is also used by the irq handling routines. -* SA_SHIRQ is for shared interrupt support on PCI and EISA. -*/ -#define SA_PROBE SA_ONESHOT -#define SA_SAMPLE_RANDOM SA_RESTART -#define SA_SHIRQ 0x04000000 -#endif -#define SIG_BLOCK 0/* for blocking signals */ #define SIG_UNBLOCK 1/* for unblocking signals */ #define SIG_SETMASK 2/* for setting the signal mask */
include/asm-i386/signal.h +0 -14
@@ -110,20 +110,6 @@#define MINSIGSTKSZ 2048#define SIGSTKSZ 8192 -#ifdef __KERNEL__ - -/* -* These values of sa_flags are used only by the kernel as part of the -* irq handling routines. -* -* SA_INTERRUPT is also used by the irq handling routines. -* SA_SHIRQ is for shared interrupt support on PCI and EISA. -*/ -#define SA_PROBE SA_ONESHOT -#define SA_SAMPLE_RANDOM SA_RESTART -#define SA_SHIRQ 0x04000000 -#endif -#define SIG_BLOCK 0/* for blocking signals */ #define SIG_UNBLOCK 1/* for unblocking signals */ #define SIG_SETMASK 2/* for setting the signal mask */
include/asm-ia64/signal.h +0 -10
@@ -114,16 +114,6 @@#define _NSIG_BPW 64#define _NSIG_WORDS (_NSIG / _NSIG_BPW) -/* -* These values of sa_flags are used only by the kernel as part of the -* irq handling routines. -* -* SA_INTERRUPT is also used by the irq handling routines. -* SA_SHIRQ is for shared interrupt support on PCI and EISA. -*/ -#define SA_PROBE SA_ONESHOT -#define SA_SAMPLE_RANDOM SA_RESTART -#define SA_SHIRQ 0x04000000#define SA_PERCPU_IRQ 0x02000000#endif /* __KERNEL__ */
include/asm-m32r/signal.h +0 -14
@@ -114,20 +114,6 @@#define MINSIGSTKSZ 2048#define SIGSTKSZ 8192 -#ifdef __KERNEL__ - -/* -* These values of sa_flags are used only by the kernel as part of the -* irq handling routines. -* -* SA_INTERRUPT is also used by the irq handling routines. -* SA_SHIRQ is for shared interrupt support on PCI and EISA. -*/ -#define SA_PROBE SA_ONESHOT -#define SA_SAMPLE_RANDOM SA_RESTART -#define SA_SHIRQ 0x04000000 -#endif -#define SIG_BLOCK 0/* for blocking signals */ #define SIG_UNBLOCK 1/* for unblocking signals */ #define SIG_SETMASK 2/* for setting the signal mask */
include/asm-m68k/signal.h +0 -13
@@ -105,19 +105,6 @@#define MINSIGSTKSZ 2048#define SIGSTKSZ 8192 -#ifdef __KERNEL__ -/* -* These values of sa_flags are used only by the kernel as part of the -* irq handling routines. -* -* SA_INTERRUPT is also used by the irq handling routines. -* SA_SHIRQ is for shared interrupt support on PCI and EISA. -*/ -#define SA_PROBE SA_ONESHOT -#define SA_SAMPLE_RANDOM SA_RESTART -#define SA_SHIRQ 0x04000000 -#endif -#define SIG_BLOCK 0/* for blocking signals */ #define SIG_UNBLOCK 1/* for unblocking signals */ #define SIG_SETMASK 2/* for setting the signal mask */
include/asm-m68knommu/signal.h +0 -13
@@ -105,19 +105,6 @@#define MINSIGSTKSZ 2048#define SIGSTKSZ 8192 -#ifdef __KERNEL__ -/* -* These values of sa_flags are used only by the kernel as part of the -* irq handling routines. -* -* SA_INTERRUPT is also used by the irq handling routines. -* SA_SHIRQ is for shared interrupt support on PCI and EISA. -*/ -#define SA_PROBE SA_ONESHOT -#define SA_SAMPLE_RANDOM SA_RESTART -#define SA_SHIRQ 0x04000000 -#endif -#define SIG_BLOCK 0/* for blocking signals */ #define SIG_UNBLOCK 1/* for unblocking signals */ #define SIG_SETMASK 2/* for setting the signal mask */
include/asm-mips/signal.h +0 -15
@@ -98,21 +98,6 @@#define MINSIGSTKSZ 2048#define SIGSTKSZ 8192 -#ifdef __KERNEL__ - -/* -* These values of sa_flags are used only by the kernel as part of the -* irq handling routines. -* -* SA_INTERRUPT is also used by the irq handling routines. -* SA_SHIRQ flag is for shared interrupt support on PCI and EISA. -*/ -#define SA_PROBE SA_ONESHOT -#define SA_SAMPLE_RANDOM SA_RESTART -#define SA_SHIRQ 0x02000000 - -#endif /* __KERNEL__ */ -#define SIG_BLOCK 1/* for blocking signals */ #define SIG_UNBLOCK 2/* for unblocking signals */ #define SIG_SETMASK 3/* for setting the signal mask */
include/asm-parisc/signal.h +0 -11
@@ -89,17 +89,6 @@#define _NSIG_BPW BITS_PER_LONG#define _NSIG_WORDS (_NSIG / _NSIG_BPW) -/* -* These values of sa_flags are used only by the kernel as part of the -* irq handling routines. -* -* SA_INTERRUPT is also used by the irq handling routines. -* SA_SHIRQ is for shared interrupt support on PCI and EISA. -*/ -#define SA_PROBE SA_ONESHOT -#define SA_SAMPLE_RANDOM SA_RESTART -#define SA_SHIRQ 0x04000000 -#endif /* __KERNEL__ */ #define SIG_BLOCK 0/* for blocking signals */
include/asm-ppc/signal.h +0 -13
@@ -99,19 +99,6 @@#define MINSIGSTKSZ 2048#define SIGSTKSZ 8192 -#ifdef __KERNEL__ - -/* -* These values of sa_flags are used only by the kernel as part of the -* irq handling routines. -* -* SA_INTERRUPT is also used by the irq handling routines. -* SA_SHIRQ is for shared interrupt support on PCI and EISA. -*/ -#define SA_PROBE SA_ONESHOT -#define SA_SAMPLE_RANDOM SA_RESTART -#define SA_SHIRQ 0x04000000 -#endif /* __KERNEL__ */ #define SIG_BLOCK 0/* for blocking signals */ #define SIG_UNBLOCK 1/* for unblocking signals */
include/asm-ppc64/signal.h +0 -13
@@ -96,19 +96,6 @@#define MINSIGSTKSZ 2048#define SIGSTKSZ 8192 -#ifdef __KERNEL__ - -/* -* These values of sa_flags are used only by the kernel as part of the -* irq handling routines. -* -* SA_INTERRUPT is also used by the irq handling routines. -* SA_SHIRQ is for shared interrupt support on PCI and EISA. -*/ -#define SA_PROBE SA_ONESHOT -#define SA_SAMPLE_RANDOM SA_RESTART -#define SA_SHIRQ 0x04000000 -#endif #define SIG_BLOCK 0/* for blocking signals */ #define SIG_UNBLOCK 1/* for unblocking signals */
include/asm-s390/signal.h +0 -14
@@ -117,20 +117,6 @@#define MINSIGSTKSZ 2048#define SIGSTKSZ 8192 -#ifdef __KERNEL__ - -/* -* These values of sa_flags are used only by the kernel as part of the -* irq handling routines. -* -* SA_INTERRUPT is also used by the irq handling routines. -* SA_SHIRQ is for shared interrupt support on PCI and EISA. -*/ -#define SA_PROBE SA_ONESHOT -#define SA_SAMPLE_RANDOM SA_RESTART -#define SA_SHIRQ 0x04000000 -#endif -#define SIG_BLOCK 0/* for blocking signals */ #define SIG_UNBLOCK 1/* for unblocking signals */ #define SIG_SETMASK 2/* for setting the signal mask */
include/asm-sh/signal.h +0 -14
@@ -108,20 +108,6 @@#define MINSIGSTKSZ 2048#define SIGSTKSZ 8192 -#ifdef __KERNEL__ - -/* -* These values of sa_flags are used only by the kernel as part of the -* irq handling routines. -* -* SA_INTERRUPT is also used by the irq handling routines. -* SA_SHIRQ is for shared interrupt support on PCI and EISA. -*/ -#define SA_PROBE SA_ONESHOT -#define SA_SAMPLE_RANDOM SA_RESTART -#define SA_SHIRQ 0x04000000 -#endif -#define SIG_BLOCK 0/* for blocking signals */ #define SIG_UNBLOCK 1/* for unblocking signals */ #define SIG_SETMASK 2/* for setting the signal mask */
include/asm-sh64/signal.h +0 -14
@@ -107,20 +107,6 @@#define MINSIGSTKSZ 2048#define SIGSTKSZ THREAD_SIZE -#ifdef __KERNEL__ - -/* -* These values of sa_flags are used only by the kernel as part of the -* irq handling routines. -* -* SA_INTERRUPT is also used by the irq handling routines. -* SA_SHIRQ is for shared interrupt support on PCI and EISA. -*/ -#define SA_PROBE SA_ONESHOT -#define SA_SAMPLE_RANDOM SA_RESTART -#define SA_SHIRQ 0x04000000 -#endif -#define SIG_BLOCK 0/* for blocking signals */ #define SIG_UNBLOCK 1/* for unblocking signals */ #define SIG_SETMASK 2/* for setting the signal mask */
include/asm-sparc/signal.h +0 -8
@@ -143,7 +143,6 @@#define SA_ONESHOT _SV_RESET#define SA_INTERRUPT 0x10u#define SA_NOMASK 0x20u -#define SA_SHIRQ 0x40u#define SA_NOCLDWAIT 0x100u#define SA_SIGINFO 0x200u
@@ -162,11 +161,6 @@#ifdef __KERNEL__/* -* These values of sa_flags are used only by the kernel as part of the -* irq handling routines. -* -* SA_INTERRUPT is also used by the irq handling routines. -* * DJHR * SA_STATIC_ALLOC is used for the SPARC system to indicate that this * interrupt handler's irq structure should be statically allocated
@@ -177,8 +171,6 @@* statically allocated data.. which is NOT GOOD. * */ -#define SA_PROBE SA_ONESHOT -#define SA_SAMPLE_RANDOM SA_RESTART#define SA_STATIC_ALLOC 0x80#endif
include/asm-sparc64/signal.h +0 -8
@@ -145,7 +145,6 @@#define SA_ONESHOT _SV_RESET#define SA_INTERRUPT 0x10u#define SA_NOMASK 0x20u -#define SA_SHIRQ 0x40u#define SA_NOCLDWAIT 0x100u#define SA_SIGINFO 0x200u
@@ -165,11 +164,6 @@#ifdef __KERNEL__/* -* These values of sa_flags are used only by the kernel as part of the -* irq handling routines. -* -* SA_INTERRUPT is also used by the irq handling routines. -* * DJHR * SA_STATIC_ALLOC is used for the SPARC system to indicate that this * interrupt handler's irq structure should be statically allocated
@@ -180,8 +174,6 @@* statically allocated data.. which is NOT GOOD. * */ -#define SA_PROBE SA_ONESHOT -#define SA_SAMPLE_RANDOM SA_RESTART#define SA_STATIC_ALLOC 0x80#endif
include/asm-v850/signal.h +0 -15
@@ -110,21 +110,6 @@#define MINSIGSTKSZ 2048#define SIGSTKSZ 8192 - -#ifdef __KERNEL__ -/* -* These values of sa_flags are used only by the kernel as part of the -* irq handling routines. -* -* SA_INTERRUPT is also used by the irq handling routines. -* SA_SHIRQ is for shared interrupt support on PCI and EISA. -*/ -#define SA_PROBE SA_ONESHOT -#define SA_SAMPLE_RANDOM SA_RESTART -#define SA_SHIRQ 0x04000000 -#endif /* __KERNEL__ */ - -#define SIG_BLOCK 0/* for blocking signals */ #define SIG_UNBLOCK 1/* for unblocking signals */ #define SIG_SETMASK 2/* for setting the signal mask */
include/asm-x86_64/signal.h +0 -14
@@ -116,20 +116,6 @@#define MINSIGSTKSZ 2048#define SIGSTKSZ 8192 -#ifdef __KERNEL__ - -/* -* These values of sa_flags are used only by the kernel as part of the -* irq handling routines. -* -* SA_INTERRUPT is also used by the irq handling routines. -* SA_SHIRQ is for shared interrupt support on PCI and EISA. -*/ -#define SA_PROBE SA_ONESHOT -#define SA_SAMPLE_RANDOM SA_RESTART -#define SA_SHIRQ 0x04000000 -#endif -#define SIG_BLOCK 0/* for blocking signals */ #define SIG_UNBLOCK 1/* for unblocking signals */ #define SIG_SETMASK 2/* for setting the signal mask */
include/linux/signal.h +11 -0
@@ -9,6 +9,17 @@#ifdef __KERNEL__/* +* These values of sa_flags are used only by the kernel as part of the +* irq handling routines. +* +* SA_INTERRUPT is also used by the irq handling routines. +* SA_SHIRQ is for shared interrupt support on PCI and EISA. +*/ +#define SA_PROBE SA_ONESHOT +#define SA_SAMPLE_RANDOM SA_RESTART +#define SA_SHIRQ 0x04000000 + +/* * Real Time signals may be queued. */