Skip to contentSkip to conversation

2.6.26-<mumble> question regarding kernel/lockdep.c

DISCUSSION [email protected] 2 participants 2 messages Jul 23, 2008 – Jul 28, 2008

lore
Share & tools
lore
#0 lore raw

I was chasing after some weird behavior with lockdep, and I found that almost none of the printk() calls in kernel/lockdep.c have a KERN_FOO level specified.

It looks like it could use patching, but before I code something, I need to know if the patch should be doing:

a) Adding the missing KERN_FOO levels..
or
b) Adding a comment explaining the subtle reason they're not there...

#1 lore raw
Quoted 10 lines · * [email protected] <[email protected]> wrote:

I was chasing after some weird behavior with lockdep, and I found that almost none of the printk() calls in kernel/lockdep.c have a KERN_FOO level specified.

It looks like it could use patching, but before I code something, I need to know if the patch should be doing:

a) Adding the missing KERN_FOO levels..
or
b) Adding a comment explaining the subtle reason they're not there...

i guess most could/should be converted to pr_info() - and a couple of them need to be KERN_CONT.

Ingo