Skip to contentSkip to conversation

smb: client: Use more common code in smb311_posix_mkdir()

PATCH New Markus Elfring 1 participant 1 message Oct 9, 2025

Subsystems (3)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 smb: client: Use more common code in smb311_posix_mkdir()

From: Markus Elfring <[email protected]>
Date: Thu, 9 Oct 2025 10:08:04 +0200

Use an additional label so that a bit of common code can be better reused at the end of this function implementation.

---
 fs/smb/client/smb2pdu.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)
fs/smb/client/smb2pdu.c +2 -2
index 42e2d4ea344d..3a62a3a35580 100644
@@ -2975,8 +2975,7 @@ int smb311_posix_mkdir(const unsigned int xid, struct inode *inode,
 	rsp = (struct smb2_create_rsp *)rsp_iov.iov_base;
 	if (rsp == NULL) {
 		rc = -EIO;
-		kfree(pc_buf);
-		goto err_free_req;
+		goto err_free_pc_buf;
 	}
 
 	trace_smb3_posix_mkdir_done(xid, rsp->PersistentFileId, tcon->tid, ses->Suid,
@@ -2988,6 +2987,7 @@ int smb311_posix_mkdir(const unsigned int xid, struct inode *inode,
 
 err_free_rsp_buf:
 	free_rsp_buf(resp_buftype, rsp_iov.iov_base);
+err_free_pc_buf:
 	kfree(pc_buf);
 err_free_req:
 	cifs_small_buf_release(req);
Signature · 1 line
2.51.0