acpi=off and acpi_get_firmware_table
In 2.6.12-rc4, I added acpi=off to the kernel command line and it panic-ed in acpi_get_firmware_table, called from the IPMI driver.
The attached patch fixes the problem, but it still spits out ugly "ACPI-0166: *** Error: Invalid address flags 8" errors. So I doubt the patch is right, but maybe it points to something else.
Is it legal to call acpi_get_firmware_table if acpi is off? If not, how can I tell that acpi is off?
-Corey
drivers/acpi/tables/tbxfroot.c +3 -1
@@ -313,7 +313,9 @@ cleanup: -acpi_os_unmap_memory (rsdt_info->pointer, (acpi_size ) rsdt_info->pointer->length); +if (rsdt_info->pointer) +acpi_os_unmap_memory (rsdt_info->pointer, + (acpi_size ) rsdt_info->pointer->length);ACPI_MEM_FREE (rsdt_info);if (header) {
Quoted 9 lines · Corey Minyard
In 2.6.12-rc4, I added acpi=off to the kernel command line and it panic-ed in
acpi_get_firmware_table, called from the IPMI driver.The attached patch fixes the problem, but it still spits out ugly "ACPI-0166: *** Error: Invalid address flags 8" errors. So I doubt the patch is right, but maybe it points to something else.
Is it legal to call
acpi_get_firmware_tableif acpi is off? If not, how can I tell that acpi is off?
Please check 'acpi_disabled' variable.
Thanks,
Shaohua
Quoted 13 lines · Shaohua Li
Quoted 7 lines · Corey Minyard
In 2.6.12-rc4, I added acpi=off to the kernel command line and it panic-ed in
acpi_get_firmware_table, called from the IPMI driver.The attached patch fixes the problem, but it still spits out ugly "ACPI-0166: *** Error: Invalid address flags 8" errors. So I doubt the patch is right, but maybe it points to something else.
Is it legal to call
acpi_get_firmware_tableif acpi is off? If not, how can I tell that acpi is off?Please check '
acpi_disabled' variable.
acpi_disabled is not available on ia64. It doesn't seem to be a standard interface. So that's not an option.
-Corey
Quoted 16 lines · Corey Minyard
Quoted 14 lines · Shaohua Li
Quoted 11 lines · Corey Minyard
In 2.6.12-rc4, I added acpi=off to the kernel command line and it panic-ed in
acpi_get_firmware_table, called from the IPMI driver.The attached patch fixes the problem, but it still spits out ugly "ACPI-0166: *** Error: Invalid address flags 8" errors. So I doubt the patch is right, but maybe it points to something else.
Is it legal to call
acpi_get_firmware_tableif acpi is off? If not, how can I tell that acpi is off?
Quoted 5 lines
Quoted 3 lines
Please check '
acpi_disabled' variable.
acpi_disabledis not available on ia64. It doesn't seem to be a standard interface. So that's not an option.
It always return 0 in IA64. IA64 can't disable ACPI.
Thanks,
Shaohua