: hotplug/ia64: SN Hotplug Driver - PREEMPT/pcibus_info

PATCH In review Prarit Bhargava 1 participant 2 messages May 12, 2005 – May 13, 2005

Share & tools

Prarit Bhargava

author

2005-05-12 13:48 UTC #0 lore raw

PATCH 6/6 : hotplug/ia64: SN Hotplug Driver - PREEMPT/pcibus_info

This patch fixes an issue with the PROM and a kernel running with CONFIG_PREEMPT enabled. When CONFIG_PREEMPT is enabled, the size of a spinlock_t changes -- resulting in the PROM writing to an incorrect location.

Signed-off-by Prarit Bhargava <[email protected]>

---
commit 504a8031fc066492285640128780f152e91a05ff tree 0b3875eb291c83888838c40fe54869d58d0f9f61 parent b37f84886e06a5892a02a0906e8b3f2d51daf1d2 author Prarit Bhargava <[email protected]> 1810126687 -0400 committer Prarit Bhargava <[email protected]> 1810126687 -0400

Index: include/asm-ia64/sn/pcibr_provider.h
=================================---
d42322aa13214a5d099019ff0406dfb328960b98/include/asm-ia64/sn/pcibr_provider.h (mode:100644 sha1:c1bf22505ff339ea7a5255ec9a8a60031397e9a8)
+++
0b3875eb291c83888838c40fe54869d58d0f9f61/include/asm-ia64/sn/pcibr_provider.h (mode:100644 sha1:e6430a26fcfae1ceefd447d1b30e3e453a6b93d4)
@@ -108,10 +108,11 @@
char pbi_hub_xid;

uint64_t pbi_devreg[8];
- spinlock_t pbi_lock;

uint32_t pbi_valid_devices;
uint32_t pbi_enabled_devices;
+
+ spinlock_t pbi_lock;
};

Prarit Bhargava

author

2005-05-13 00:46 UTC #1 lore raw

PATCH 6/6 : hotplug/ia64: SN Hotplug Driver - PREEMPT/pcibus_info fix

Signed-off-by Prarit Bhargava <[email protected]>

Index: include/asm-ia64/sn/pcibr_provider.h
=================================--- d42322aa13214a5d099019ff0406dfb328960b98/include/asm-ia64/sn/pcibr_provider.h (mode:100644 sha1:c1bf22505ff339ea7a5255ec9a8a60031397e9a8) +++ 0b3875eb291c83888838c40fe54869d58d0f9f61/include/asm-ia64/sn/pcibr_provider.h (mode:100644 sha1:e6430a26fcfae1ceefd447d1b30e3e453a6b93d4)
@@ -108,10 +108,11 @@
char pbi_hub_xid;

uint64_t pbi_devreg[8];
- spinlock_t pbi_lock;

uint32_t pbi_valid_devices;
uint32_t pbi_enabled_devices;
+
+ spinlock_t pbi_lock;
};