Skip to contentSkip to conversation

- nicstar gcc 4 warnings

PATCH In review Chuck Short 2 participants 2 messages May 30, 2005

Subsystems (2)
Kernel janitors ATM
lore
Share & tools
lore

Chuck Short

author
#0 lore raw

PATCH 1/1 - nicstar gcc 4 warnings

Hi,

This patch fixes gcc4 warnings when compiling the nicstar driver.

Signed-off by: Chuck Short <[email protected]>

drivers/atm/nicstar.c +1 -1
diff -Naur linux-source-2.6.12-2.6.11.93.orig/drivers/atm/nicstar.c linux-source-2.6.12-2.6.11.93/drivers/atm/nicstar.c
@@ -2111,7 +2111,7 @@
 
 static void process_rsq(ns_dev *card)
 {
-   ns_rsqe *previous;
+   ns_rsqe *previous = NULL;
 
    if (!ns_rsqe_valid(card->rsq.next))
       return;

_______________________________________________
Kernel-janitors mailing list
[email protected]
http://lists.osdl.org/mailman/listinfo/kernel-janitors

#1 lore raw

drivers/atm/nicstar.c line 2114

Quoted 9 lines · Chuck Short

This patch fixes gcc4 warnings when compiling the nicstar driver.

drivers/atm/nicstar.c +0 -0

static void process_rsq(ns_dev *card)
{

drivers/atm/nicstar.c +1 -1
-   ns_rsqe *previous;
+   ns_rsqe *previous = NULL;

FWIW, this warning is bogus too.
======================================

#define ns_rsqe_valid(ns_rsqep) \
        (le32_to_cpu((ns_rsqep)->word_4) & NS_RSQE_VALID)

static void process_rsq(ns_dev *card)

{
	ns_rsqe *previous;

	if (!ns_rsqe_valid(card->rsq.next))
		return;
	/* now ns_rsqe_valid(card->rsq.next) = true */
	while (ns_rsqe_valid(card->rsq.next)) {
		dequeue_rx(card, card->rsq.next);
		ns_rsqe_init(card->rsq.next);
		/* previous is initialized */
		previous = card->rsq.next;
		if (card->rsq.next = card->rsq.last)
			card->rsq.next = card->rsq.base;
		else
			card->rsq.next++;
	}
	writel((((u32) previous) - ((u32) card->rsq.base)),
			card->membase + RSQH);
}

_______________________________________________
Kernel-janitors mailing list
[email protected]
http://lists.osdl.org/mailman/listinfo/kernel-janitors