2.6.12 breaks 8139cp
Subsystems (3)
Upgrading from 2.6.11 to 2.6.12 caused my 8139cp network card to stop working. No error messages are emitted and everything seems to work (from the local computers point of view). But nothing can be recieved from the network.
Since 8139cp.c hasn't undergone any significant changes between the versions the bug must be in something related. Any ideas?
Rgds
Pierre
Quoted 4 lines · Pierre Ossman
Upgrading from 2.6.11 to 2.6.12 caused my 8139cp network card to stop working. No error messages are emitted and everything seems to work (from the local computers point of view). But nothing can be recieved from the network.
You might post a little more information (i.e., the 2.6.12 dmesg and possibly a diff vs. 2.6.11). My guess is something's busted with its IRQ.
Quoted 10 lines · Bjorn Helgaas
Quoted 6 lines · Pierre Ossman
Upgrading from 2.6.11 to 2.6.12 caused my 8139cp network card to stop working. No error messages are emitted and everything seems to work (from the local computers point of view). But nothing can be recieved from the network.
Quoted 5 lines
You might post a little more information (i.e., the 2.6.12 dmesg and possibly a diff vs. 2.6.11). My guess is something's busted with its IRQ.
dmesg:s included. But they don't really differ more than some cosmetic changes in the output strings.
The problem is I can't find anything that differs. 2.6.12 behaves more or less like someone cut of the rx pins in the connector. ifconfig doesn't report any errors so it isn't a problem with packets getting dropped. tcpdump only shows the outgoing packets.
Any more ideas on what I should examine to find any differences?
Rgds
Pierre
000000a0000 (reserved)
BIOS-e820: 00000000000e0000 - 0000000000100000 (reserved)
BIOS-e820: 0000000000100000 - 000000001ffd0000 (usable)
BIOS-e820: 000000001ffd0000 - 000000001fff0c00 (reserved)
BIOS-e820: 000000001fff0c00 - 000000001fffc000 (ACPI NVS)
BIOS-e820: 000000001fffc000 - 0000000020000000 (reserved)
511MB LOWMEM available.
On node 0 totalpages: 131024
DMA zone: 4096 pages, LIFO batch:1
Normal zone: 126928 pages, LIFO batch:16
HighMem zone: 0 pages, LIFO batch:1
DMI 2.3 present.
ACPI: RSDP (v000 COMPAQ ) @ 0x000f6560
ACPI: RSDT (v001 HP CPQ0860 0x13090420 CPQ 0x00000001) @ 0x1fff0c84
ACPI: FADT (v002 HP CPQ0860 0x00000002 CPQ 0x00000001) @ 0x1fff0c00
ACPI: SSDT (v001 COMPAQ CPQGysr 0x00001001 MSFT 0x0100000e) @ 0x1fff5c3c
ACPI: DSDT (v001 HP nx7000 0x00010000 MSFT 0x0100000e) @ 0x00000000
ACPI: PM-Timer IO Port: 0x1008
Allocating PCI resources starting at 20000000 (gap: 20000000:e0000000)
Built 1 zonelists
Kernel command line: ro root=/dev/hda5 rhgb quiet
Local APIC disabled by BIOS -- you can enable it with "lapic"
mapped APIC to ffffd000 (01404000)
Initializing CPU#0
CPU 0 irqstacks, hard=c0541000 soft=c0540000
PID hash table entries: 2048 (order: 11, 32768 bytes)
Detected 1594.918 MHz processor.
Using pmtmr for high-res timesource
Console: colour VGA+ 80x25
Dentry cache hash table entries: 131072 (order: 7, 524288 bytes)
Inode-cache hash table entries: 65536 (order: 6, 262144 bytes)
Memory: 512904k/524096k available (3371k kernel code, 10588k reserved, 732k data, 220k init, 0k highmem) Checking if this processor honours the WP bit even in supervisor mode... Ok. Calibrating delay loop... 3162.11 BogoMIPS (lpj=1581056)
Security Framework v1.0.0 initialized
Capability LSM initialized
Mount-cache hash table entries: 512 (order: 0, 4096 bytes)
CPU: After generic identify, caps: a7e9f9bf 00000000 00000000 00000000 00000180 00000000 00000000
CPU: After vendor identify, caps: a7e9f9bf 00000000 00000000 00000000 00000180 00000000 00000000
CPU: L1 I cache: 32K, L1 D cache: 32K
CPU: L2 cache: 1024K
CPU: After all inits, caps: a7e9f9bf 00000000 00000000 00000040 00000180 00000000 00000000 Intel machine check architecture supported.
Intel machine check reporting enabled on CPU#0.
CPU: Intel(R) Pentium(R) M processor 1600MHz stepping 05
Enabling fast FPU save and restore... done.
Enabling unmasked SIMD FPU exception support... done.
Checking 'hlt' instruction... OK.
ACPI: setting ELCR to 0200 (from 0c20)
checking if image is initramfs... it is
Freeing initrd memory: 1090k freed
NET: Registered protocol family 16
PCI: PCI BIOS revision 2.10 entry at 0xf031f, last bus=3
PCI: Using configuration type 1
mtrr: v2.0 (20020519)
ACPI: Subsystem revision 20050211
ACPI: Interpreter enabled
ACPI: Using PIC for interrupt routing
ACPI: PCI Root Bridge [C046] (00:00)
PCI: Probing PCI hardware (bus 00)
PCI: Ignoring BAR0-3 of IDE controller 0000:00:1f.1
PCI: Via IRQ fixup
PCI: Transparent bridge - 0000:00:1e.0
ACPI: PCI Interrupt Routing Table [\_SB_.C046._PRT]
ACPI: PCI Interrupt Routing Table [\_SB_.C046.C047._PRT]
ACPI: PCI Interrupt Routing Table [\_SB_.C046.C058._PRT]
ACPI: Embedded Controller [C0EA] (gpe 28)
ACPI: Power Resource [C18D] (on)
ACPI: Power Resource [C195] (on)
ACPI: Power Resource [C19C] (on)
ACPI: Power Resource [C1A6] (on)
ACPI: PCI Interrupt Link [C0C2] (IRQs 5 *10)
ACPI: PCI Interrupt Link [C0C3] (IRQs 5 *10)
ACPI: PCI Interrupt Link [C0C4] (IRQs *5 10)
ACPI: PCI Interrupt Link [C0C5] (IRQs *5 10)
ACPI: PCI Interrupt Link [C0C6] (IRQs 5 10) *0, disabled.
ACPI: PCI Interrupt Link [C0C7] (IRQs 5 10) *11
ACPI: PCI Interrupt Link [C0C8] (IRQs 5 10) *0, disabled.
ACPI: PCI Interrupt Link [C0C9] (IRQs *5 10)
Linux Plug and Play Support v0.97 (c) Adam Belay
pnp: PnP ACPI init
pnp: PnP ACPI: found 15 devices
PnPBIOS: Disabled by ACPI PNP
usbcore: registered new driver usbfs
usbcore: registered new driver hub
PCI: Using ACPI for IRQ routing
** PCI interrupts are no longer routed automatically. If this
** causes a device to stop working, it is probably because the
** driver failed to call pci_enable_device(). As a temporary
** workaround, the "pci=routeirq" argument restores the old
** behavior. If this argument makes the device work again,
** please email the output of "lspci" to [email protected]
** so I can fix the driver.
pnp: the driver 'system' has been registered
pnp: match found with the PnP device '00:00' and the driver 'system'
pnp: match found with the PnP device '00:0c' and the driver 'system'
pnp: match found with the PnP device '00:0d' and the driver 'system'
pnp: 00:0d: ioport range 0x4d0-0x4d1 has been reserved
pnp: 00:0d: ioport range 0x1000-0x107f could not be reserved
pnp: 00:0d: ioport range 0x1100-0x113f has been reserved
pnp: 00:0d: ioport range 0x1200-0x121f has been reserved
pnp: match found with the PnP device '00:0e' and the driver 'system'
apm: BIOS version 1.2 Flags 0x03 (Driver version 1.16ac)
apm: overridden by ACPI.
audit: initializing netlink socket (disabled)
audit(1119514693.293:0): initialized
Total HugeTLB memory allocated, 0
VFS: Disk quotas dquot_6.5.1
Dquot-cache hash table entries: 1024 (order 0, 4096 bytes)
SGI XFS with ACLs, security attributes, no debug enabled
SGI XFS Quota Management subsystem
Initializing Cryptographic API
ACPI: CPU0 (power states: C1[C1] C2[C2] C3[C3])
ACPI: Processor [CPU0] (supports 8 throttling states)
isapnp: Scanning for PnP cards...
isapnp: No Plug & Play device found
Real Time Clock Driver v1.12
Linux agpgart interface v0.100 (c) Dave Jones
agpgart: Detected an Intel 855PM Chipset.
agpgart: Maximum main memory to use for agp memory: 439M
agpgart: AGP aperture is 256M @ 0xb0000000
[drm] Initialized drm 1.0.0 20040925
ACPI: PS/2 Keyboard Controller [C1A3] at I/O 0x60, 0x64, irq 1
ACPI: PS/2 Mouse Controller [C1A4] at irq 12i8042.c: Detected active multiplexing controller, rev 1.1.
serio: i8042 AUX0 port at 0x60,0x64 irq 12
serio: i8042 AUX1 port at 0x60,0x64 irq 12
serio: i8042 AUX2 port at 0x60,0x64 irq 12
serio: i8042 AUX3 port at 0x60,0x64 irq 12
serio: i8042 KBD port at 0x60,0x64 irq 1
Serial: 8250/16550 driver $Revision: 1.90 $ 8 ports, IRQ sharing enabled
ttyS0 at I/O 0x3f8 (irq = 4) is a 16550A
ttyS2 at I/O 0x3e8 (irq = 3) is a 16550A
pnp: the driver 'serial' has been registered
pnp: match found with the PnP device '00:03' and the driver 'serial'
ttyS0 at I/O 0x3f8 (irq = 4) is a 16550A
ACPI: PCI Interrupt Link [C0C3] enabled at IRQ 10
PCI: setting IRQ 10 as level-triggered
ACPI: PCI interrupt 0000:00:1f.6[B] -> GSI 10 (level, low) -> IRQ 10
io scheduler noop registered
io scheduler anticipatory registered
io scheduler deadline registered
io scheduler cfq registered
RAMDISK driver initialized: 16 RAM disks of 16384K size 1024 blocksize
Uniform Multi-Platform E-IDE driver Revision: 7.00alpha2
ide: Assuming 33MHz system bus speed for PIO modes; override with idebus=xx
ICH4: IDE controller at PCI slot 0000:00:1f.1
PCI: Enabling device 0000:00:1f.1 (0005 -> 0007)
ACPI: PCI Interrupt Link [C0C4] enabled at IRQ 5
PCI: setting IRQ 5 as level-triggered
ACPI: PCI interrupt 0000:00:1f.1[A] -> GSI 5 (level, low) -> IRQ 5
ICH4: chipset revision 1
ICH4: not 100% native mode: will probe irqs later
ide0: BM-DMA at 0x4c40-0x4c47, BIOS settings: hda:DMA, hdb:pio
ide1: BM-DMA at 0x4c48-0x4c4f, BIOS settings: hdc:DMA, hdd:pioProbing IDE interface ide0...
hda: TOSHIBA MK4025GAS, ATA DISK drive
ide0 at 0x1f0-0x1f7,0x3f6 on irq 14
Probing IDE interface ide1...
hdc: HL-DT-STCD-RW/DVD DRIVE GCC-4241N, ATAPI CD/DVD-ROM drive
ide1 at 0x170-0x177,0x376 on irq 15
pnp: the driver 'ide' has been registered
ide2: I/O resource 0x3EE-0x3EE not free.
ide2: ports already in use, skipping probe
Probing IDE interface ide3...
Probing IDE interface ide4...
Probing IDE interface ide5...
hda: max request size: 128KiB
hda: 78140160 sectors (40007 MB), CHS=65535/16/63, UDMA(100)
hda: cache flushes supported
hda: hda1 hda2 hda3 hda4 < hda5 hda6 >
hdc: ATAPI 24X DVD-ROM CD-R/RW drive, 2048kB Cache, DMA
Uniform CD-ROM driver Revision: 3.20
ide-floppy driver 0.99.newide
usbcore: registered new driver hiddev
usbcore: registered new driver usbhiddrivers/usb/input/hid-core.c: v2.0:USB HID core driver
mice: PS/2 mouse device common for all mice
input: AT Translated Set 2 keyboard on isa0060/serio0
Synaptics Touchpad, model: 1
Firmware: 5.9
Sensor: 35
new absolute packet format
Touchpad has extended capability bits
-> multifinger detection
-> palm detection
input: SynPS/2 Synaptics TouchPad on isa0060/serio4
NET: Registered protocol family 2
IP: routing cache hash table of 1024 buckets, 32Kbytes
TCP established hash table entries: 32768 (order: 6, 262144 bytes)
TCP bind hash table entries: 32768 (order: 7, 917504 bytes)
TCP: Hash tables configured (established 32768 bind 32768)
Initializing IPsec netlink socket
NET: Registered protocol family 1
NET: Registered protocol family 17
Software Suspend Core.
Software Suspend text mode support loaded.
Software Suspend LZF Compression Driver registered.
Software Suspend Swap Writer registered.
ACPI wakeup devices:
C058 C1AD C1A3 C1A4 C0AC C0B3 C0B4 C0B5 C0E7 C136
ACPI: (supports S0 S3 S4 S4bios S5)
Freeing unused kernel memory: 220k freed
Looking for first block of swap header at block 0.
Setting logical block size of resume device to 4096.
Software Suspend 2.1.8: Swap space signature found.
Software Suspend 2.1.8: Suspending enabled.
Software Suspend 2.1.8: This is normal swap space.
EXT3-fs: mounted filesystem with ordered data mode.
kjournald starting. Commit interval 5 seconds
8139cp: 10/100 PCI Ethernet driver v1.2 (Mar 22, 2004)
ACPI: PCI interrupt 0000:02:01.0[A] -> GSI 10 (level, low) -> IRQ 10
eth0: RTL-8139C+ at 0xe0828000, 00:02:3f:22:db:8c, IRQ 10ieee80211_crypt: registered algorithm 'NULL'
ipw2200: Intel(R) PRO/Wireless 2200/2915 Network Driver, 1.0.4
ipw2200: Copyright(c) 2003-2004 Intel Corporation
ACPI: PCI Interrupt Link [C0C5] enabled at IRQ 5
ACPI: PCI interrupt 0000:02:02.0[A] -> GSI 5 (level, low) -> IRQ 5
ipw2200: Detected Intel PRO/Wireless 2200BG Network Connection
ipw2200: Radio Frequency Kill Switch is On:
Kill switch must be turned off for wireless networking to work.
ACPI: PCI interrupt 0000:00:1f.5[B] -> GSI 10 (level, low) -> IRQ 10
PCI: Setting latency timer of device 0000:00:1f.5 to 64intel8x0_measure_ac97_clock: measured 49284 usecs
intel8x0: clocking to 48000
ACPI: PCI interrupt 0000:00:1f.6[B] -> GSI 10 (level, low) -> IRQ 10
PCI: Setting latency timer of device 0000:00:1f.6 to 64hw_random: RNG not detected
ACPI: PCI Interrupt Link [C0C9] enabled at IRQ 5
ACPI: PCI interrupt 0000:00:1d.7[D] -> GSI 5 (level, low) -> IRQ 5ehci_hcd 0000:00:1d.7: EHCI Host Controller
PCI: Setting latency timer of device 0000:00:1d.7 to 64ehci_hcd 0000:00:1d.7: irq 5, pci mem 0xa0000000ehci_hcd 0000:00:1d.7: new USB bus registered, assigned bus number 1
PCI: cache line size of 32 is not supported by device 0000:00:1d.7ehci_hcd 0000:00:1d.7: USB 2.0 initialized, EHCI 1.00, driver 10 Dec 2004
hub 1-0:1.0: USB hub found
hub 1-0:1.0: 6 ports detected
USB Universal Host Controller Interface driver v2.2
ACPI: PCI Interrupt Link [C0C2] enabled at IRQ 10
ACPI: PCI interrupt 0000:00:1d.0[A] -> GSI 10 (level, low) -> IRQ 10uhci_hcd 0000:00:1d.0: UHCI Host Controller
PCI: Setting latency timer of device 0000:00:1d.0 to 64uhci_hcd 0000:00:1d.0: irq 10, io base 0x48c0uhci_hcd 0000:00:1d.0: new USB bus registered, assigned bus number 2
hub 2-0:1.0: USB hub found
hub 2-0:1.0: 2 ports detected
ACPI: PCI interrupt 0000:00:1d.1[B] -> GSI 5 (level, low) -> IRQ 5uhci_hcd 0000:00:1d.1: UHCI Host Controller
PCI: Setting latency timer of device 0000:00:1d.1 to 64uhci_hcd 0000:00:1d.1: irq 5, io base 0x48e0uhci_hcd 0000:00:1d.1: new USB bus registered, assigned bus number 3
hub 3-0:1.0: USB hub found
hub 3-0:1.0: 2 ports detected
ACPI: PCI interrupt 0000:00:1d.2[C] -> GSI 5 (level, low) -> IRQ 5uhci_hcd 0000:00:1d.2: UHCI Host Controller
PCI: Setting latency timer of device 0000:00:1d.2 to 64uhci_hcd 0000:00:1d.2: irq 5, io base 0x4c00uhci_hcd 0000:00:1d.2: new USB bus registered, assigned bus number 4
hub 4-0:1.0: USB hub found
hub 4-0:1.0: 2 ports detected
Linux Kernel Card Services
options: [pci] [cardbus] [pm]
ACPI: PCI interrupt 0000:02:04.0[A] -> GSI 5 (level, low) -> IRQ 5
Yenta: CardBus bridge found at 0000:02:04.0 [0e11:0860]
Yenta: Using CSCINT to route CSC interrupts to PCI
Yenta: Routing CardBus interrupts to PCI
Yenta TI: socket 0000:02:04.0, mfunc 0x001c1112, devctl 0x44
Yenta: ISA IRQ mask 0x0000, PCI irq 5
Socket status: 30000006
ieee1394: Initialized config rom entry `ip1394'
ohci1394: $Rev: 1223 $ Ben Collins <[email protected]>
ACPI: PCI interrupt 0000:02:00.0[A] -> GSI 10 (level, low) -> IRQ 10
ohci1394: fw-host0: OHCI-1394 1.0 (PCI): IRQ=[10] MMIO=[90200000-902007ff] Max Packet=[1024]
ieee1394: Host added: ID:BUS[0-00:1023] GUID[00023f454a000284]
ACPI: AC Adapter [C134] (on-line)
ACPI: Battery Slot [C11F] (battery absent)
ACPI: Power Button (FF) [PWRF]
ACPI: Lid Switch [C136]ibm_acpi: ec object not found
ACPI: Video Device [C0D0] (multi-head: yes rom: no post: no)
EXT3 FS on hda5, internal journal
kjournald starting. Commit interval 5 seconds
EXT3 FS on hda1, internal journal
EXT3-fs: mounted filesystem with ordered data mode.
Adding 977248k swap on /dev/hda2. Priority:-1 extents:1ip_tables: (C) 2000-2002 Netfilter core teamip_conntrack version 2.1 (4094 buckets, 32752 max) - 244 bytes per conntrack
cs: IO port probe 0xc00-0xcff: clean.
cs: IO port probe 0x800-0x8ff: clean.
cs: IO port probe 0x100-0x4ff: excluding 0x140-0x14f 0x200-0x20f 0x378-0x37f
cs: IO port probe 0xa00-0xaff: clean.
Bluetooth: Core ver 2.7
NET: Registered protocol family 31
Bluetooth: HCI device and connection manager initialized
Bluetooth: HCI socket layer initialized
Bluetooth: L2CAP ver 2.7
Bluetooth: L2CAP socket layer initialized
Bluetooth: RFCOMM ver 1.5
Bluetooth: RFCOMM socket layer initialized
Bluetooth: RFCOMM TTY layer initialized
Bluetooth: HIDP (Human Interface Emulation) ver 1.1
NET: Registered protocol family 23
IrCOMM protocol (Dag Brattli)
CSLIP: code copyright 1989 Regents of the University of California
PPP generic driver version 2.4.2
IrDA: Registered device irda0 (irport io=0x3E8 irq=3)drivers/net/irda/irport.c:442: spin_is_locked(drivers/net/irda/irport.c:db025608) already locked by drivers/net/irda/irport.c/912 drivers/net/irda/irport.c:443: spin_lock(drivers/net/irda/irport.c:db025608) already locked by drivers/net/irda/irport.c/912 drivers/net/irda/irport.c:919: spin_unlock(drivers/net/irda/irport.c:db025608) not locked
pnp: the driver 'parport_pc' has been registered
pnp: match found with the PnP device '00:05' and the driver 'parport_pc'
parport: PnPBIOS parport detected.
parport0: PC-style at 0x378 (0x778), irq 7 [PCSPP,TRISTATE]
lp0: using parport0 (interrupt-driven).
lp0: console ready
tun: Universal TUN/TAP device driver, 1.6
tun: (C) 1999-2004 Max Krasnyansky <[email protected]>
eth0: link up, 100Mbps, full-duplex, lpa 0x45E1
ACPI: PCI interrupt 0000:01:00.0[A] -> GSI 10 (level, low) -> IRQ 10
[drm] Initialized radeon 1.14.0 20050125 on minor 0:
eth0: link up, 100Mbps, full-duplex, lpa 0x45E1
eth0: link up, 100Mbps, full-duplex, lpa 0x45E1
ipw2200: failed to send SYSTEM_CONFIG command
ipw2200: ipw_send_system_config failed
Linux version 2.6.12 ([email protected]) (gcc version 4.0.0 20050616 (Red Hat 4.0.0-12)) #3 Wed Jun 22 21:10:33 CEST 2005 BIOS-provided physical RAM map:
BIOS-e820: 0000000000000000 - 000000000009fc00 (usable)
BIOS-e820: 000000000009fc00 - 00000000000a0000 (reserved)
BIOS-e820: 00000000000e0000 - 0000000000100000 (reserved)
BIOS-e820: 0000000000100000 - 000000001ffd0000 (usable)
BIOS-e820: 000000001ffd0000 - 000000001fff0c00 (reserved)
BIOS-e820: 000000001fff0c00 - 000000001fffc000 (ACPI NVS)
BIOS-e820: 000000001fffc000 - 0000000020000000 (reserved)
511MB LOWMEM available.
On node 0 totalpages: 131024
DMA zone: 4096 pages, LIFO batch:1
Normal zone: 126928 pages, LIFO batch:31
HighMem zone: 0 pages, LIFO batch:1
DMI 2.3 present.
ACPI: RSDP (v000 COMPAQ ) @ 0x000f6560
ACPI: RSDT (v001 HP CPQ0860 0x13090420 CPQ 0x00000001) @ 0x1fff0c84
ACPI: FADT (v002 HP CPQ0860 0x00000002 CPQ 0x00000001) @ 0x1fff0c00
ACPI: SSDT (v001 COMPAQ CPQGysr 0x00001001 MSFT 0x0100000e) @ 0x1fff5c3c
ACPI: DSDT (v001 HP nx7000 0x00010000 MSFT 0x0100000e) @ 0x00000000
ACPI: PM-Timer IO Port: 0x1008
Allocating PCI resources starting at 20000000 (gap: 20000000:e0000000)
Built 1 zonelists
Kernel command line: ro root=/dev/hda5 rhgb quiet
Local APIC disabled by BIOS -- you can enable it with "lapic"
mapped APIC to ffffd000 (01404000)
Initializing CPU#0
CPU 0 irqstacks, hard=c0542000 soft=c0541000
PID hash table entries: 2048 (order: 11, 32768 bytes)
Detected 1594.880 MHz processor.
Using pmtmr for high-res timesource
Console: colour VGA+ 80x25
Dentry cache hash table entries: 131072 (order: 7, 524288 bytes)
Inode-cache hash table entries: 65536 (order: 6, 262144 bytes)
Memory: 512892k/524096k available (3386k kernel code, 10600k reserved, 725k data, 216k init, 0k highmem) Checking if this processor honours the WP bit even in supervisor mode... Ok.
Calibrating delay loop... 3162.11 BogoMIPS (lpj=1581056)
Security Framework v1.0.0 initialized
Capability LSM initialized
Mount-cache hash table entries: 512
CPU: After generic identify, caps: a7e9f9bf 00000000 00000000 00000000 00000180 00000000 00000000
CPU: After vendor identify, caps: a7e9f9bf 00000000 00000000 00000000 00000180 00000000 00000000
CPU: L1 I cache: 32K, L1 D cache: 32K
CPU: L2 cache: 1024K
CPU: After all inits, caps: a7e9f9bf 00000000 00000000 00000040 00000180 00000000 00000000
Intel machine check architecture supported.
Intel machine check reporting enabled on CPU#0.
CPU: Intel(R) Pentium(R) M processor 1600MHz stepping 05
Enabling fast FPU save and restore... done.
Enabling unmasked SIMD FPU exception support... done.
Checking 'hlt' instruction... OK.
ACPI: setting ELCR to 0200 (from 0c20)
checking if image is initramfs... it is
Freeing initrd memory: 1090k freed
NET: Registered protocol family 16
PCI: PCI BIOS revision 2.10 entry at 0xf031f, last bus=3
PCI: Using configuration type 1
mtrr: v2.0 (20020519)
ACPI: Subsystem revision 20050309
ACPI: Interpreter enabled
ACPI: Using PIC for interrupt routing
ACPI: PCI Root Bridge [C046] (0000:00)
PCI: Probing PCI hardware (bus 00)
PCI: Ignoring BAR0-3 of IDE controller 0000:00:1f.1
Boot video device is 0000:01:00.0
PCI: Transparent bridge - 0000:00:1e.0
ACPI: PCI Interrupt Routing Table [\_SB_.C046._PRT]
ACPI: PCI Interrupt Routing Table [\_SB_.C046.C047._PRT]
ACPI: PCI Interrupt Routing Table [\_SB_.C046.C058._PRT]
ACPI: Embedded Controller [C0EA] (gpe 28)
ACPI: Power Resource [C18D] (on)
ACPI: Power Resource [C195] (on)
ACPI: Power Resource [C19C] (on)
ACPI: Power Resource [C1A6] (on)
ACPI: PCI Interrupt Link [C0C2] (IRQs 5 *10)
ACPI: PCI Interrupt Link [C0C3] (IRQs 5 *10)
ACPI: PCI Interrupt Link [C0C4] (IRQs *5 10)
ACPI: PCI Interrupt Link [C0C5] (IRQs *5 10)
ACPI: PCI Interrupt Link [C0C6] (IRQs 5 10) *0, disabled.
ACPI: PCI Interrupt Link [C0C7] (IRQs 5 10) *11
ACPI: PCI Interrupt Link [C0C8] (IRQs 5 10) *0, disabled.
ACPI: PCI Interrupt Link [C0C9] (IRQs *5 10)
Linux Plug and Play Support v0.97 (c) Adam Belay
pnp: PnP ACPI init
pnp: PnP ACPI: found 15 devices
PnPBIOS: Disabled by ACPI PNP
usbcore: registered new driver usbfs
usbcore: registered new driver hub
PCI: Using ACPI for IRQ routing
PCI: If a device doesn't work, try "pci=routeirq". If it helps, post a report
pnp: the driver 'system' has been registered
pnp: match found with the PnP device '00:00' and the driver 'system'
pnp: match found with the PnP device '00:0c' and the driver 'system'
pnp: match found with the PnP device '00:0d' and the driver 'system'
pnp: 00:0d: ioport range 0x4d0-0x4d1 has been reserved
pnp: 00:0d: ioport range 0x1000-0x107f could not be reserved
pnp: 00:0d: ioport range 0x1100-0x113f has been reserved
pnp: 00:0d: ioport range 0x1200-0x121f has been reserved
pnp: match found with the PnP device '00:0e' and the driver 'system'
audit: initializing netlink socket (disabled)
audit(1119514452.486:0): initialized
Total HugeTLB memory allocated, 0
VFS: Disk quotas dquot_6.5.1
Dquot-cache hash table entries: 1024 (order 0, 4096 bytes)
SGI XFS with ACLs, security attributes, no debug enabled
SGI XFS Quota Management subsystem
Initializing Cryptographic API
isapnp: Scanning for PnP cards...
isapnp: No Plug & Play device found
Real Time Clock Driver v1.12
Linux agpgart interface v0.101 (c) Dave Jones
agpgart: Detected an Intel 855PM Chipset.
agpgart: AGP aperture is 256M @ 0xb0000000
[drm] Initialized drm 1.0.0 20040925
pnp: the driver 'i8042 kbd' has been registered
pnp: match found with the PnP device '00:0a' and the driver 'i8042 kbd'
pnp: the driver 'i8042 aux' has been registered
pnp: match found with the PnP device '00:0b' and the driver 'i8042 aux'
PNP: PS/2 Controller [PNP0303:C1A3,PNP0f13:C1A4] at 0x60,0x64 irq 1,12i8042.c: Detected active multiplexing controller, rev 1.1.
serio: i8042 AUX0 port at 0x60,0x64 irq 12
serio: i8042 AUX1 port at 0x60,0x64 irq 12
serio: i8042 AUX2 port at 0x60,0x64 irq 12
serio: i8042 AUX3 port at 0x60,0x64 irq 12
serio: i8042 KBD port at 0x60,0x64 irq 1
Serial: 8250/16550 driver $Revision: 1.90 $ 8 ports, IRQ sharing enabled
ttyS0 at I/O 0x3f8 (irq = 4) is a 16550A
ttyS2 at I/O 0x3e8 (irq = 3) is a 16550A
pnp: the driver 'serial' has been registered
pnp: match found with the PnP device '00:03' and the driver 'serial'
ttyS0 at I/O 0x3f8 (irq = 4) is a 16550A
ACPI: PCI Interrupt Link [C0C3] enabled at IRQ 10
PCI: setting IRQ 10 as level-triggered
ACPI: PCI Interrupt 0000:00:1f.6[B] -> Link [C0C3] -> GSI 10 (level, low) -> IRQ 10
io scheduler noop registered
io scheduler anticipatory registered
io scheduler deadline registered
io scheduler cfq registered
RAMDISK driver initialized: 16 RAM disks of 16384K size 1024 blocksize
Uniform Multi-Platform E-IDE driver Revision: 7.00alpha2
ide: Assuming 33MHz system bus speed for PIO modes; override with idebus=xx
ICH4: IDE controller at PCI slot 0000:00:1f.1
PCI: Enabling device 0000:00:1f.1 (0005 -> 0007)
ACPI: PCI Interrupt Link [C0C4] enabled at IRQ 5
PCI: setting IRQ 5 as level-triggered
ACPI: PCI Interrupt 0000:00:1f.1[A] -> Link [C0C4] -> GSI 5 (level, low) -> IRQ 5
ICH4: chipset revision 1
ICH4: not 100% native mode: will probe irqs later
ide0: BM-DMA at 0x4c40-0x4c47, BIOS settings: hda:DMA, hdb:pio
ide1: BM-DMA at 0x4c48-0x4c4f, BIOS settings: hdc:DMA, hdd:pioProbing IDE interface ide0...
hda: TOSHIBA MK4025GAS, ATA DISK drive
ide0 at 0x1f0-0x1f7,0x3f6 on irq 14
Probing IDE interface ide1...
hdc: HL-DT-STCD-RW/DVD DRIVE GCC-4241N, ATAPI CD/DVD-ROM drive
ide1 at 0x170-0x177,0x376 on irq 15
pnp: the driver 'ide' has been registered
ide2: I/O resource 0x3EE-0x3EE not free.
ide2: ports already in use, skipping probe
Probing IDE interface ide3...
Probing IDE interface ide4...
Probing IDE interface ide5...
hda: max request size: 128KiB
hda: 78140160 sectors (40007 MB), CHS=65535/16/63, UDMA(100)
hda: cache flushes supported
hda: hda1 hda2 hda3 hda4 < hda5 hda6 >
hdc: ATAPI 24X DVD-ROM CD-R/RW drive, 2048kB Cache, DMA
Uniform CD-ROM driver Revision: 3.20
ide-floppy driver 0.99.newide
usbmon: debugs is not available
usbcore: registered new driver hiddev
usbcore: registered new driver usbhiddrivers/usb/input/hid-core.c: v2.01:USB HID core driver
mice: PS/2 mouse device common for all mice
NET: Registered protocol family 2
IP: routing cache hash table of 1024 buckets, 32Kbytes
TCP established hash table entries: 32768 (order: 6, 262144 bytes)
TCP bind hash table entries: 32768 (order: 7, 917504 bytes)
TCP: Hash tables configured (established 32768 bind 32768)
Initializing IPsec netlink socket
NET: Registered protocol family 1
NET: Registered protocol family 17
Software Suspend Core.
Software Suspend Compression Driver loading.
Software Suspend Encryption Driver loading.
Software Suspend text mode support loading.
Software Suspend userspace UI support loading.
Software Suspend Swap Writer loading.
ACPI wakeup devices:
C058 C1AD C1A3 C1A4 C0AC C0B3 C0B4 C0B5 C0E7 C136
ACPI: (supports S0 S3 S4 S4bios S5)
Freeing unused kernel memory: 216k freed
Software Suspend 2.1.9.5: Swapwriter: Signature found.
Software Suspend 2.1.9.5: Suspending enabled.
input: AT Translated Set 2 keyboard on isa0060/serio0
EXT3-fs: mounted filesystem with ordered data mode.
kjournald starting. Commit interval 5 seconds
Synaptics Touchpad, model: 1, fw: 5.9, id: 0x236eb3, caps: 0x904713/0x10008
input: SynPS/2 Synaptics TouchPad on isa0060/serio4
8139cp: 10/100 PCI Ethernet driver v1.2 (Mar 22, 2004)
ACPI: PCI Interrupt 0000:02:01.0[A] -> Link [C0C3] -> GSI 10 (level, low) -> IRQ 10
eth0: RTL-8139C+ at 0xe0828000, 00:02:3f:22:db:8c, IRQ 10
ACPI: PCI Interrupt 0000:00:1f.5[B] -> Link [C0C3] -> GSI 10 (level, low) -> IRQ 10
PCI: Setting latency timer of device 0000:00:1f.5 to 64intel8x0_measure_ac97_clock: measured 49076 usecs
intel8x0: clocking to 48000
ACPI: PCI Interrupt 0000:00:1f.6[B] -> Link [C0C3] -> GSI 10 (level, low) -> IRQ 10
PCI: Setting latency timer of device 0000:00:1f.6 to 64hw_random: RNG not detected
ACPI: PCI Interrupt Link [C0C9] enabled at IRQ 5
ACPI: PCI Interrupt 0000:00:1d.7[D] -> Link [C0C9] -> GSI 5 (level, low) -> IRQ 5
PCI: Setting latency timer of device 0000:00:1d.7 to 64ehci_hcd 0000:00:1d.7: EHCI Host Controllerehci_hcd 0000:00:1d.7: debug port 1ehci_hcd 0000:00:1d.7: new USB bus registered, assigned bus number 1ehci_hcd 0000:00:1d.7: irq 5, io mem 0xa0000000
PCI: cache line size of 32 is not supported by device 0000:00:1d.7ehci_hcd 0000:00:1d.7: USB 2.0 initialized, EHCI 1.00, driver 10 Dec 2004
hub 1-0:1.0: USB hub found
hub 1-0:1.0: 6 ports detected
USB Universal Host Controller Interface driver v2.2
ACPI: PCI Interrupt Link [C0C2] enabled at IRQ 10
ACPI: PCI Interrupt 0000:00:1d.0[A] -> Link [C0C2] -> GSI 10 (level, low) -> IRQ 10
PCI: Setting latency timer of device 0000:00:1d.0 to 64uhci_hcd 0000:00:1d.0: UHCI Host Controlleruhci_hcd 0000:00:1d.0: new USB bus registered, assigned bus number 2uhci_hcd 0000:00:1d.0: irq 10, io base 0x000048c0
hub 2-0:1.0: USB hub found
hub 2-0:1.0: 2 ports detected
ACPI: PCI Interrupt Link [C0C5] enabled at IRQ 5
ACPI: PCI Interrupt 0000:00:1d.1[B] -> Link [C0C5] -> GSI 5 (level, low) -> IRQ 5
PCI: Setting latency timer of device 0000:00:1d.1 to 64uhci_hcd 0000:00:1d.1: UHCI Host Controlleruhci_hcd 0000:00:1d.1: new USB bus registered, assigned bus number 3uhci_hcd 0000:00:1d.1: irq 5, io base 0x000048e0
hub 3-0:1.0: USB hub found
hub 3-0:1.0: 2 ports detected
ACPI: PCI Interrupt 0000:00:1d.2[C] -> Link [C0C4] -> GSI 5 (level, low) -> IRQ 5
PCI: Setting latency timer of device 0000:00:1d.2 to 64uhci_hcd 0000:00:1d.2: UHCI Host Controlleruhci_hcd 0000:00:1d.2: new USB bus registered, assigned bus number 4uhci_hcd 0000:00:1d.2: irq 5, io base 0x00004c00
hub 4-0:1.0: USB hub found
hub 4-0:1.0: 2 ports detected
Linux Kernel Card Services
options: [pci] [cardbus] [pm]
ACPI: PCI Interrupt 0000:02:04.0[A] -> Link [C0C4] -> GSI 5 (level, low) -> IRQ 5
Yenta: CardBus bridge found at 0000:02:04.0 [0e11:0860]
Yenta: Using CSCINT to route CSC interrupts to PCI
Yenta: Routing CardBus interrupts to PCI
Yenta TI: socket 0000:02:04.0, mfunc 0x001c1112, devctl 0x44
Yenta: ISA IRQ mask 0x0000, PCI irq 5
Socket status: 30000006
ieee1394: Initialized config rom entry `ip1394'
ohci1394: $Rev: 1250 $ Ben Collins <[email protected]>
ACPI: PCI Interrupt 0000:02:00.0[A] -> Link [C0C2] -> GSI 10 (level, low) -> IRQ 10
ohci1394: fw-host0: OHCI-1394 1.0 (PCI): IRQ=[10] MMIO=[90200000-902007ff] Max Packet=[1024]
ACPI: AC Adapter [C134] (on-line)
ACPI: Battery Slot [C11F] (battery absent)
ACPI: Power Button (FF) [PWRF]
ACPI: Lid Switch [C136]
ACPI: CPU0 (power states: C1[C1] C2[C2] C3[C3])
ACPI: Processor [CPU0] (supports 8 throttling states)
ACPI: Video Device [C0D0] (multi-head: yes rom: no post: no)
EXT3 FS on hda5, internal journal
kjournald starting. Commit interval 5 seconds
EXT3 FS on hda1, internal journal
EXT3-fs: mounted filesystem with ordered data mode.
Adding 977248k swap on /dev/hda2. Priority:-1 extents:1ip_tables: (C) 2000-2002 Netfilter core teamip_conntrack version 2.1 (4094 buckets, 32752 max) - 240 bytes per conntrack
cs: IO port probe 0xc00-0xcff: clean.
cs: IO port probe 0x800-0x8ff: clean.
cs: IO port probe 0x100-0x4ff: excluding 0x140-0x14f 0x200-0x20f 0x378-0x37f
cs: IO port probe 0xa00-0xaff: clean.
Bluetooth: Core ver 2.7
NET: Registered protocol family 31
Bluetooth: HCI device and connection manager initialized
Bluetooth: HCI socket layer initialized
Bluetooth: L2CAP ver 2.7
Bluetooth: L2CAP socket layer initialized
Bluetooth: RFCOMM ver 1.5
Bluetooth: RFCOMM socket layer initialized
Bluetooth: RFCOMM TTY layer initialized
Bluetooth: HIDP (Human Interface Emulation) ver 1.1
NET: Registered protocol family 23
IrCOMM protocol (Dag Brattli)
CSLIP: code copyright 1989 Regents of the University of California
PPP generic driver version 2.4.2
IrDA: Registered device irda0 (irport io=0x3E8 irq=3)drivers/net/irda/irport.c:406: spin_is_locked(drivers/net/irda/irport.c:db38c548) already locked by drivers/net/irda/irport.c/878 drivers/net/irda/irport.c:407: spin_lock(drivers/net/irda/irport.c:db38c548) already locked by drivers/net/irda/irport.c/878 drivers/net/irda/irport.c:885: spin_unlock(drivers/net/irda/irport.c:db38c548) not locked
pnp: the driver 'parport_pc' has been registered
pnp: match found with the PnP device '00:05' and the driver 'parport_pc'
parport: PnPBIOS parport detected.
parport0: PC-style at 0x378 (0x778), irq 7 [PCSPP,TRISTATE]
lp0: using parport0 (interrupt-driven).
lp0: console ready
tun: Universal TUN/TAP device driver, 1.6
tun: (C) 1999-2004 Max Krasnyansky <[email protected]>
eth0: link up, 100Mbps, full-duplex, lpa 0x45E1
ACPI: PCI Interrupt 0000:01:00.0[A] -> Link [C0C2] -> GSI 10 (level, low) -> IRQ 10
[drm] Initialized radeon 1.16.0 20050311 on minor 0:
eth0: link up, 100Mbps, full-duplex, lpa 0x45E1
Hi Pierre,
Quoted 9 lines · Pierre Ossman
PCI: Using ACPI for IRQ routing
** PCI interrupts are no longer routed automatically. If this ** causes a device to stop working, it is probably because the ** driver failed to callpci_enable_device(). As a temporary ** workaround, the "pci=routeirq" argument restores the old ** behavior. If this argument makes the device work again, ** please email the output of "lspci" to [email protected] ** so I can fix the driver.
As this shows on the 2.6.11 dmesg, and doesn't show on 2.6.12, could
be the cause of the problem.
Although 8139cp calls pci_enable_device correctly, it may be worth
to try the pci=routeirq thing and see what happens.
Cheers,
Felipe Damasio
Quoted 6 lines · Pierre Ossman
Upgrading from 2.6.11 to 2.6.12 caused my 8139cp network card to stop working. No error messages are emitted and everything seems to work (from the local computers point of view). But nothing can be recieved from the network.
Hi there!
I'm seeing the same problem with 8139cp (everithing seems fine, mii-tool works, but only seldom packets are received from the device). Last good kernel for me was 2.6.11-bk4. I tried pci=routeirq on 2.6.12, but made no difference. Here's lscpi output (on 2.6.11-bk4).
rao@poppero1:~$ lspci 0000:00:00.0 Host bridge: Intel Corp. 82855PM Processor to I/O Controller (rev 03) 0000:00:01.0 PCI bridge: Intel Corp. 82855PM Processor to AGP Controller (rev 03) 0000:00:1d.0 USB Controller: Intel Corp. 82801DB/DBL/DBM (ICH4/ICH4-L/ICH4-M) USB UHCI Controller #1 (rev 01) 0000:00:1d.1 USB Controller: Intel Corp. 82801DB/DBL/DBM (ICH4/ICH4-L/ICH4-M) USB UHCI Controller #2 (rev 01) 0000:00:1d.2 USB Controller: Intel Corp. 82801DB/DBL/DBM (ICH4/ICH4-L/ICH4-M) USB UHCI Controller #3 (rev 01) 0000:00:1d.7 USB Controller: Intel Corp. 82801DB/DBM (ICH4/ICH4-M) USB 2.0 EHCI Controller (rev 01) 0000:00:1e.0 PCI bridge: Intel Corp. 82801 PCI Bridge (rev 81) 0000:00:1f.0 ISA bridge: Intel Corp. 82801DBM LPC Interface Controller (rev 01) 0000:00:1f.1 IDE interface: Intel Corp. 82801DBM (ICH4) Ultra ATA Storage Controller (rev 01) 0000:00:1f.3 SMBus: Intel Corp. 82801DB/DBL/DBM (ICH4/ICH4-L/ICH4-M) SMBus Controller (rev 01) 0000:00:1f.5 Multimedia audio controller: Intel Corp. 82801DB/DBL/DBM (ICH4/ICH4-L/ICH4-M) AC'97 Audio Controller (rev 01) 0000:00:1f.6 Modem: Intel Corp. 82801DB/DBL/DBM (ICH4/ICH4-L/ICH4-M) AC'97 Modem Controller (rev 01) 0000:01:00.0 VGA compatible controller: ATI Technologies Inc Radeon R250 Lf [Radeon Mobility 9000 M9] (rev 01) 0000:02:00.0 FireWire (IEEE 1394): VIA Technologies, Inc. IEEE 1394 Host Controller (rev 80) 0000:02:01.0 Ethernet controller: Realtek Semiconductor Co., Ltd. RTL-8139/8139C/8139C+ (rev 20) 0000:02:02.0 Network controller: Intel Corp. PRO/Wireless 2200BG (rev 05) 0000:02:04.0 CardBus bridge: ENE Technology Inc CB1410 Cardbus Controller (rev 01) rao@poppero1:~$
Attached dmesg for a working (2.6.11bk4) and a non working kernel
Kind regards,
Roberto Oppedisano
PS: attached dmesg shows a tainted kernel; the problem is exactly the same also with a vanilla kernel (whitout ever loading slamr module).
Quoted 6 lines · Pierre Ossman
Quoted 5 lines · Pierre Ossman
Quoted 4 lines
Upgrading from 2.6.11 to 2.6.12 caused my 8139cp network card to stop working. No error messages are emitted and everything seems to work (from the local computers point of view). But nothing can be recieved from the network.
Quoted 7 lines
dmesg:s included. But they don't really differ more than some cosmetic changes in the output strings.
The problem is I can't find anything that differs. 2.6.12 behaves more or less like someone cut of the rx pins in the connector. ifconfig doesn't report any errors so it isn't a problem with packets getting dropped. tcpdump only shows the outgoing packets.
Your 2.6.11 dmesg mentions the VIA IRQ fixup, but the 2.6.12 one doesn't. I bet something's broken there.
Can you try the attached debugging patch? And please collect the output of lspci, too.
drivers/pci/quirks.c +1 -1
@@ -510,7 +510,7 @@pci_write_config_byte (dev,PCI_INTERRUPT_LINE , new_irq); } } -DECLARE_PCI_FIXUP_ENABLE (PCI_VENDOR_ID_VIA ,PCI_ANY_ID , quirk_via_irq); +DECLARE_PCI_FIXUP_ENABLE (PCI_ANY_ID ,PCI_ANY_ID , quirk_via_irq);/* * PIIX3 USB: We have to disable USB interrupts that are
Quoted 7 lines · Roberto Oppedisano
I'm seeing the same problem with 8139cp (everithing seems fine, mii-tool works, but only seldom packets are received from the device). Last good kernel for me was 2.6.11-bk4. I tried pci=routeirq on 2.6.12, but made no difference. Here's lscpi output (on 2.6.11-bk4).
0000:02:00.0 FireWire (IEEE 1394): VIA Technologies, Inc. IEEE 1394 Host Controller (rev 80) 0000:02:01.0 Ethernet controller: Realtek Semiconductor Co., Ltd. RTL-8139/8139C/8139C+ (rev 20)
You have a VIA device with dev/function == 0, so 2.6.11 will do the VIA IRQ fixup for all devices. 2.6.12 will do it only for VIA devices. Can you try the attached patch for debugging purposes?
drivers/pci/quirks.c +1 -1
@@ -510,7 +510,7 @@pci_write_config_byte (dev,PCI_INTERRUPT_LINE , new_irq); } } -DECLARE_PCI_FIXUP_ENABLE (PCI_VENDOR_ID_VIA ,PCI_ANY_ID , quirk_via_irq); +DECLARE_PCI_FIXUP_ENABLE (PCI_ANY_ID ,PCI_ANY_ID , quirk_via_irq);/* * PIIX3 USB: We have to disable USB interrupts that are
Note: this is not with 8139cp, but with 8139too, particularly 8139b
in 2.6.12, 2.6.12-mm1 and 2.6.12-RT-V0.7.49-01
With preempt enabled/disabled/rt/voluntary...
With mmio and pio in 8139too , with old rx reset and combinations of enabled and disabled
Even changed ethernet cables ... nothing stopped my Tx problems.
This is all occurring on a box that until yesterday, had an uptime of over 410 days on 2.6.0-mm1, so it's not the hardware, also, reverting to that kernel remedied the problem.
Here is a snip from dmesg
NETDEV WATCHDOG: eth0: transmit timed out eth0: Transmit timeout, status 0c 0055 c07f media 00. eth0: Tx queue start entry 78 dirty entry 74. eth0: Tx descriptor 0 is 0008a03c. eth0: Tx descriptor 1 is 0008a03c. eth0: Tx descriptor 2 is 0008a03c. (queue head) eth0: Tx descriptor 3 is 0008a03c. eth0: link up, 100Mbps, full-duplex, lpa 0x45E1
I'm not sure if this is exactly related to the thread, but it seemed too much of a coincidence to think that it's not.
The symptoms of the problem is short bursts of traffic with 30 second or so pauses of absolutely no response, repeating. The higher the bandwidth the worse the situation, but it occurs regardless.
No other errors are reported or seen on the box except this Tx problem. I'm tempted to go ahead and try 2.6.11, but haven't yet.
Quoted 1 line · Ed Sweetman
I'm tempted to go ahead and try 2.6.11, but haven't yet.
Please do. If 2.6.11 works and you have any VIA devices, please also try the 2.6.12 patch from earlier in the thread and see whether that helps.
Thanks!
Quoted 9 lines · Bjorn Helgaas
Quoted 4 lines
0000:02:00.0 FireWire (IEEE 1394): VIA Technologies, Inc. IEEE 1394 Host Controller (rev 80) 0000:02:01.0 Ethernet controller: Realtek Semiconductor Co., Ltd. RTL-8139/8139C/8139C+ (rev 20)
You have a VIA device with dev/function == 0, so 2.6.11 will do the VIA IRQ fixup for all devices. 2.6.12 will do it only for VIA devices. Can you try the attached patch for debugging purposes?
Hi!
I applied your patch to a vanilla 2.6.12.1 kernel and the card is still not working.
Attached dmesg with and without pci=routeirq.
Kind regards,
Roberto Oppedisano
Quoted 13 lines · Bjorn Helgaas
Quoted 3 lines · Ed Sweetman
I'm tempted to go ahead and try 2.6.11, but haven't yet.
Please do. If 2.6.11 works and you have any VIA devices, please also try the 2.6.12 patch from earlier in the thread and see whether that helps.
it's a via motherboard, so yes, i'll be trying that patch if 2.6.11 does work. It seems to make sense to try the patch first, but i had already removed the 2.6.12 trees i had compiled before that patch was posted. It takes a while for this computer to compile the kernels so i'll report back tonight ... in any case, if the patch doesn't work, i'll move up the rc for 2.6.12 until the problem occurs, figure out what happened with the 8139 drivers in that patchset and hopefully see a fix. But first, a concert to goto.
has anyone had their problem fixed by the patch to 2.6.12?
Quoted 8 lines · Bjorn Helgaas
Your 2.6.11 dmesg mentions the VIA IRQ fixup, but the 2.6.12 one doesn't. I bet something's broken there.
Can you try the attached debugging patch? And please collect the output of lspci, too.
I tried the attached patch and it had no effect. I also tried porting the 2.6.11 way of handling the VIA quirk but it didn't have any effect. I'll try a more complete port tomorrow (it was a bit of a hack this time).
Rgds
Pierre
lspci:
00:00.0 Host bridge: Intel Corporation 82855PM Processor to I/O Controller (rev 03)
00:01.0 PCI bridge: Intel Corporation 82855PM Processor to AGP Controller (rev 03)
00:1d.0 USB Controller: Intel Corporation 82801DB/DBL/DBM (ICH4/ICH4-L/ICH4-M) USB UHCI Controller #1 (rev 01)
00:1d.1 USB Controller: Intel Corporation 82801DB/DBL/DBM (ICH4/ICH4-L/ICH4-M) USB UHCI Controller #2 (rev 01)
00:1d.2 USB Controller: Intel Corporation 82801DB/DBL/DBM (ICH4/ICH4-L/ICH4-M) USB UHCI Controller #3 (rev 01)
00:1d.7 USB Controller: Intel Corporation 82801DB/DBM (ICH4/ICH4-M) USB2 EHCI Controller (rev 01)
00:1e.0 PCI bridge: Intel Corporation 82801 Mobile PCI Bridge (rev 81) 00:1f.0 ISA bridge: Intel Corporation 82801DBM (ICH4-M) LPC Interface Bridge (rev 01)
00:1f.1 IDE interface: Intel Corporation 82801DBM (ICH4-M) IDE Controller (rev 01)
00:1f.3 SMBus: Intel Corporation 82801DB/DBL/DBM (ICH4/ICH4-L/ICH4-M) SMBus Controller (rev 01)
00:1f.5 Multimedia audio controller: Intel Corporation 82801DB/DBL/DBM (ICH4/ICH4-L/ICH4-M) AC'97 Audio Controller (rev 01)
00:1f.6 Modem: Intel Corporation 82801DB/DBL/DBM (ICH4/ICH4-L/ICH4-M) AC'97 Modem Controller (rev 01)
01:00.0 VGA compatible controller: ATI Technologies Inc Radeon R250 Lf [FireGL 9000] (rev 01)
02:00.0 FireWire (IEEE 1394): VIA Technologies, Inc. IEEE 1394 Host Controller (rev 80)
02:01.0 Ethernet controller: Realtek Semiconductor Co., Ltd. RTL-8139/8139C/8139C+ (rev 20)
02:02.0 Network controller: Intel Corporation PRO/Wireless 2200BG (rev 05) 02:04.0 CardBus bridge: ENE Technology Inc CB1410 Cardbus Controller (rev 01)
Quoted 14 lines · Pierre Ossman
Quoted 9 lines · Bjorn Helgaas
Your 2.6.11 dmesg mentions the VIA IRQ fixup, but the 2.6.12 one doesn't. I bet something's broken there.
Can you try the attached debugging patch? And please collect the output of lspci, too.
Quoted 6 lines
I tried the attached patch and it had no effect. I also tried porting the 2.6.11 way of handling the VIA quirk but it didn't have any effect. I'll try a more complete port tomorrow (it was a bit of a hack this time).
2.6.11-mm4 doesn't work. So i'm guessing 2.6.11 wont work either which may be why backporting it's via fixes didn't do anything. I'm gonna try vanilla and if that by some crazy chance works, then it'll be fairly easy to see what change did it since mm has a nice Changelog.
this is in the changefile to 2.6.11. This seems to be the real culprit. I guarantee you if this patch is reverted, there will be no problems.
<[email protected]>
[PATCH] r8169: hint for Tx flow control
return 1 in start_xmit() when the required descriptors are not available and wait for more room.
Quoted 29 lines · Ed Sweetman
Quoted 14 lines · Pierre Ossman
Quoted 8 lines · Bjorn Helgaas
Your 2.6.11 dmesg mentions the VIA IRQ fixup, but the 2.6.12 one doesn't. I bet something's broken there.
Can you try the attached debugging patch? And please collect the output of lspci, too.
Quoted 6 lines
I tried the attached patch and it had no effect. I also tried porting the 2.6.11 way of handling the VIA quirk but it didn't have any effect. I'll try a more complete port tomorrow (it was a bit of a hack this time).
2.6.11-mm4 doesn't work. So i'm guessing 2.6.11 wont work either which may be why backporting it's via fixes didn't do anything. I'm gonna try vanilla and if that by some crazy chance works, then it'll be fairly easy to see what change did it since mm has a nice Changelog. -
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [email protected]
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
Sorry, i'm retarded, i pasted the wrong changelog line.
<[email protected]>
[8139TOO]: Use rtnl_lock_interruptible()
The 8139too thread needs to use rtnl_lock_interruptible so it can avoid doing the actual work once it's been kill_proc()ed on module removal time.
Based on debugging and an earlier patch that adds a driver-private semaphore from Herbert Xu.
This seems to be the only patch that contains a change to the 8139too code between working and non-working code.
nothing in mm's patchset seems to have anything to cause these problems.
Quoted 46 lines · Ed Sweetman
this is in the changefile to 2.6.11. This seems to be the real culprit. I guarantee you if this patch is reverted, there will be no problems.
<[email protected]>
[PATCH] r8169: hint for Tx flow controlreturn 1 in
start_xmit()when the required descriptors are not
available
and wait for more room.Signed-off-by Francois Romieu <[email protected]>Quoted 30 lines · Ed Sweetman
Quoted 15 lines · Pierre Ossman
Quoted 8 lines · Bjorn Helgaas
Your 2.6.11 dmesg mentions the VIA IRQ fixup, but the 2.6.12 one doesn't. I bet something's broken there.
Can you try the attached debugging patch? And please collect the output of lspci, too.
Quoted 6 lines
I tried the attached patch and it had no effect. I also tried porting the 2.6.11 way of handling the VIA quirk but it didn't have any effect. I'll try a more complete port tomorrow (it was a bit of a hack this time).
2.6.11-mm4 doesn't work. So i'm guessing 2.6.11 wont work either which may be why backporting it's via fixes didn't do anything. I'm gonna try vanilla and if that by some crazy chance works, then it'll be fairly easy to see what change did it since mm has a nice Changelog. -
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [email protected]
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
Quoted 9 lines · Ed Sweetman
Sorry, i'm retarded, i pasted the wrong changelog line.
<[email protected]>
[8139TOO]: Usertnl_lock_interruptible()The 8139too thread needs to use
rtnl_lock_interruptibleso it can avoid doing the actual work once it's been kill_proc()ed on module removal time.
Quoted 6 lines
Based on debugging and an earlier patch that adds a driver-private semaphore from Herbert Xu.
Signed-off-by David S. Miller <[email protected]>This seems to be the only patch that contains a change to the 8139too code between working and non-working code.
Please verify that reverting this patch actually fixed your problem.
$subject talks about 8139cp, but you list a change to 8139too, which are two different drivers.
It's often wrong to focus on the driver. If a driver suddenly stops working, that may indicate a problem in the interrupt subsystem, etc.
Jeff
Quoted 4 lines · Ed Sweetman
2.6.11-mm4 doesn't work. So i'm guessing 2.6.11 wont work either which may be why backporting it's via fixes didn't do anything. I'm gonna try vanilla and if that by some crazy chance works, then it'll be fairly easy to see what change did it since mm has a nice Changelog.
2.6.11 works fine here so if you're having problems with it I'd say we're experiencing two different bugs.
Rgds
Pierre
Quoted 12 lines · Pierre Ossman
Quoted 6 lines · Ed Sweetman
2.6.11-mm4 doesn't work. So i'm guessing 2.6.11 wont work either which may be why backporting it's via fixes didn't do anything. I'm gonna try vanilla and if that by some crazy chance works, then it'll be fairly easy to see what change did it since mm has a nice Changelog.
Quoted 7 lines
2.6.11 works fine here so if you're having problems with it I'd say we're experiencing two different bugs.
Rgds
Pierre
It seems that whatever is causing the bug i'm seeing was a change that involved the network driver/interrupt subsystem and not actually the 8139too driver, this was done at around 2.6.3-2.6.4. A NAPI patch that was introduced at that time basically reverted the interrupt function and removed the poll functions from the driver (via not enabling napi in Kconfig). I have patched 2.6.12.1 with the NAPI patch and it works. Now i just have a problem with messages about "Badness in __kfree_skb at net/core/skbuff.c:290" coming from the changes i made in the 8139too driver flooding my logs. (very bad but also helpful)
That narrows it down, but i was unable to clean up the kfree errors.
Hmm... it seems that TPM has something to do with the bug. Not sure why though, can't see anything TPM related in dmesg. If I disable the TPM parts in kconfig then the network works just fine.
I'm going to do a test of 2.6.12-rc1 through rc6 today to see where the problem appears.
Rgds
Pierre
Quoted 7 lines · Pierre Ossman
Hmm... it seems that TPM has something to do with the bug. Not sure why though, can't see anything TPM related in dmesg. If I disable the TPM parts in kconfig then the network works just fine.
I'm going to do a test of 2.6.12-rc1 through rc6 today to see where the problem appears.
Confirmed this behaviour. The problem appears in rc1 (where the TPM is added). Unloading the module doesn't help, once it has been present the system needs a reboot for the network card to function properly.
I don't really see how the TPM can screw things up for the network card but I'm guessing it breaks something in the chipset (the TPM module gets loaded for the LPC bridge).
(added TPM maintainer and list as cc)
Rgds
Pierre
I believe that the reason that unloading the module does not help is because the module_exit is calling pci_disable in the tpm_remove function. I'll generate a patch to remove this.
Additionally this version of the driver was doing a bunch of stuff to the LPC bus that I have since found not to be necessary and removed in patches that have been applied to the mm tree and were pushed to mainline this week. Can anyone verify if this is still happening with the -mm patch?
Regards,
Kylie
Quoted 22 lines · Pierre Ossman
Quoted 7 lines · Pierre Ossman
Hmm... it seems that TPM has something to do with the bug. Not sure why though, can't see anything TPM related in dmesg. If I disable the TPM parts in kconfig then the network works just fine.
I'm going to do a test of 2.6.12-rc1 through rc6 today to see where the problem appears.
Confirmed this behaviour. The problem appears in rc1 (where the TPM is added). Unloading the module doesn't help, once it has been present the system needs a reboot for the network card to function properly.
I don't really see how the TPM can screw things up for the network card but I'm guessing it breaks something in the chipset (the TPM module gets loaded for the LPC bridge).
(added TPM maintainer and list as cc)
Rgds
Pierre
Quoted 4 lines · Kylene Jo Hall
I believe that the reason that unloading the module does not help is because the
module_exitis callingpci_disablein thetpm_removefunction. I'll generate a patch to remove this.
Quoted 8 lines
Additionally this version of the driver was doing a bunch of stuff to the LPC bus that I have since found not to be necessary and removed in patches that have been applied to the mm tree and were pushed to mainline this week. Can anyone verify if this is still happening with the -mm patch?
You wouldn't happen to have just your patches available?
Rgds
Pierre
Quoted 2 lines
You wouldn't happen to have just your patches available?
Here is the tpm portion of -mm patch
drivers/char/tpm/tpm_atmel.c +44 -19
@@ -22,17 +22,23 @@#include "tpm.h" /* Atmel definitions */ -#define TPM_ATML_BASE 0x400 +enum tpm_atmel_addr { +TPM_ATMEL_BASE_ADDR_LO =0x08 , +TPM_ATMEL_BASE_ADDR_HI =0x09 +};/* write status bits */ -#define ATML_STATUS_ABORT 0x01 -#define ATML_STATUS_LASTBYTE 0x04 - +enum tpm_atmel_write_status { +ATML_STATUS_ABORT =0x01 , +ATML_STATUS_LASTBYTE =0x04 +};/* read status bits */ -#define ATML_STATUS_BUSY 0x01 -#define ATML_STATUS_DATA_AVAIL 0x02 -#define ATML_STATUS_REWRITE 0x04 - +enum tpm_atmel_read_status { +ATML_STATUS_BUSY =0x01 , +ATML_STATUS_DATA_AVAIL =0x02 , +ATML_STATUS_REWRITE =0x04 , +ATML_STATUS_READY =0x08 +};static int tpm_atml_recv (struct tpm_chip *chip,u8 * buf,size_t count) {
@@ -121,13 +127,29 @@ static struct file_operations atmel_ops .release = tpm_release, }; +static DEVICE_ATTR(pubek, S_IRUGO, tpm_show_pubek, NULL); +static DEVICE_ATTR(pcrs, S_IRUGO, tpm_show_pcrs, NULL); +static DEVICE_ATTR(caps, S_IRUGO, tpm_show_caps, NULL); +static DEVICE_ATTR(cancel, S_IWUSR |S_IWGRP, NULL, tpm_store_cancel); + +static struct attribute * atmel_attrs[] = { + &dev_attr_pubek.attr, + &dev_attr_pcrs.attr, + &dev_attr_caps.attr, + &dev_attr_cancel.attr, +0 , +}; + +static struct attribute_group atmel_attr_grp = { .attrs = atmel_attrs }; +static struct tpm_vendor_specific tpm_atmel = { .recv = tpm_atml_recv, .send = tpm_atml_send, .cancel = tpm_atml_cancel, .req_complete_mask =ATML_STATUS_BUSY |ATML_STATUS_DATA_AVAIL , .req_complete_val =ATML_STATUS_DATA_AVAIL , - .base =TPM_ATML_BASE , + .req_canceled =ATML_STATUS_READY , + .attr_group = &atmel_attr_grp, .miscdev = { .fops = &atmel_ops, }, };
@@ -136,27 +158,29 @@ static int __devinit tpm_atml_init(struc {u8 version[4 ];int rc =0 ; +int lo, hi;if (pci_enable_device (pci_dev))return -EIO ; -if (tpm_lpc_bus_init (pci_dev,TPM_ATML_BASE )) { - rc = -ENODEV ; - goto out_err; - } + lo =tpm_read_index (TPM_ADDR ,TPM_ATMEL_BASE_ADDR_LO ); + hi =tpm_read_index (TPM_ADDR ,TPM_ATMEL_BASE_ADDR_HI ); + + tpm_atmel.base = (hi<<8 )|lo; +dev_dbg ( &pci_dev->dev,"Operating with base: 0x%x\n" , tpm_atmel.base);/* verify that it is an Atmel part */ -if (tpm_read_index (4 ) !='A' ||tpm_read_index (5 ) !='T' - ||tpm_read_index (6 ) !='M' ||tpm_read_index (7 ) !='L' ) { +if (tpm_read_index (TPM_ADDR ,4 ) !='A' ||tpm_read_index (TPM_ADDR ,5 ) !='T' + ||tpm_read_index (TPM_ADDR ,6 ) !='M' ||tpm_read_index (TPM_ADDR ,7 ) !='L' ) { rc = -ENODEV ; goto out_err; }/* query chip for its version number */ -if ((version[0 ] =tpm_read_index (0x00 )) !=0xFF ) { - version[1 ] =tpm_read_index (0x01 ); - version[2 ] =tpm_read_index (0x02 ); - version[3 ] =tpm_read_index (0x03 ); +if ((version[0 ] =tpm_read_index (TPM_ADDR ,0x00 )) !=0xFF ) { + version[1 ] =tpm_read_index (TPM_ADDR ,0x01 ); + version[2 ] =tpm_read_index (TPM_ADDR ,0x02 ); + version[3 ] =tpm_read_index (TPM_ADDR ,0x03 ); }else {dev_info (&pci_dev->dev,"version query failed\n" ); rc = -ENODEV ;
@@ -183,6 +207,7 @@ static struct pci_device_id tpm_pci_tbl[ {PCI_DEVICE(PCI_VENDOR_ID_INTEL, PCI_DEVICE_ID_INTEL_82801DB_12)}, {PCI_DEVICE(PCI_VENDOR_ID_INTEL, PCI_DEVICE_ID_INTEL_82801EB_0)}, {PCI_DEVICE(PCI_VENDOR_ID_AMD, PCI_DEVICE_ID_AMD_8111_LPC)}, + {PCI_DEVICE(PCI_VENDOR_ID_SERVERWORKS, PCI_DEVICE_ID_SERVERWORKS_CSB6LPC)}, {0,} };
drivers/char/tpm/tpm.c +137 -223
610 lines not on this page · raw message
drivers/char/tpm/tpm.h +24 -14
@@ -25,23 +25,38 @@#include <linux/fs.h> #include <linux/miscdevice.h> -#define TPM_TIMEOUT msecs_to_jiffies(5) +enum tpm_timeout { +TPM_TIMEOUT =5 ,/* msecs */ +};/* TPM addresses */ -#define TPM_ADDR 0x4E -#define TPM_DATA 0x4F +enum tpm_addr { +TPM_SUPERIO_ADDR =0x2E , +TPM_ADDR =0x4E , +}; + +extern ssize_t tpm_show_pubek (struct device *,struct device_attribute *attr, +char *); +extern ssize_t tpm_show_pcrs (struct device *,struct device_attribute *attr, +char *); +extern ssize_t tpm_show_caps (struct device *,struct device_attribute *attr, +char *); +extern ssize_t tpm_store_cancel (struct device *,struct device_attribute *attr, +const char *,size_t );struct tpm_chip ;struct tpm_vendor_specific {u8 req_complete_mask;u8 req_complete_val; +u8 req_canceled;u16 base;/* TPM base address */ int (*recv) (struct tpm_chip *,u8 *,size_t );int (*send) (struct tpm_chip *,u8 *,size_t );void (*cancel) (struct tpm_chip *);struct miscdevice miscdev; +struct attribute_group *attr_group; };struct tpm_chip {
@@ -58,29 +73,24 @@ struct tpm_chip {struct timer_list user_read_timer;/* user needs to claim result */ struct semaphore tpm_mutex;/* tpm is processing */ -struct timer_list device_timer;/* tpm is processing */ -struct semaphore timer_manipulation_mutex;struct tpm_vendor_specific *vendor;struct list_head list; }; -static inline int tpm_read_index (int index) +static inline int tpm_read_index (int base,int index) { -outb (index,TPM_ADDR ); -return inb (TPM_DATA ) &0xFF ; +outb (index, base); +return inb (base+1 ) &0xFF ; } -static inline void tpm_write_index (int index,int value) +static inline void tpm_write_index (int base,int index,int value) { -outb (index,TPM_ADDR ); -outb (value &0xFF ,TPM_DATA ); +outb (index, base); +outb (value &0xFF , base+1 ); } -extern void tpm_time_expired (unsigned long ); -extern int tpm_lpc_bus_init (struct pci_dev *,u16 ); -extern int tpm_register_hardware (struct pci_dev *,struct tpm_vendor_specific *);extern int tpm_open (struct inode *,struct file *);
drivers/char/tpm/tpm_nsc.c +100 -101
302 lines not on this page · raw message
include/linux/pci_ids.h +1 -0
@@ -1567,6 +1571,7 @@#define PCI_DEVICE_ID_SERVERWORKS_OSB4USB 0x0220#define PCI_DEVICE_ID_SERVERWORKS_CSB5USB PCI_DEVICE_ID_SERVERWORKS_OSB4USB#define PCI_DEVICE_ID_SERVERWORKS_CSB6USB 0x0221 +#define PCI_DEVICE_ID_SERVERWORKS_CSB6LPC 0x0227#define PCI_DEVICE_ID_SERVERWORKS_GCLE 0x0225#define PCI_DEVICE_ID_SERVERWORKS_GCLE2 0x0227#define PCI_DEVICE_ID_SERVERWORKS_CSB5ISA 0x0230
Quoted 8 lines · Kylene Jo Hall
Quoted 3 lines
You wouldn't happen to have just your patches available?
Here is the tpm portion of -mm patch
Thanks. I've tried the patch and everthing seems to work fine now. :)
(btw. does no output in dmesg mean that no TPM chip was found? it seems to have found a pci id it likes atleast.)
Rgds
Pierre
Quoted 4 lines
(btw. does no output in dmesg mean that no TPM chip was found? it seems to have found a pci id it likes atleast.)
True I think if a chip is found there should be info in dmesg. Are you loading tpm_atmel or tpm_nsc? You can look at /proc/misc or see if /sys/class/misc/tpm0 exists.
Do you know if your machine has a TPM? Is it activated in BIOS?
Thanks,
Kylie
Quoted 3 lines
Rgds
Pierre
Quoted 4 lines · * Kylene Jo Hall ([email protected]) wrote:
Quoted 2 lines
You wouldn't happen to have just your patches available?
Here is the tpm portion of -mm patch
Can you narrow this down to a fix that's reasonable for -stable?
thanks,
-chris
Re: 2.6.12 breaks 8139cp [PATCH 1 of 2]
Quoted 7 lines · Chris Wright
Quoted 4 lines · * Kylene Jo Hall ([email protected]) wrote:
Quoted 2 lines
You wouldn't happen to have just your patches available?
Here is the tpm portion of -mm patch
Can you narrow this down to a fix that's reasonable for -stable?
I'll be sending two patches to fix this problem. The first one just changes a bunch of #define's to named emums. The second is the real fix. This was the easiest way for me, let me know if this is not ok.
---
drivers/char/tpm/tpm_atmel.c +13 -8
@@ -22,17 +22,22 @@#include "tpm.h" /* Atmel definitions */ -#define TPM_ATML_BASE 0x400 +enum tpm_atmel_addr { +TPM_ATML_BASE =0x400 +};/* write status bits */ -#define ATML_STATUS_ABORT 0x01 -#define ATML_STATUS_LASTBYTE 0x04 - +enum tpm_atmel_write_status { +ATML_STATUS_ABORT =0x01 , +ATML_STATUS_LASTBYTE =0x04 +};/* read status bits */ -#define ATML_STATUS_BUSY 0x01 -#define ATML_STATUS_DATA_AVAIL 0x02 -#define ATML_STATUS_REWRITE 0x04 - +enum tpm_atmel_read_status { +ATML_STATUS_BUSY =0x01 , +ATML_STATUS_DATA_AVAIL =0x02 , +ATML_STATUS_REWRITE =0x04 , +ATML_STATUS_READY =0x08 +};static int tpm_atml_recv (struct tpm_chip *chip,u8 * buf,size_t count) {
drivers/char/tpm/tpm.c +30 -13
63 lines not on this page · raw message
return 0;
}
drivers/char/tpm/tpm_nsc.c +32 -24
66 lines not on this page · raw message
+};
drivers/char/tpm/tpm.h 2005-04-15 16:25:18.000000000 -0500 renamed from drivers/char/tpm/tpm.h 2005-04-15 15:13:29.000000000 -0500 +8 -3
@@ -25,11 +25,16 @@ #include <linux/fs.h> #include <linux/miscdevice.h> -#define TPM_TIMEOUT msecs_to_jiffies(5) +enum tpm_timeout { + TPM_TIMEOUT = 5, /* msecs */ +}; /* TPM addresses */ -#define TPM_ADDR 0x4E -#define TPM_DATA 0x4F +enum tpm_addr { + TPM_ADDR = 0x4E, + TPM_DATA = 0x4F +}; + struct tpm_chip;
drivers/chat/tpm/tpm.c renamed from drivers/char/tpm/tpm.c +5 -4
@@ -566,7 +566,7 @@ void __devexit tpm_remove(struct pci_devpci_disable_device (pci_dev); - dev_mask[chip->dev_num /32 ] &= !(1 << (chip->dev_num %32 )); + dev_mask[chip->dev_num /TPM_NUM_MASK_ENTRIES ] &= !(1 << (chip->dev_num %TPM_NUM_MASK_ENTRIES ));kfree (chip);
@@ -646,10 +646,11 @@ int tpm_register_hardware(struct pci_dev chip->dev_num =-1 ; -for (i =0 ; i <32 ; i++) -for (j =0 ; j <8 ; j++) +for (i =0 ; i <TPM_NUM_MASK_ENTRIES ; i++) +for (j =0 ; j <8 *sizeof (int ); j++)if ((dev_mask[i] & (1 << j)) ==0 ) { - chip->dev_num = i *32 + j; + chip->dev_num = + i *TPM_NUM_MASK_ENTRIES + j; dev_mask[i] |=1 << j; goto dev_num_search_complete; }
Re: 2.6.12 breaks 8139cp [PATCH 2 of 2]
In reply to Chris WrightQuoted 8 lines · Chris Wright
Quoted 4 lines · * Kylene Jo Hall ([email protected]) wrote:
Quoted 2 lines
You wouldn't happen to have just your patches available?
Here is the tpm portion of -mm patch
Can you narrow this down to a fix that's reasonable for -stable?
I'll be sending two patches to fix this problem. The first one just changes a bunch of #define's to named emums. The second is the real fix. This was the easiest way for me, let me know if this is not ok.
---
drivers/char/tpm/tpm.c | 90 ------------------------------------------- drivers/char/tpm/tpm.h | 2 drivers/char/tpm/tpm_atmel.c | 16 ++++--- drivers/char/tpm/tpm_nsc.c | 22 ++++++---- 4 files changed, 22 insertions(+), 108 deletions(-)
drivers/char/tpm/tpm_atmel.c renamed from drivers/char/tpm/tpm_atmel.c~tpm-replace-odd-LPC-init-function +9 -7
@@ -22,8 +22,9 @@#include "tpm.h" /* Atmel definitions */ -enum tpm_atmel_addr { -TPM_ATML_BASE =0x400 +enum tpm_atmel_addr { +TPM_ATMEL_BASE_ADDR_LO =0x08 , +TPM_ATMEL_BASE_ADDR_HI =0x09 };/* write status bits */
@@ -148,5 +149,4 @@ static struct tpm_vendor_specific tpm_at .req_complete_mask = ATML_STATUS_BUSY | ATML_STATUS_DATA_AVAIL, .req_complete_val = ATML_STATUS_DATA_AVAIL, - .base = TPM_ATML_BASE, .miscdev = { .fops = &atmel_ops, }, };
@@ -158,14 +158,16 @@ static int __devinit tpm_atml_init(struc {u8 version[4 ];int rc =0 ; +int lo, hi;if (pci_enable_device (pci_dev))return -EIO ; -if (tpm_lpc_bus_init (pci_dev,TPM_ATML_BASE )) { - rc = -ENODEV ; - goto out_err; - } + lo =tpm_read_index (TPM_ATMEL_BASE_ADDR_LO ); + hi =tpm_read_index (TPM_ATMEL_BASE_ADDR_HI ); + + tpm_atmel.base = (hi<<8 )|lo; +dev_dbg ( &pci_dev->dev,"Operating with base: 0x%x\n" , tpm_atmel.base);/* verify that it is an Atmel part */ if (tpm_read_index(4) != 'A' || tpm_read_index(5) != 'T'
drivers/char/tpm/tpm.c renamed from drivers/char/tpm/tpm.c~tpm-replace-odd-LPC-init-function +0 -90
108 lines not on this page · raw message
drivers/char/tpm/tpm.h renamed from drivers/char/tpm/tpm.h~tpm-replace-odd-LPC-init-function +0 -2
@@ -91,9 +91,7 @@ static inline void tpm_write_index(int ioutb (value &0xFF ,TPM_DATA ); }extern void tpm_time_expired (unsigned long ); -extern int tpm_lpc_bus_init (struct pci_dev *,u16 ); -extern int tpm_register_hardware (struct pci_dev *,struct tpm_vendor_specific *);extern int tpm_open (struct inode *,struct file *);
drivers/char/tpm/tpm_nsc.c renamed from drivers/char/tpm/tpm_nsc.c~tpm-replace-odd-LPC-init-function +13 -9
@@ -22,9 +22,13 @@#include "tpm.h" /* National definitions */ -enum tpm_nsc_addr { +enum tpm_nsc_addr {TPM_NSC_BASE =0x360 , -TPM_NSC_IRQ =0x07 +TPM_NSC_IRQ =0x07 , +TPM_NSC_BASE0_HI =0x60 , +TPM_NSC_BASE0_LO =0x61 , +TPM_NSC_BASE1_HI =0x62 , +TPM_NSC_BASE1_LO =0x63 };enum tpm_nsc_index {
@@ -44,7 +48,7 @@ enum tpm_nsc_status_loc { };/* status bits */ -enum tpm_nsc_status { +enum tpm_nsc_status {NSC_STATUS_OBF =0x01 ,/* output buffer full */ NSC_STATUS_IBF =0x02 ,/* input buffer full */ NSC_STATUS_F0 =0x04 ,/* F0 */
@@ -246,5 +250,4 @@ static struct tpm_vendor_specific tpm_ns .req_complete_mask = NSC_STATUS_OBF, .req_complete_val = NSC_STATUS_OBF, - .base = TPM_NSC_BASE, .miscdev = { .fops = &nsc_ops, }, };
@@ -255,15 +258,16 @@ static int __devinit tpm_nsc_init(struct const struct pci_device_id *pci_id) {int rc =0 ; +int lo, hi; + + hi =tpm_read_index (TPM_NSC_BASE0_HI ); + lo =tpm_read_index (TPM_NSC_BASE0_LO ); + + tpm_nsc.base = (hi<<8 ) | lo;if (pci_enable_device (pci_dev))return -EIO ; -if (tpm_lpc_bus_init (pci_dev,TPM_NSC_BASE )) { - rc = -ENODEV ; - goto out_err; - } -/* verify that it is a National part (SID) */ if (tpm_read_index (NSC_SID_INDEX ) !=0xEF ) { rc = -ENODEV ;
_
Re: 2.6.12 breaks 8139cp [PATCH 1 of 2]
In reply to Kylene Jo HallQuoted 5 lines · * Kylene Jo Hall ([email protected]) wrote:
Quoted 4 lines · Chris Wright
Quoted 3 lines · * Kylene Jo Hall ([email protected]) wrote:
Quoted 2 lines
You wouldn't happen to have just your patches available?
Quoted 7 lines
Quoted 3 lines
Quoted 1 line
Here is the tpm portion of -mm patch
Can you narrow this down to a fix that's reasonable for -stable?
I'll be sending two patches to fix this problem. The first one just changes a bunch of #define's to named emums. The second is the real fix. This was the easiest way for me, let me know if this is not ok.
Just the real fix is the best for -stable, please.
thanks,
-chris
Re: 2.6.12 breaks 8139cp [PATCH 1 of 2]
Quoted 9 lines
Quoted 7 lines
Quoted 3 lines
Quoted 1 line
Here is the tpm portion of -mm patch
Can you narrow this down to a fix that's reasonable for -stable?
I'll be sending two patches to fix this problem. The first one just changes a bunch of #define's to named emums. The second is the real fix. This was the easiest way for me, let me know if this is not ok.
Just the real fix is the best for -stable, please.
Here is the patch that should fix the problem. Pierre can you remove the first patch I sent and test this one?
---
drivers/char/tpm/tpm.c | 90 ------------------------------------------- drivers/char/tpm/tpm.h | 2 drivers/char/tpm/tpm_atmel.c | 16 ++++--- drivers/char/tpm/tpm_nsc.c | 22 ++++++---- 4 files changed, 22 insertions(+), 108 deletions(-)
drivers/char/tpm/tpm_atmel.c renamed from drivers/char/tpm/tpm_atmel.c~tpm-replace-odd-LPC-init-function +9 -6
@@ -22,6 +22,8 @@#include "tpm.h" /* Atmel definitions */ -#define TPM_ATML_BASE 0x400 +enum tpm_atmel_addr { +TPM_ATMEL_BASE_ADDR_LO =0x08 , +TPM_ATMEL_BASE_ADDR_HI =0x09 /* write status bits */
@@ -148,5 +149,4 @@ static struct tpm_vendor_specific tpm_at .req_complete_mask = ATML_STATUS_BUSY | ATML_STATUS_DATA_AVAIL, .req_complete_val = ATML_STATUS_DATA_AVAIL, - .base = TPM_ATML_BASE, .miscdev = { .fops = &atmel_ops, }, };
@@ -158,14 +158,16 @@ static int __devinit tpm_atml_init(struc {u8 version[4 ];int rc =0 ; +int lo, hi;if (pci_enable_device (pci_dev))return -EIO ; -if (tpm_lpc_bus_init (pci_dev,TPM_ATML_BASE )) { - rc = -ENODEV ; - goto out_err; - } + lo =tpm_read_index (TPM_ATMEL_BASE_ADDR_LO ); + hi =tpm_read_index (TPM_ATMEL_BASE_ADDR_HI ); + + tpm_atmel.base = (hi<<8 )|lo; +dev_dbg ( &pci_dev->dev,"Operating with base: 0x%x\n" , tpm_atmel.base);/* verify that it is an Atmel part */ if (tpm_read_index(4) != 'A' || tpm_read_index(5) != 'T'
drivers/char/tpm/tpm.c renamed from drivers/char/tpm/tpm.c~tpm-replace-odd-LPC-init-function +0 -76
92 lines not on this page · raw message
drivers/char/tpm/tpm.h renamed from drivers/char/tpm/tpm.h~tpm-replace-odd-LPC-init-function +0 -2
@@ -91,9 +91,7 @@ static inline void tpm_write_index(int ioutb (value &0xFF ,TPM_DATA ); }extern void tpm_time_expired (unsigned long ); -extern int tpm_lpc_bus_init (struct pci_dev *,u16 ); -extern int tpm_register_hardware (struct pci_dev *,struct tpm_vendor_specific *);extern int tpm_open (struct inode *,struct file *);
drivers/char/tpm/tpm_nsc.c renamed from drivers/char/tpm/tpm_nsc.c~tpm-replace-odd-LPC-init-function +10 -6
@@ -22,6 +22,10 @@/* National definitions */ #define TPM_NSC_BASE 0x360#define TPM_NSC_IRQ 0x07 +#define TPM_NSC_BASE0_HI 0x60 +#define TPM_NSC_BASE0_LO 0x61 +#define TPM_NSC_BASE1_HI 0x62 +#define TPM_NSC_BASE1_LO 0x63#define NSC_LDN_INDEX 0x07#define NSC_SID_INDEX 0x20
@@ -246,5 +250,4 @@ static struct tpm_vendor_specific tpm_ns .req_complete_mask = NSC_STATUS_OBF, .req_complete_val = NSC_STATUS_OBF, - .base = TPM_NSC_BASE, .miscdev = { .fops = &nsc_ops, }, };
@@ -255,15 +258,16 @@ static int __devinit tpm_nsc_init(struct const struct pci_device_id *pci_id) {int rc =0 ; +int lo, hi; + + hi =tpm_read_index (TPM_NSC_BASE0_HI ); + lo =tpm_read_index (TPM_NSC_BASE0_LO ); + + tpm_nsc.base = (hi<<8 ) | lo;if (pci_enable_device (pci_dev))return -EIO ; -if (tpm_lpc_bus_init (pci_dev,TPM_NSC_BASE )) { - rc = -ENODEV ; - goto out_err; - } -/* verify that it is a National part (SID) */ if (tpm_read_index (NSC_SID_INDEX ) !=0xEF ) { rc = -ENODEV ;
_
Quoted 11 lines · Kylene Jo Hall
Quoted 5 lines
(btw. does no output in dmesg mean that no TPM chip was found? it seems to have found a pci id it likes atleast.)
True I think if a chip is found there should be info in dmesg. Are you loading
tpm_atmelortpm_nsc? You can look at/proc/miscor see if/sys/class/misc/tpm0exists.
I'm using tpm_atmel (its PCI id list matches my LPC bridge). Nothing shows up in /proc or /sys though.
Quoted 4 lines
Do you know if your machine has a TPM? Is it activated in BIOS?
Haven't the slightest. :)
My BIOS is barely advanced enough to configure the clock. So no fancy stuff like enabling/disabling parts of the hardware. ;)
Rgds
Pierre
Re: 2.6.12 breaks 8139cp [PATCH 1 of 2]
In reply to Kylene Jo HallQuoted 6 lines · Kylene Jo Hall
Here is the patch that should fix the problem. Pierre can you remove the first patch I sent and test this one?
Apart from an improperly closed enum the patch worked fine. Great work!
Rgds
Pierre
Re: 2.6.12 breaks 8139cp [PATCH 1 of 2]
Quoted 10 lines · Pierre Ossman
Quoted 4 lines · Kylene Jo Hall
Here is the patch that should fix the problem. Pierre can you remove the first patch I sent and test this one?
Apart from an improperly closed enum the patch worked fine. Great work!
Rgds
Pierre
Please accept this patch. The enum closing Pierre mentioned has been fixed. This patch fixes the 8309 networking problem.
---
drivers/char/tpm/tpm.c | 90 ------------------------------------------- drivers/char/tpm/tpm.h | 2 drivers/char/tpm/tpm_atmel.c | 16 ++++--- drivers/char/tpm/tpm_nsc.c | 22 ++++++---- 4 files changed, 22 insertions(+), 108 deletions(-)
drivers/char/tpm/tpm_atmel.c renamed from drivers/char/tpm/tpm_atmel.c~tpm-replace-odd-LPC-init-function +10 -6
@@ -22,6 +22,9 @@#include "tpm.h" /* Atmel definitions */ -#define TPM_ATML_BASE 0x400 +enum tpm_atmel_addr { +TPM_ATMEL_BASE_ADDR_LO =0x08 , +TPM_ATMEL_BASE_ADDR_HI =0x09 +};/* write status bits */
@@ -148,5 +149,4 @@ static struct tpm_vendor_specific tpm_at .req_complete_mask = ATML_STATUS_BUSY | ATML_STATUS_DATA_AVAIL, .req_complete_val = ATML_STATUS_DATA_AVAIL, - .base = TPM_ATML_BASE, .miscdev = { .fops = &atmel_ops, }, };
@@ -158,14 +158,16 @@ static int __devinit tpm_atml_init(struc {u8 version[4 ];int rc =0 ; +int lo, hi;if (pci_enable_device (pci_dev))return -EIO ; -if (tpm_lpc_bus_init (pci_dev,TPM_ATML_BASE )) { - rc = -ENODEV ; - goto out_err; - } + lo =tpm_read_index (TPM_ATMEL_BASE_ADDR_LO ); + hi =tpm_read_index (TPM_ATMEL_BASE_ADDR_HI ); + + tpm_atmel.base = (hi<<8 )|lo; +dev_dbg ( &pci_dev->dev,"Operating with base: 0x%x\n" , tpm_atmel.base);/* verify that it is an Atmel part */ if (tpm_read_index(4) != 'A' || tpm_read_index(5) != 'T'
drivers/char/tpm/tpm.c renamed from drivers/char/tpm/tpm.c~tpm-replace-odd-LPC-init-function +0 -76
92 lines not on this page · raw message
drivers/char/tpm/tpm.h renamed from drivers/char/tpm/tpm.h~tpm-replace-odd-LPC-init-function +0 -2
@@ -91,9 +91,7 @@ static inline void tpm_write_index(int ioutb (value &0xFF ,TPM_DATA ); }extern void tpm_time_expired (unsigned long ); -extern int tpm_lpc_bus_init (struct pci_dev *,u16 ); -extern int tpm_register_hardware (struct pci_dev *,struct tpm_vendor_specific *);extern int tpm_open (struct inode *,struct file *);
drivers/char/tpm/tpm_nsc.c renamed from drivers/char/tpm/tpm_nsc.c~tpm-replace-odd-LPC-init-function +10 -6
@@ -22,6 +22,10 @@/* National definitions */ #define TPM_NSC_BASE 0x360#define TPM_NSC_IRQ 0x07 +#define TPM_NSC_BASE0_HI 0x60 +#define TPM_NSC_BASE0_LO 0x61 +#define TPM_NSC_BASE1_HI 0x62 +#define TPM_NSC_BASE1_LO 0x63#define NSC_LDN_INDEX 0x07#define NSC_SID_INDEX 0x20
@@ -246,5 +250,4 @@ static struct tpm_vendor_specific tpm_ns .req_complete_mask = NSC_STATUS_OBF, .req_complete_val = NSC_STATUS_OBF, - .base = TPM_NSC_BASE, .miscdev = { .fops = &nsc_ops, }, };
@@ -255,15 +258,16 @@ static int __devinit tpm_nsc_init(struct const struct pci_device_id *pci_id) {int rc =0 ; +int lo, hi; + + hi =tpm_read_index (TPM_NSC_BASE0_HI ); + lo =tpm_read_index (TPM_NSC_BASE0_LO ); + + tpm_nsc.base = (hi<<8 ) | lo;if (pci_enable_device (pci_dev))return -EIO ; -if (tpm_lpc_bus_init (pci_dev,TPM_NSC_BASE )) { - rc = -ENODEV ; - goto out_err; - } -/* verify that it is a National part (SID) */ if (tpm_read_index (NSC_SID_INDEX ) !=0xEF ) { rc = -ENODEV ;
_
Re: 2.6.12 breaks 8139cp [PATCH 1 of 2]
In reply to a message not in the archiveQuoted 13 lines · Chris Wright
Quoted 12 lines · * Kylene Jo Hall ([email protected]) wrote:
Quoted 10 lines · Pierre Ossman
Quoted 4 lines · Kylene Jo Hall
Here is the patch that should fix the problem. Pierre can you remove the first patch I sent and test this one?
Apart from an improperly closed enum the patch worked fine. Great work!
Rgds
Pierre
Quoted 7 lines
Quoted 2 lines
Please accept this patch. The enum closing Pierre mentioned has been fixed. This patch fixes the 8309 networking problem.
Kylene, is there any way you can narrow this down to the core, critical fix? Something on the order of 10's of lines rather than 100's? Also, a better patch description would be great (what's broken, what fixes it).
The patch below is the smallest I can make this.
Quoted 4 lines
thanks!
-chris
A problem was reported that the tpm driver was interfereing with networking on the 8139 chipset. The tpm driver was using a hard coded the memory address instead of the value the BIOS was putting the chip at. This was in the tpm_lpc_bus_init function. That function can be replaced with querying the value at Vendor specific locations. This patch replaces all calls to tpm_lpc_bus_init and the hardcoding of the base address with a lookup of the address at the correct vendor location.
---
drivers/char/tpm/tpm_atmel.c renamed from drivers/char/tpm/tpm_atmel.c~tpm-replace-odd-LPC-init-function +10 -6
@@ -22,6 +22,9 @@#include "tpm.h" /* Atmel definitions */ -#define TPM_ATML_BASE 0x400 +enum tpm_atmel_addr { +TPM_ATMEL_BASE_ADDR_LO =0x08 , +TPM_ATMEL_BASE_ADDR_HI =0x09 +};/* write status bits */
@@ -148,5 +149,4 @@ static struct tpm_vendor_specific tpm_at .req_complete_mask = ATML_STATUS_BUSY | ATML_STATUS_DATA_AVAIL, .req_complete_val = ATML_STATUS_DATA_AVAIL, - .base = TPM_ATML_BASE, .miscdev = { .fops = &atmel_ops, }, };
@@ -158,14 +158,16 @@ static int __devinit tpm_atml_init(struc {u8 version[4 ];int rc =0 ; +int lo, hi;if (pci_enable_device (pci_dev))return -EIO ; -if (tpm_lpc_bus_init (pci_dev,TPM_ATML_BASE )) { - rc = -ENODEV ; - goto out_err; - } + lo =tpm_read_index (TPM_ATMEL_BASE_ADDR_LO ); + hi =tpm_read_index (TPM_ATMEL_BASE_ADDR_HI ); + + tpm_atmel.base = (hi<<8 )|lo; +dev_dbg ( &pci_dev->dev,"Operating with base: 0x%x\n" , tpm_atmel.base);/* verify that it is an Atmel part */ if (tpm_read_index(4) != 'A' || tpm_read_index(5) != 'T'
drivers/char/tpm/tpm.c renamed from drivers/char/tpm/tpm.c~tpm-replace-odd-LPC-init-function +0 -4
@@ -586,10 +500,6 @@ int tpm_pm_resume(struct pci_dev *pci_deif (chip ==NULL )return -ENODEV ; -spin_lock (&driver_lock); -tpm_lpc_bus_init (pci_dev, chip->vendor->base); -spin_unlock (&driver_lock); -return 0 ; }
drivers/char/tpm/tpm_nsc.c renamed from drivers/char/tpm/tpm_nsc.c~tpm-replace-odd-LPC-init-function +10 -6
@@ -22,6 +22,10 @@/* National definitions */ #define TPM_NSC_BASE 0x360#define TPM_NSC_IRQ 0x07 +#define TPM_NSC_BASE0_HI 0x60 +#define TPM_NSC_BASE0_LO 0x61 +#define TPM_NSC_BASE1_HI 0x62 +#define TPM_NSC_BASE1_LO 0x63#define NSC_LDN_INDEX 0x07#define NSC_SID_INDEX 0x20
@@ -246,5 +250,4 @@ static struct tpm_vendor_specific tpm_ns .req_complete_mask = NSC_STATUS_OBF, .req_complete_val = NSC_STATUS_OBF, - .base = TPM_NSC_BASE, .miscdev = { .fops = &nsc_ops, }, };
@@ -255,15 +258,16 @@ static int __devinit tpm_nsc_init(struct const struct pci_device_id *pci_id) {int rc =0 ; +int lo, hi; + + hi =tpm_read_index (TPM_NSC_BASE0_HI ); + lo =tpm_read_index (TPM_NSC_BASE0_LO ); + + tpm_nsc.base = (hi<<8 ) | lo;if (pci_enable_device (pci_dev))return -EIO ; -if (tpm_lpc_bus_init (pci_dev,TPM_NSC_BASE )) { - rc = -ENODEV ; - goto out_err; - } -/* verify that it is a National part (SID) */ if (tpm_read_index (NSC_SID_INDEX ) !=0xEF ) { rc = -ENODEV ;
_
Re: 2.6.12 breaks 8139cp [PATCH 1 of 2]
Quoted 8 lines · * Kylene Jo Hall ([email protected]) wrote:
A problem was reported that the tpm driver was interfereing with networking on the 8139 chipset. The tpm driver was using a hard coded the memory address instead of the value the BIOS was putting the chip at. This was in the
tpm_lpc_bus_initfunction. That function can be replaced with querying the value at Vendor specific locations. This patch replaces all calls totpm_lpc_bus_initand the hardcoding of the base address with a lookup of the address at the correct vendor location.
Thanks Kylene. Looks like it's just no longer deleting tpm_lpc_bus_init. So with that nice changelog, I think we'll just go with the full version. Sorry for the extra work, I thought there might be a simple method by passing lo/hi and doing tpm_read_index in tpm_lpc_bus_init to set base.
thanks,
-chris