Skip to contentSkip to conversation

fix semaphore handling in __unregister_chrdev_region

PATCH In review Wen-chien Jesse Sung 2 participants 2 messages Jun 28, 2005 VFS

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 fix semaphore handling in __unregister_chrdev_region

Hi,

Maybe this up() should be down() instead?

Best Regards,
Wen-chien Jesse Sung

fs/char_dev.c +1 -1
@@ -150,7 +150,7 @@ __unregister_chrdev_region(unsigned majo
 	struct char_device_struct *cd = NULL, **cp;
 	int i = major_to_index(major);
 
-	up(&chrdevs_lock);
+	down(&chrdevs_lock);
 	for (cp = &chrdevs[i]; *cp; cp = &(*cp)->next)
 		if ((*cp)->major == major &&
 		    (*cp)->baseminor == baseminor &&
#1 lore raw
Quoted 10 lines · Wen-chien Jesse Sung

Maybe this up() should be down() instead?

...
--- linux-2.6.12-git9.orig/fs/char_dev.c 2005-06-28 16:43:27.000000000 +0800
+++ linux-2.6.12-git9/fs/char_dev.c 2005-06-28 16:52:01.000000000 +0800
@@ -150,7 +150,7 @@ __unregister_chrdev_region(unsigned majo
struct char_device_struct *cd = NULL, **cp; int i = major_to_index(major);

Quoted 2 lines

- up(&chrdevs_lock);
+ down(&chrdevs_lock);

Heck. Thanks.