drivers/usb/input/ati_remote.c : Use of time_after and
Subsystems (2)
PATCH 1/1 drivers/usb/input/ati_remote.c : Use of time_after and
Use of time_after and time_before macros, defined at linux/jiffies.h, which deal with wrapping correctly and are nicer to read.
Signed-off-by Marcelo Feitoza Parisi <[email protected]>
drivers/usb/input/ati_remote.c +14 -7
@@ -95,6 +95,7 @@#include <linux/input.h> #include <linux/usb.h> #include <linux/wait.h> +#include <linux/jiffies.h> /* * Module and Version Information, Module Parameters
@@ -510,16 +511,22 @@* pad down, so we increase acceleration, ramping up over two seconds to * a maximum speed. The acceleration curve is #defined above. */ -if ((jiffies - ati_remote->old_jiffies) > (HZ >>2 )) { +if (time_after (jiffies, ati_remote->old_jiffies + (HZ >>2 ))) { acc =1 ; ati_remote->acc_jiffies = jiffies; } -else if ((jiffies - ati_remote->acc_jiffies) < (HZ >>3 )) acc = accel[0 ]; -else if ((jiffies - ati_remote->acc_jiffies) < (HZ >>2 )) acc = accel[1 ]; -else if ((jiffies - ati_remote->acc_jiffies) < (HZ >>1 )) acc = accel[2 ]; -else if ((jiffies - ati_remote->acc_jiffies) <HZ ) acc = accel[3 ]; -else if ((jiffies - ati_remote->acc_jiffies) <HZ +(HZ >>1 )) acc = accel[4 ]; -else if ((jiffies - ati_remote->acc_jiffies) < (HZ <<1 )) acc = accel[5 ]; +else if (time_before (jiffies, ati_remote->acc_jiffies + (HZ >>3 ))) + acc = accel[0 ]; +else if (time_before (jiffies, ati_remote->acc_jiffies + (HZ >>2 ))) + acc = accel[1 ]; +else if (time_before (jiffies, ati_remote->acc_jiffies + (HZ >>1 ))) + acc = accel[2 ]; +else if (time_before (jiffies, ati_remote->acc_jiffies +HZ )) + acc = accel[3 ]; +else if (time_before (jiffies, ati_remote->acc_jiffies +HZ +(HZ >>1 ))) + acc = accel[4 ]; +else if (time_before (jiffies, ati_remote->acc_jiffies + (HZ <<1 ))) + acc = accel[5 ];else acc = accel[6 ];input_regs (dev, regs);
_______________________________________________
Kernel-janitors mailing list
[email protected]
https://lists.osdl.org/mailman/listinfo/kernel-janitors
PATCH 1/1 drivers/usb/input/ati_remote.c : Use of the
Use of the time_before() macro, defined at linux/jiffies.h, which deal with wrapping correctly and are nicer to read.
Signed-off-by Marcelo Feitoza Parisi <[email protected]>
drivers/usb/input/ati_remote.c +2 -1
@@ -476,7 +476,8 @@/* Filter duplicate events which happen "too close" together. */ if ((ati_remote->old_data[0 ] == data[1 ]) && (ati_remote->old_data[1 ] == data[2 ]) && - ((ati_remote->old_jiffies +FILTER_TIME ) > jiffies)) { + (time_before (jiffies, ati_remote->old_jiffies + +FILTER_TIME ))) { ati_remote->repeat_count++; }else { ati_remote->repeat_count =0 ;
_______________________________________________
Kernel-janitors mailing list
[email protected]
https://lists.osdl.org/mailman/listinfo/kernel-janitors