drivers/block/DAC960.c : Use of time_after(),
Subsystems (2)
PATCH 1/1 drivers/block/DAC960.c : Use of time_after(),
Use of time_after(), time_after_eq() and time_before() macros, define at linux/jiffies.h, which deal with wrapping correctly and are nicer to read.
Signed-off-by Marcelo Feitoza Parisi <[email protected]>
drivers/block/DAC960.c +9 -8
@@ -42,6 +42,7 @@#include <linux/pci.h> #include <linux/init.h> #include <linux/wait.h> +#include <linux/jiffies.h> #include <asm/io.h> #include <asm/uaccess.h> #include "DAC960.h"
@@ -3674,8 +3675,8 @@ (NewEnquiry->EventLogSequenceNumber != OldEnquiry->EventLogSequenceNumber) || Controller->MonitoringTimerCount ==0 || - (jiffies - Controller->SecondaryMonitoringTime - >= DAC960_SecondaryMonitoringInterval)) + (time_after_eq (jiffies, Controller->SecondaryMonitoringTime + + DAC960_SecondaryMonitoringInterval))) { Controller->V1.NeedLogicalDriveInformation = true; Controller->V1.NewEventLogSequenceNumber =
@@ -5660,8 +5661,8 @@unsigned int StatusChangeCounter = Controller->V2.HealthStatusBuffer->StatusChangeCounter;boolean ForceMonitoringCommand = false; -if (jiffies - Controller->SecondaryMonitoringTime - > DAC960_SecondaryMonitoringInterval) +if (time_after (jiffies, Controller->SecondaryMonitoringTime + + DAC960_SecondaryMonitoringInterval)) {int LogicalDriveNumber; for (LogicalDriveNumber = 0;
@@ -5689,8 +5690,8 @@ ControllerInfo->ConsistencyChecksActive + ControllerInfo->RebuildsActive + ControllerInfo->OnlineExpansionsActive ==0 || - jiffies - Controller->PrimaryMonitoringTime - < DAC960_MonitoringTimerInterval) && +time_before (jiffies, Controller->PrimaryMonitoringTime + + DAC960_MonitoringTimerInterval)) && !ForceMonitoringCommand) { Controller->MonitoringTimer.expires =
@@ -5827,8 +5828,8 @@ Controller->ProgressBufferLength = Length;if (Controller->EphemeralProgressMessage) { -if (jiffies - Controller->LastProgressReportTime - >= DAC960_ProgressReportingInterval) +if (time_after_eq (jiffies, Controller->LastProgressReportTime + + DAC960_ProgressReportingInterval)) {printk ("%sDAC960#%d: %s" , DAC960_MessageLevelMap[MessageLevel], Controller->ControllerNumber, Buffer);
_______________________________________________
Kernel-janitors mailing list
[email protected]
https://lists.osdl.org/mailman/listinfo/kernel-janitors