drivers/block/floppy.c : Use of the time_after() and
Subsystems (3)
PATCH 1/1 drivers/block/floppy.c : Use of the time_after() and
Use of the time_after() and time_before() macros, defined at linux/jiffies.h, which deal with wrapping correctly and are nicer to read.
Signed-off-by Marcelo Feitoza Parisi <[email protected]>
drivers/block/floppy.c +4 -3
@@ -179,6 +179,7 @@#include <linux/devfs_fs_kernel.h> #include <linux/device.h> #include <linux/buffer_head.h> /* for invalidate_buffers() */ +#include <linux/jiffies.h> /* for time_before() */ /* * PS/2 floppies have much slower step rates than regular floppies.
@@ -733,7 +734,7 @@ {int fdc =FDC (drive);#ifdef FLOPPY_SANITY_CHECK -if (jiffies -UDRS ->select_date <UDP ->select_delay) +if (time_before (jiffies,UDRS ->select_date +UDP ->select_delay))DPRINT ("WARNING disk change called early\n" );if (!(FDCS ->dor & (0x10 <<UNIT (drive))) || (FDCS ->dor &3 ) !=UNIT (drive) || fdc !=FDC (drive)) {
@@ -1061,7 +1062,7 @@return 1 ; } -if ((signed )(jiffies - delay) <0 ) { +if (time_before (jiffies, delay)) {del_timer (&fd_timer); fd_timer.function = function; fd_timer.expires = delay;
@@ -1521,7 +1522,7 @@* again just before spinup completion. Beware that * after scandrives, we must again wait for selection. */ -if ((signed )(ready_date - jiffies) >DP ->select_delay) { +if (time_after (ready_date, jiffies +DP ->select_delay)) { ready_date -=DP ->select_delay; function = (timeout_fn ) floppy_start; }else
_______________________________________________
Kernel-janitors mailing list
[email protected]
https://lists.osdl.org/mailman/listinfo/kernel-janitors