Skip to contentSkip to conversation

: Fix potential memory corruption in NAT code (aka memory NAT)

PATCH In review Patrick McHardy 1 participant 1 message Aug 1, 2005

Subsystems (2)
Networking netfilter
lore
Share & tools
lore

Patrick McHardy

author
#0 lore raw

PATCH 5/6 : Fix potential memory corruption in NAT code (aka memory NAT)

[NETFILTER]: Fix potential memory corruption in NAT code (aka memory NAT)

Signed-off-by Patrick McHardy <[email protected]>

---
commit b3db926712f01d98e672510bdb69b940e09880eb
tree aa069a1d615f75a986c4b74975ffbf00d3927cf4
parent 3828b256e2b5adae44649792fee705bc91b1c44a
author Patrick McHardy <[email protected]> Sun, 31 Jul 2005 20:26:49 +0200 committer Patrick McHardy <[email protected]> Sun, 31 Jul 2005 20:26:49 +0200

 net/ipv4/netfilter/ip_nat_proto_tcp.c |    3 ++-
 net/ipv4/netfilter/ip_nat_proto_udp.c |    3 ++-
 2 files changed, 4 insertions(+), 2 deletions(-)
net/ipv4/netfilter/ip_nat_proto_tcp.c +2 -1
@@ -31,7 +31,8 @@ tcp_unique_tuple(struct ip_conntrack_tup
 		 enum ip_nat_manip_type maniptype,
 		 const struct ip_conntrack *conntrack)
 {
-	static u_int16_t port = 0, *portptr;
+	static u_int16_t port = 0;
+	u_int16_t *portptr;
 	unsigned int range_size, min, i;
 
 	if (maniptype == IP_NAT_MANIP_SRC)
net/ipv4/netfilter/ip_nat_proto_udp.c +2 -1
@@ -32,7 +32,8 @@ udp_unique_tuple(struct ip_conntrack_tup
 		 enum ip_nat_manip_type maniptype,
 		 const struct ip_conntrack *conntrack)
 {
-	static u_int16_t port = 0, *portptr;
+	static u_int16_t port = 0;
+	u_int16_t *portptr;
 	unsigned int range_size, min, i;
 
 	if (maniptype == IP_NAT_MANIP_SRC)