Skip to contentSkip to conversation

tridentfb: Fix scrolling artifacts during disk IO

PATCH Applied Antonino A. Daplas 2 participants 2 messages Aug 1, 2005 Framebuffer layer

lore
Share & tools
lore
#0 lore raw

PATCH 2/2 tridentfb: Fix scrolling artifacts during disk IO

Reported by: Jochen Hein (Bugzilla Bug 4312)

When there is disk I/O happening, the framebuffer has a little snow on the screen. Once I/O has finished, no garbage remains on screen.

This bug was explained by: Knut Petersen

Most important is CRTC register 2f, signal quality is also improved for higher vclk values by changing set_vclk() according to the X drivers and cyblafb.c

Fix is to set the performance register (0x2f) with a more stable value.

From: Antonino Daplas <[email protected]>

---

tridentfb.c | 2 +-

1 files changed, 1 insertion(+), 1 deletion(-)
drivers/video/tridentfb.c +0 -0
@@ -904,7 +904,7 @@ static int tridentfb_set_par(struct fb_i
	write3X4(DRAMControl, tmp);	//both IO,linear enable

	write3X4(InterfaceSel, read3X4(InterfaceSel) | 0x40);
-	write3X4(Performance,0x20);
+	write3X4(Performance,0x92);
	write3X4(PCIReg,0x07);		//MMIO & PCI read and write burst enable

	/* convert from picoseconds to MHz */

-------------------------------------------------------
SF.Net email is sponsored by: Discover Easy Linux Migration Strategies from IBM. Find simple to follow Roadmaps, straightforward articles, informative Webcasts and more! Get everything you need to get up to speed, fast. http://ads.osdn.com/?ad_id=7477&alloc_id=16492&op=click

#1 lore raw
Quoted 2 lines · Antonino A. Daplas

Fix is to set the performance register (0x2f) with a more stable value.

Applied. However, the patch was whitespace-damaged, please don't do that. I fixed it up by hand this time.

Linus

-------------------------------------------------------
SF.Net email is sponsored by: Discover Easy Linux Migration Strategies from IBM. Find simple to follow Roadmaps, straightforward articles, informative Webcasts and more! Get everything you need to get up to speed, fast. http://ads.osdn.com/?ad_id=7477&alloc_id=16492&op=click