Skip to contentSkip to conversation

Old api files, rewrite or delete?

DISCUSSION Jiri Slaby 4 participants 6 messages Aug 4, 2005 – Aug 5, 2005

lore
Share & tools
lore

Jiri Slaby

author
#0 lore raw

Hi.
I'm interested mainly in things that may be removed. I don't want to rewrite drivers, which nobody uses. Thanks for your opinion and knowledge about usage.

I was searching for pci_find_device, so changes to do may not be huge, only few lines in some cases could be everything what to do. the result is:

REWRITE:
drivers/media/video/bttv-cards.c
drivers/media/video/zoran_card.c
drivers/media/video/stradis.c
drivers/media/radio/radio-maestro.c
drivers/video/sis/sis_main.c
drivers/video/igafb.c
drivers/net/skfp/drvfbi.c
drivers/net/sunhme.c
drivers/net/gt96100eth.c
drivers/char/watchdog/i8xx_tco.c
drivers/char/watchdog/alim1535_wdt.c
drivers/char/watchdog/alim7101_wdt.c
drivers/char/watchdog/i6300esb.c
drivers/char/sx.c
drivers/char/istallion.c
drivers/char/mxser.c
drivers/char/rocket.c
drivers/char/stallion.c
drivers/char/specialix.c
drivers/char/ip2main.c
drivers/isdn/hisax/gazel.c
drivers/isdn/hisax/elsa.c
drivers/isdn/hisax/nj_u.c
drivers/isdn/hisax/nj_s.c
drivers/isdn/hisax/avm_pci.c
drivers/isdn/hisax/bkm_a4t.c
drivers/isdn/hisax/hfc_pci.c
drivers/isdn/hisax/telespci.c
drivers/isdn/hisax/enternow_pci.c
drivers/isdn/hisax/bkm_a8.c
drivers/isdn/hisax/w6692.c
drivers/isdn/hisax/diva.c
drivers/isdn/hisax/sedlbauer.c
drivers/isdn/hisax/niccy.c
drivers/isdn/hysdn/hysdn_init.c
drivers/scsi/cpqfcTSinit.c
drivers/scsi/initio.c
drivers/scsi/advansys.c
drivers/scsi/gdth.c
drivers/scsi/eata_pio.c
drivers/scsi/fdomain.c
drivers/scsi/qlogicfc.c
drivers/scsi/dpt_i2o.c
drivers/scsi/qlogicisp.c
drivers/scsi/aic7xxx_old.c
drivers/scsi/BusLogic.c
drivers/parport/parport_pc.c
drivers/mtd/devices/pmc551.c
drivers/mtd/maps/ichxrom.c
drivers/mtd/maps/amd76xrom.c
drivers/mtd/maps/scx200_docflash.c
drivers/mtd/maps/l440gx.c
drivers/ide/pci/serverworks.c
drivers/ide/pci/piix.c
drivers/ide/pci/cs5530.c
drivers/ide/pci/alim15x3.c
drivers/ide/pci/sis5513.c
drivers/ide/pci/pdc202xx_new.c
drivers/ide/pci/via82cxxx.c
drivers/ide/pci/hpt366.c
drivers/ide/setup-pci.c
drivers/macintosh/via-pmu68k.c
drivers/macintosh/via-pmu.c
drivers/telephony/ixj.c
arch/ppc/kernel/pci.c
arch/ppc/platforms/85xx/mpc85xx_cds_common.c
arch/sparc64/kernel/ebus.c
arch/alpha/kernel/sys_sio.c
arch/alpha/kernel/sys_alcor.c
arch/frv/mb93090-mb00/pci-frv.c
arch/frv/mb93090-mb00/pci-irq.c
include/asm-i386/ide.h
sound/pci/cs46xx/cs46xx_lib.c
sound/pci/au88x0/au88x0.c
sound/pci/via82xx.c
sound/pci/ali5451/ali5451.c
sound/core/memalloc.c

LET IT BE (and then delete):
sound/oss/esssolo1.c
sound/oss/via82cxxx_audio.c
sound/oss/trident.c
sound/oss/maestro.c
sound/oss/cs46xx.c

REMOVE:
drivers/video/pm3fb.c

Signature · 3 lines
Jiri Slaby         www.fi.muni.cz/~xslaby
~\-/~      [email protected]      ~\-/~
241B347EC88228DE51EE A49C4A73A25004CB2A10
#1 lore raw
Quoted 1 line · Jiri Slaby

drivers/parport/parport_pc.c

I think a fair number of people probably use this.

Quoted 2 lines

REMOVE:
drivers/video/pm3fb.c

I have one of these cards, and I believe it's only recently (2.5-ish) been merged. Why are you so keen to mark it as "remove"?

Signature · 3 lines
Russell King
 Linux kernel    2.6 ARM Linux   - http://www.arm.linux.org.uk/
 maintainer of:  2.6 Serial core
author
#2 lore raw

Russell King napsal(a):

Quoted 10 lines · Jiri Slaby
Quoted 5 lines

drivers/parport/parport_pc.c

I think a fair number of people probably use this.

Yeah, I use it too, i don't know, why am I asking for this.

Quoted 9 lines
Quoted 4 lines

REMOVE:
drivers/video/pm3fb.c

I have one of these cards, and I believe it's only recently (2.5-ish) been merged. Why are you so keen to mark it as "remove"?

Because it doesn't work for me (it doesn't compile) and it is marked as "broken". Where are files fbcon-cfb{2,4,8,16,24,32}.h? Do you need some additional packages? -- then a few lines should be added to Kconfig.

Signature · 3 lines
Jiri Slaby         www.fi.muni.cz/~xslaby
~\-/~      [email protected]      ~\-/~
241B347EC88228DE51EE A49C4A73A25004CB2A10
#3 lore raw
In reply to Jiri Slaby
Quoted 5 lines · Jiri Slaby

Hi.
I'm interested mainly in things that may be removed. I don't want to rewrite drivers, which nobody uses.
Thanks for your opinion and knowledge about usage.
...

There might be users for many of the listed drivers - even if there are only very few.

And what do you really gain by removing drivers?

cu
Adrian

Signature · 4 lines
       "Is there not promise of rain?" Ling Tan asked suddenly out
        of the darkness. There had been need of rain for many days.
       "Only a promise," Lao Er said.
                                       Pearl S. Buck - Dragon Seed
author
#4 lore raw

Adrian Bunk napsal(a):

Quoted 9 lines · Jiri Slaby

There might be users for many of the listed drivers - even if there are only very few.

And what do you really gain by removing drivers?

Nothing, I don't only want to rewrite driver, which others do not use.

Signature · 3 lines
Jiri Slaby         www.fi.muni.cz/~xslaby
~\-/~      [email protected]      ~\-/~
241B347EC88228DE51EE A49C4A73A25004CB2A10
#5 lore raw
Quoted 2 lines

Nothing, I don't only want to rewrite driver, which others do not use.

Why rewrite? (unless it's an important api change) If it's some optimization patch that requires an almost-rewrite, well, do it and see if it gets accepted.

Jan Engelhardt