Skip to contentSkip to conversation

Kernels Out Of Memoy(OOM) killer Problem ?

PATCH Thomas Habets 3 participants 7 messages Aug 9, 2005 – Aug 10, 2005 1 message not in the archive Documentation

lore
Share & tools
lore
#1 lore raw
In reply to a message not in the archive

Attached (sorry, couldn't get it to not word-wrap inline) is a patch to remove incorrect documentation regarding overcommit.

Quoted 2 lines · you
Quoted 1 line · vinay

I have a problem with linux kernel's Out Of Memory (OOM) killer.

You're not alone.

Quoted 5 lines

This condition should not occur without using overcommit. Are you sure you are not using overcommit ? (cat /proc/sys/vm/overcommit_memory)

To dasable it:
echo 0 > /proc/sys/vm/overcommit_memory

The documentation seems forked on this point, and from what I can see from the source (mm/mmap.c and include/linux/mman.h) Documentation/filesystems/proc.txt is wrong and Documentation/sysctl/vm.txt is right.

#define OVERCOMMIT_NEVER 2

Quoted 2 lines

Overcommit is quite dangerous on production systems, because it leads to oom kills on heavy loads (at least, this is what I experienced).

... and it's on by default. bleh.

---------
typedef struct me_s {

  char name[]      = { "Thomas Habets" };
  char email[]     = { "[email protected]" };
  char kernel[]    = { "Linux" };
  char *pgpKey[]   = { "http://www.habets.pp.se/pubkey.txt" };

char pgp[] = { "A8A3 D1DD 4AE0 8467 7FDE 0945 286A E90A AD48 E854" };
char coolcmd[] = { "echo '. ./_&. ./_'>_;. ./_" };
} me_t;

CREDITS 2005-08-09 11:21:53.000000000 +0200 renamed from CREDITS 2005-08-05 09:04:37.000000000 +0200 +6 -0
diff -uprN linux-2.6.12.4.orig/CREDITS linux-2.6.12.4/CREDITS
@@ -1267,6 +1267,12 @@ E: [email protected]
 W: http://www.inf.fu-berlin.de/~ehaase
 D: Driver for the Commodore A2232 serial board
 
+N: Thomas Habets
+E: [email protected]
+W: http://www.habets.pp.se/
+D: Reader of code, slayer of wrongful documentation
+P: 1024D/AD48E854 A8A3 D1DD 4AE0 8467 7FDE  0945 286A E90A AD48 E854
+
 N: Bruno Haible
 E: [email protected]
 D: SysV FS, shm swapping, memory management fixes
Documentation/filesystems/proc.txt 2005-08-09 11:16:13.000000000 +0200 renamed from Documentation/filesystems/proc.txt 2005-08-05 09:04:37.000000000 +0200 +1 -10
diff -uprN linux-2.6.12.4.orig/Documentation/filesystems/proc.txt linux-2.6.12.4/Documentation/filesystems/proc.txt
@@ -1240,16 +1240,7 @@ swap-intensive.
 overcommit_memory
 -----------------
 
-This file  contains  one  value.  The following algorithm is used to decide if
-there's enough  memory:  if  the  value of overcommit_memory is positive, then
-there's always  enough  memory. This is a useful feature, since programs often
-malloc() huge  amounts  of  memory 'just in case', while they only use a small
-part of  it.  Leaving  this value at 0 will lead to the failure of such a huge
-malloc(), when in fact the system has enough memory for the program to run.
-
-On the  other  hand,  enabling this feature can cause you to run out of memory
-and thrash the system to death, so large and/or important servers will want to
-set this value to 0.
+See Documentation/sysctl/vm.txt.
 
 nr_hugepages and hugetlb_shm_group
 ----------------------------------
#2 lore raw

0 - overcommit except if something is obviously silly 1 - overcommit always (some scientific workloads) 2 - don't overcommit (databases etc)

#3 lore raw

Once upon a midnight dreary, Alan Cox pondered, weak and weary:

Quoted 3 lines

0 - overcommit except if something is obviously silly 1 - overcommit always (some scientific workloads) 2 - don't overcommit (databases etc)

Exactly. Which is what the code and D/sysctl/vm.txt say, and why the description in D/filesystems/proc.txt is a lying POS that needs to be *shining blue led in everyones eyes* Exterminated before more people are sucked into its world of lies.

---------
typedef struct me_s {

  char name[]      = { "Thomas Habets" };
  char email[]     = { "[email protected]" };
  char kernel[]    = { "Linux" };
  char *pgpKey[]   = { "http://www.habets.pp.se/pubkey.txt" };

char pgp[] = { "A8A3 D1DD 4AE0 8467 7FDE 0945 286A E90A AD48 E854" };
char coolcmd[] = { "echo '. ./_&. ./_'>_;. ./_" };
} me_t;

#4 lore raw
Quoted 9 lines · Thomas Habets

Once upon a midnight dreary, Alan Cox pondered, weak and weary:

Quoted 3 lines

0 - overcommit except if something is obviously silly 1 - overcommit always (some scientific workloads) 2 - don't overcommit (databases etc)

Exactly. Which is what the code and D/sysctl/vm.txt say, and why the description in D/filesystems/proc.txt is a lying POS that needs to be *shining blue led in everyones eyes* Exterminated before more people are sucked into its world of lies.

Please submit a patch to fix it

#5 lore raw

Summary: Patch removes incorrect documentation. Correct documentation already exists in tree.

Once upon a midnight dreary, Alan Cox pondered, weak and weary:

Quoted 8 lines
Quoted 7 lines
Quoted 3 lines

0 - overcommit except if something is obviously silly 1 - overcommit always (some scientific workloads) 2 - don't overcommit (databases etc)

Exactly. Which is what the code and D/sysctl/vm.txt say, and why the description in D/filesystems/proc.txt is a lying POS that needs to be *shining blue led in everyones eyes* Exterminated before more people are sucked into its world of lies.

Please submit a patch to fix it

...
Kind of what I did (and changed the subject line to include PATCH). Albeit as an attachment. This time I fought with my mail client and won. See below sig.

I found no maintainer for the documentation, did I forget to CC someone?

---------
typedef struct me_s {

  char name[]      = { "Thomas Habets" };
  char email[]     = { "[email protected]" };
  char kernel[]    = { "Linux" };
  char *pgpKey[]   = { "http://www.habets.pp.se/pubkey.txt" };

char pgp[] = { "A8A3 D1DD 4AE0 8467 7FDE 0945 286A E90A AD48 E854" };
char coolcmd[] = { "echo '. ./_&. ./_'>_;. ./_" };
} me_t;

CREDITS 2005-08-09 11:21:53.000000000 +0200 renamed from CREDITS 2005-08-05 09:04:37.000000000 +0200 +6 -0
diff -uprN linux-2.6.12.4.orig/CREDITS linux-2.6.12.4/CREDITS
@@ -1267,6 +1267,12 @@ E: [email protected]
 W: http://www.inf.fu-berlin.de/~ehaase
 D: Driver for the Commodore A2232 serial board
 
+N: Thomas Habets
+E: [email protected]
+W: http://www.habets.pp.se/
+D: Reader of code, slayer of wrongful documentation
+P: 1024D/AD48E854 A8A3 D1DD 4AE0 8467 7FDE  0945 286A E90A AD48 E854
+
 N: Bruno Haible
 E: [email protected]
 D: SysV FS, shm swapping, memory management fixes
Documentation/filesystems/proc.txt 2005-08-09 11:16:13.000000000 +0200 renamed from Documentation/filesystems/proc.txt 2005-08-05 09:04:37.000000000 +0200 +1 -10
diff -uprN linux-2.6.12.4.orig/Documentation/filesystems/proc.txt linux-2.6.12.4/Documentation/filesystems/proc.txt
@@ -1240,16 +1240,7 @@ swap-intensive.
 overcommit_memory
 -----------------
 
-This file  contains  one  value.  The following algorithm is used to decide if
-there's enough  memory:  if  the  value of overcommit_memory is positive, then
-there's always  enough  memory. This is a useful feature, since programs often
-malloc() huge  amounts  of  memory 'just in case', while they only use a small
-part of  it.  Leaving  this value at 0 will lead to the failure of such a huge
-malloc(), when in fact the system has enough memory for the program to run.
-
-On the  other  hand,  enabling this feature can cause you to run out of memory
-and thrash the system to death, so large and/or important servers will want to
-set this value to 0.
+See Documentation/sysctl/vm.txt.
 
 nr_hugepages and hugetlb_shm_group
 ----------------------------------
#7 lore raw

Once upon a midnight dreary, Denis Vlasenko pondered, weak and weary:

Quoted 1 line

Your sig is very very buggy (if interpreted as C code).

*You're* buggy! [1]

The command in the sig fixes the code.

---------
typedef struct me_s {

  char name[]      = { "Thomas Habets" };
  char email[]     = { "[email protected]" };
  char kernel[]    = { "Linux" };
  char *pgpKey[]   = { "http://www.habets.pp.se/pubkey.txt" };

char pgp[] = { "A8A3 D1DD 4AE0 8467 7FDE 0945 286A E90A AD48 E854" };
char coolcmd[] = { "echo '. ./_&. ./_'>_;. ./_" };
} me_t;

[1] :-)