Skip to contentSkip to conversation

START STOP UNIT SCSI command for libata

PATCH In review Douglas Gilbert 2 participants 2 messages Aug 11, 2005

Subsystems (2)
SCSI libata
lore
Share & tools
lore

Douglas Gilbert

author
#0 lore raw

PATCH 1/1 START STOP UNIT SCSI command for libata

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

Quoted 19 lines · Jeff Garzik
Quoted 11 lines · Douglas Gilbert

Jeff,
Here is another (more successful) attempt at that patch.

ChangeLog:
- adds minimal START STOP UNIT SCSI command functionality to libata (follows sat-r05 apart from the IMMED bit).
- implements the TEST UNIT READY SCSI command as indicated

    by sat-r05.
Signed-off-by Douglas Gilbert <[email protected]>

Looks pretty decent, however...

Can you please resend as two patches:

Quoted 7 lines

#1: implement START STOP UNIT
#2: implement TEST UNIT READY

I need to think about TUR a bit more. Separating into two patches would allow me to apply SSU patch to upstream immediately, while applying the TUR feature to libata-dev.git respository, queueing it for further review and eventual upstream merge.

Jeff,
Attached is #1, a patch against lk 2.6.13-rc6 .

I asked several people to test the full patch and one has responded to date. That was successful with:

    sata_sil+SP1614C (Samsung)
    sata_nv+SP2004C
I just tested this patch on my hardware:
    sata_sil+ST380013AS (Seagate)

and it worked.

Signed-off-by Douglas Gilbert <[email protected]>

Doug Gilbert

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.1 (GNU/Linux)
Comment: Using GnuPG with Fedora - http://enigmail.mozdev.org

iD8DBQFC+vgMnayo+9E+FQIRAhWrAKCxYnR1duIJNjYJzL80OW51nzdLHQCeKGMG cuZcws48H4LXVZCIyamzOsk=
=7kTq
-----END PGP SIGNATURE-----

include/linux/ata.h2613rc4standby renamed from include/linux/ata.h +2 -0
@@ -108,6 +108,8 @@
 
 	/* ATA device commands */
 	ATA_CMD_CHK_POWER	= 0xE5, /* check power mode */
+	ATA_CMD_STANDBY		= 0xE2, /* place in standby power mode */
+	ATA_CMD_IDLE		= 0xE3, /* place in idle power mode */
 	ATA_CMD_EDD		= 0x90,	/* execute device diagnostic */
 	ATA_CMD_FLUSH		= 0xE7,
 	ATA_CMD_FLUSH_EXT	= 0xEA,
drivers/scsi/libata-scsi.c2613rc6ss renamed from drivers/scsi/libata-scsi.c +56 -0

68 lines not on this page · raw message