Skip to contentSkip to conversation

kernel/module.c has something to hide. (whitespace cleanup)

PATCH Bodo Eggert <[email protected]> 4 participants 6 messages May 11, 2005 – May 12, 2005 6 messages not in the archive

lore
Share & tools
lore

A message that is not in the archive (sent off-list or not yet received): [email protected]

A message that is not in the archive (sent off-list or not yet received): [email protected]

A message that is not in the archive (sent off-list or not yet received): [email protected]

A message that is not in the archive (sent off-list or not yet received): [email protected]

A message that is not in the archive (sent off-list or not yet received): [email protected]

#5 lore raw
Quoted 3 lines · Jesper Juhl

If Andrew agrees, then I'll commit to doing this cleanup;

- (to a limited degree) no trailing whitespace

I just ran a script over -rc4 to remove trailing ws. The result is about 22 MB in 429 patches (iterated over ./*/*).

How hard can I patch you before you start patching me?

Which addresses am I supposed to send it to? I don't want to break the record for the most annoying patch series in lkml.

Signature · 1 line
If at first you don't succeed, call it version 1.0 
#6 lore raw
Quoted 9 lines · Bodo Eggert
Quoted 5 lines · Jesper Juhl

If Andrew agrees, then I'll commit to doing this cleanup;

- (to a limited degree) no trailing whitespace

Quoted 8 lines

I just ran a script over -rc4 to remove trailing ws. The result is about 22 MB in 429 patches (iterated over ./*/*).

How hard can I patch you before you start patching me?

Which addresses am I supposed to send it to? I don't want to break the record for the most annoying patch series in lkml.

First of all, why is it 429 patches? The patches we want aren't about a file or a subdirectory or even a subsystem, but they're supposed to be a logical change. Ie. 1 patch. An exception for something like this would be if you want to feed it to different maintainers seperately, but it sounds like you just want to bomb it somewhere...

Secondly, let's not.

More subtle indenting stuff like fixing if (exp) do_something I can understand. But this isn't nearly so helpful.

#7 lore raw
Quoted 10 lines · Nick Piggin
Quoted 9 lines · Bodo Eggert
Quoted 3 lines · Jesper Juhl

If Andrew agrees, then I'll commit to doing this cleanup;

- (to a limited degree) no trailing whitespace

I just ran a script over -rc4 to remove trailing ws. The result is about 22 MB in 429 patches (iterated over ./*/*).

Quoted 7 lines
Quoted 5 lines

How hard can I patch you before you start patching me?

Which addresses am I supposed to send it to? I don't want to break the record for the most annoying patch series in lkml.

First of all, why is it 429 patches?

Because
1) some parts will get rejected due to conflicting patches. Only those parts will need to be recreated.
2) i forgot to create the 430th patch.

Quoted 3 lines

The patches we want aren't about a
file or a subdirectory or even a subsystem, but they're supposed to be a logical change. Ie. 1 patch.

That would be too large for most mailboxes. If you like a single patch, you can just concatenate all the patches, so splitting it was a safe bet.

Quoted 3 lines

An exception for something like this would
be if you want to feed it to different maintainers seperately, but it sounds like you just want to bomb it somewhere...

I asume there is no automatic way to get the maintainer from a given file, and I don't want to grow old and grey while doing that manually.

Signature · 2 lines
"Bravery is being the only one who knows you're afraid."
-David Hackworth

A message that is not in the archive (sent off-list or not yet received): [email protected]

#9 lore raw

trailing whitespace fix (was: [PATCH] kernel/module.c has something to hide. (whitespace cleanup))

Quoted 7 lines · David S. Miller

From: Bodo Eggert <[email protected]>

Quoted 6 lines · Nick Piggin
Quoted 4 lines

The patches we want aren't about a
file or a subdirectory or even a subsystem, but they're supposed to be a logical change. Ie. 1 patch.

Quoted 6 lines
Quoted 2 lines

That would be too large for most mailboxes. If you like a single patch, you can just concatenate all the patches, so splitting it was a safe bet.

I'd rather you post a single posting, with URL pointers to where people can get the large patches, then sending 430 patche postings.

These patches fix the trailing whitespace from 2.6.12-rc4:
http://7eggert.dyndns.org/l/patches/trailing-ws/

Signature · 2 lines
Top 100 things you don't want the sysadmin to say:
47. Say, What does "Superblock Error" mean, anyhow?
#10 lore raw
In reply to Bodo Eggert <[email protected]>
Quoted 8 lines · Bodo Eggert

Date: Thu, 12 May 2005 01:47:28 +0200
From: "Bodo Eggert <[email protected]>"

    <[email protected]>

To: Jesper Juhl <[email protected]>, David S.Miller <[email protected]>,
Andrew Morton <[email protected]>, [email protected]
Subject: Re: [PATCH] kernel/module.c has something to hide. (whitespace
cleanup)

Quoted 9 lines
Quoted 3 lines · Jesper Juhl

If Andrew agrees, then I'll commit to doing this cleanup;

- (to a limited degree) no trailing whitespace

I just ran a script over -rc4 to remove trailing ws. The result is about 22 MB in 429 patches (iterated over ./*/*).

Ok, I'm not looking at trailing ws yet. I'm working on the "two statements on one line" and "spaces between function name and opening paren" bits. It's a bit slow going since I don't have many hours a day untill the weekend, but I hope to have the first batch of patches ready over the weekend.

Quoted 2 lines

How hard can I patch you before you start patching me?

Let me have a copy of your patches, then I can do my work incremental to yours. If you could tar & gz them and attach them to a mail and send it to me in private email that would be perfect.

/Jesper

#11 lore raw
Quoted 2 lines · Jesper Juhl

Ok, I'm not looking at trailing ws yet.

Obviously the way to handle this is to write a script and send it to Linus.

Good luck ;)