staging: comedi: comedi_fops: coding style fixes

PATCH RESEND In review Matias Mucciolo 2 participants 4 messages Sep 12, 2016 Staging

lore

Share & tools

lore

Matias Mucciolo

author

2016-09-12 13:19 UTC #0 lore raw

PATCH RESEND 1/1 staging: comedi: comedi_fops: coding style fixes

From: Matias Mucciolo <[email protected]>

- Fixed coding style in comedi_fops.c Symbolic to octal permission.

Signed-off-by Matias Mucciolo <[email protected]>

---
 drivers/staging/comedi/comedi_fops.c | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

drivers/staging/comedi/comedi_fops.c +3 -3

index 1999eed..bf922ea 100644
@@ -81,20 +81,20 @@ struct comedi_file {
 	(COMEDI_NUM_MINORS - COMEDI_NUM_BOARD_MINORS)
 
 static int comedi_num_legacy_minors;
-module_param(comedi_num_legacy_minors, int, S_IRUGO);
+module_param(comedi_num_legacy_minors, int, 0444);
 MODULE_PARM_DESC(comedi_num_legacy_minors,
 		 "number of comedi minor devices to reserve for non-auto-configured devices (default 0)"
 		);
 
 unsigned int comedi_default_buf_size_kb = CONFIG_COMEDI_DEFAULT_BUF_SIZE_KB;
-module_param(comedi_default_buf_size_kb, uint, S_IRUGO | S_IWUSR);
+module_param(comedi_default_buf_size_kb, uint, 0644);
 MODULE_PARM_DESC(comedi_default_buf_size_kb,
 		 "default asynchronous buffer size in KiB (default "
 		 __MODULE_STRING(CONFIG_COMEDI_DEFAULT_BUF_SIZE_KB) ")");
 
 unsigned int comedi_default_buf_maxsize_kb
 	= CONFIG_COMEDI_DEFAULT_BUF_MAXSIZE_KB;
-module_param(comedi_default_buf_maxsize_kb, uint, S_IRUGO | S_IWUSR);
+module_param(comedi_default_buf_maxsize_kb, uint, 0644);
 MODULE_PARM_DESC(comedi_default_buf_maxsize_kb,
 		 "default maximum size of asynchronous buffer in KiB (default "
 		 __MODULE_STRING(CONFIG_COMEDI_DEFAULT_BUF_MAXSIZE_KB) ")");

Signature · 1 line

2.1.4

Ian Abbott

2016-09-12 15:53 UTC #1 lore raw

Quoted 29 lines · Matias Mucciolo

From: Matias Mucciolo <[email protected]>

- Fixed coding style in comedi_fops.c Symbolic to octal permission.

Signed-off-by Matias Mucciolo <[email protected]>

---
 drivers/staging/comedi/comedi_fops.c | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

drivers/staging/comedi/comedi_fops.c +2 -2

index 1999eed..bf922ea 100644
@@ -81,20 +81,20 @@ struct comedi_file {
 	(COMEDI_NUM_MINORS - COMEDI_NUM_BOARD_MINORS)
 
 static int comedi_num_legacy_minors;
-module_param(comedi_num_legacy_minors, int, S_IRUGO);
+module_param(comedi_num_legacy_minors, int, 0444);
 MODULE_PARM_DESC(comedi_num_legacy_minors,
 		 "number of comedi minor devices to reserve for non-auto-configured devices (default 0)"
 		);
 
 unsigned int comedi_default_buf_size_kb = CONFIG_COMEDI_DEFAULT_BUF_SIZE_KB;
-module_param(comedi_default_buf_size_kb, uint, S_IRUGO | S_IWUSR);
+module_param(comedi_default_buf_size_kb, uint, 0644);
 MODULE_PARM_DESC(comedi_default_buf_size_kb,

drivers/staging/comedi/comedi_fops.c struct comedi_file { · line 100

Quoted 10 lines

drivers/staging/comedi/comedi_fops.c +1 -1

 		 "default asynchronous buffer size in KiB (default "
 		 __MODULE_STRING(CONFIG_COMEDI_DEFAULT_BUF_SIZE_KB) ")");
 
 unsigned int comedi_default_buf_maxsize_kb
 	= CONFIG_COMEDI_DEFAULT_BUF_MAXSIZE_KB;
-module_param(comedi_default_buf_maxsize_kb, uint, S_IRUGO | S_IWUSR);
+module_param(comedi_default_buf_maxsize_kb, uint, 0644);
 MODULE_PARM_DESC(comedi_default_buf_maxsize_kb,
 		 "default maximum size of asynchronous buffer in KiB (default "
 		 __MODULE_STRING(CONFIG_COMEDI_DEFAULT_BUF_MAXSIZE_KB) ")");

In my review of the earlier patch, I said I was fine with the octal constants, but on reflection, I'm not sure it's worth changing them just for the hell of it. We'd probably get a patch from someone else later to change it back to symbolic constants. Is there an actual coding style issue, or is this just a personal preference?

Signature · 2 lines

-=( Ian Abbott @ MEV Ltd.    E-mail: <[email protected]> )=-
-=(                          Web: http://www.mev.co.uk/  )=-

Matias Mucciolo

author

2016-09-12 16:01 UTC #2 lore raw

Hi Ian

yes its a coding style issue(checkpatch.pl WARN)

and reference:
https://lwn.net/Articles/696229/

(sorry about the noise.)

Signature · 5 lines

Matias Mucciolo

Area de Infraestructura.
Piedras 737 C.A.B.A 
SUTEBA

Quoted 50 lines · On Monday 12 September 2016 16:52:59 Ian Abbott wrote:

Quoted 29 lines · Matias Mucciolo
From: Matias Mucciolo <[email protected]>
- Fixed coding style in comedi_fops.c Symbolic to octal permission.
Signed-off-by Matias Mucciolo <[email protected]>
---
 drivers/staging/comedi/comedi_fops.c | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)
drivers/staging/comedi/comedi_fops.c +2 -2
index 1999eed..bf922ea 100644
@@ -81,20 +81,20 @@ struct comedi_file {
 	(COMEDI_NUM_MINORS - COMEDI_NUM_BOARD_MINORS)
 
 static int comedi_num_legacy_minors;
-module_param(comedi_num_legacy_minors, int, S_IRUGO);
+module_param(comedi_num_legacy_minors, int, 0444);
 MODULE_PARM_DESC(comedi_num_legacy_minors,
 		 "number of comedi minor devices to reserve for non-auto-configured devices (default 0)"
 		);
 
 unsigned int comedi_default_buf_size_kb = CONFIG_COMEDI_DEFAULT_BUF_SIZE_KB;
-module_param(comedi_default_buf_size_kb, uint, S_IRUGO | S_IWUSR);
+module_param(comedi_default_buf_size_kb, uint, 0644);
 MODULE_PARM_DESC(comedi_default_buf_size_kb,
drivers/staging/comedi/comedi_fops.c struct comedi_file { · line 100
Quoted 10 lines
drivers/staging/comedi/comedi_fops.c +1 -1
 		 "default asynchronous buffer size in KiB (default "
 		 __MODULE_STRING(CONFIG_COMEDI_DEFAULT_BUF_SIZE_KB) ")");
 
 unsigned int comedi_default_buf_maxsize_kb
 	= CONFIG_COMEDI_DEFAULT_BUF_MAXSIZE_KB;
-module_param(comedi_default_buf_maxsize_kb, uint, S_IRUGO | S_IWUSR);
+module_param(comedi_default_buf_maxsize_kb, uint, 0644);
 MODULE_PARM_DESC(comedi_default_buf_maxsize_kb,
 		 "default maximum size of asynchronous buffer in KiB (default "
 		 __MODULE_STRING(CONFIG_COMEDI_DEFAULT_BUF_MAXSIZE_KB) ")");
In my review of the earlier patch, I said I was fine with the octal constants, but on reflection, I'm not sure it's worth changing them just for the hell of it. We'd probably get a patch from someone else later to change it back to symbolic constants. Is there an actual coding style issue, or is this just a personal preference?
Signature · 2 lines
-=( Ian Abbott @ MEV Ltd.    E-mail: <[email protected]> )=-
-=(                          Web: http://www.mev.co.uk/  )=-

Ian Abbott

Reviewed-by on v1 1/1

2016-09-12 18:00 UTC #3 lore raw

In reply to Matias Mucciolo

Quoted 3 lines · Matias Mucciolo

From: Matias Mucciolo <[email protected]>

Those three lines are unnecessary, especially the initial blank line. I'm not sure whether Greg will ask you to fix it up.

Quoted 26 lines

- Fixed coding style in comedi_fops.c Symbolic to octal permission.

Signed-off-by Matias Mucciolo <[email protected]>

---
 drivers/staging/comedi/comedi_fops.c | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

drivers/staging/comedi/comedi_fops.c +2 -2

index 1999eed..bf922ea 100644
@@ -81,20 +81,20 @@ struct comedi_file {
 	(COMEDI_NUM_MINORS - COMEDI_NUM_BOARD_MINORS)
 
 static int comedi_num_legacy_minors;
-module_param(comedi_num_legacy_minors, int, S_IRUGO);
+module_param(comedi_num_legacy_minors, int, 0444);
 MODULE_PARM_DESC(comedi_num_legacy_minors,
 		 "number of comedi minor devices to reserve for non-auto-configured devices (default 0)"
 		);
 
 unsigned int comedi_default_buf_size_kb = CONFIG_COMEDI_DEFAULT_BUF_SIZE_KB;
-module_param(comedi_default_buf_size_kb, uint, S_IRUGO | S_IWUSR);
+module_param(comedi_default_buf_size_kb, uint, 0644);
 MODULE_PARM_DESC(comedi_default_buf_size_kb,

drivers/staging/comedi/comedi_fops.c struct comedi_file { · line 100

Quoted 10 lines

drivers/staging/comedi/comedi_fops.c +1 -1

 		 "default asynchronous buffer size in KiB (default "
 		 __MODULE_STRING(CONFIG_COMEDI_DEFAULT_BUF_SIZE_KB) ")");
 
 unsigned int comedi_default_buf_maxsize_kb
 	= CONFIG_COMEDI_DEFAULT_BUF_MAXSIZE_KB;
-module_param(comedi_default_buf_maxsize_kb, uint, S_IRUGO | S_IWUSR);
+module_param(comedi_default_buf_maxsize_kb, uint, 0644);
 MODULE_PARM_DESC(comedi_default_buf_maxsize_kb,
 		 "default maximum size of asynchronous buffer in KiB (default "
 		 __MODULE_STRING(CONFIG_COMEDI_DEFAULT_BUF_MAXSIZE_KB) ")");

It looks like the octal permissions have been blessed from above (Linus), so this is good.

Reviewed-by Ian Abbott <[email protected]>

Signature · 2 lines

-=( Ian Abbott @ MEV Ltd.    E-mail: <[email protected]> )=-
-=(                          Web: http://www.mev.co.uk/  )=-