Skip to contentSkip to conversation

Adaptec DPT call schedule_timeout with irq off

DISCUSSION Dave Jiang 1 participant 1 message Aug 27, 2005 SCSI

lore
Share & tools
lore

Dave Jiang

author
#0 lore raw

I noticed that in the Adaptec DPT driver, drivers/scsi/dpt_i2o.c in funciton adapt_i2o_post_wait() around line 1161ish. spin_lock_irqsave() is called. However then spin_unlock() is called 2 lines later and leaving IRQ disabled. Then a little bit later, schedule_timeout() is called with IRQ off. Isn't that bad? Why was irq left off earlier instead of doing spin_unlock_irqrestore()? Am I missing something.....

Please cc me on replies. Thank you!

Signature · 1 line
Dave