Skip to contentSkip to conversation

Cleanup - remove unnecessary handle_IRQ_event() prototype

PATCH New Kenji Kaneshige 1 participant 5 messages Sep 8, 2005

lore
Share & tools
lore
#0 lore raw

cover Cleanup - remove unnecessary handle_IRQ_event() prototype

Hi,

I think the function prototypes for handle_IRQ_event() in include/asm-{mips,ppc,sh,x86_64}/irq.h are no longer needed because these architectures are using GENERIC_HARDIRQ. This series of patches removes those unnecessary handle_IRQ_event() prototypes.

NOTE: Since I don't have these architectures, these patches are not tested yet. I hope these patches will be tested by someone who has these architectures.

Thanks,
Kenji Kaneshige

#1 lore raw

PATCH 1/4 Cleanup - remove unnecessary handle_IRQ_event() prototype (mips)

The function prototype for handle_IRQ_event() in include/asm-mips/irq.h seems no longer needed because mips uses GENERIC_HARDIRQ. This patch removes it.

 include/asm-mips/irq.h |    3 ---
 1 files changed, 3 deletions(-)
include/asm-mips/irq.h +0 -3
Index: linux-2.6.13/include/asm-mips/irq.h
===================================================================
@@ -49,7 +49,4 @@ do {									\
 
 extern void arch_init_irq(void);
 
-struct irqaction;
-int handle_IRQ_event(unsigned int, struct pt_regs *, struct irqaction *);
-
 #endif /* _ASM_IRQ_H */
#2 lore raw

PATCH 2/4 Cleanup - remove unnecessary handle_IRQ_event() prototype (ppc)

In reply to Kenji Kaneshige

The function prototype for handle_IRQ_event() in include/asm-ppc/irq.h seems no longer needed because ppc uses GENERIC_HARDIRQ. This patch removes it.

 include/asm-ppc/irq.h |    4 ----
 1 files changed, 4 deletions(-)
include/asm-ppc/irq.h +0 -4
Index: linux-2.6.13/include/asm-ppc/irq.h
===================================================================
@@ -398,9 +398,5 @@ extern unsigned long ppc_cached_irq_mask
 extern unsigned long ppc_lost_interrupts[NR_MASK_WORDS];
 extern atomic_t ppc_n_lost_interrupts;
 
-struct irqaction;
-struct pt_regs;
-int handle_IRQ_event(unsigned int, struct pt_regs *, struct irqaction *);
-
 #endif /* _ASM_IRQ_H */
 #endif /* __KERNEL__ */
#3 lore raw

PATCH 3/4 Cleanup - remove unnecessary handle_IRQ_event() prototype (sh)

In reply to Kenji Kaneshige

The function prototype for handle_IRQ_event() in include/asm-sh/irq.h seems no longer needed because sh uses GENERIC_HARDIRQ. This patch removes it.

 include/asm-sh/irq.h |    4 ----
 1 files changed, 4 deletions(-)
include/asm-sh/irq.h +0 -4
Index: linux-2.6.13/include/asm-sh/irq.h
===================================================================
@@ -587,10 +587,6 @@ static inline int generic_irq_demux(int 
 #define irq_canonicalize(irq)	(irq)
 #define irq_demux(irq)		__irq_demux(sh_mv.mv_irq_demux(irq))
 
-struct irqaction;
-struct pt_regs;
-int handle_IRQ_event(unsigned int, struct pt_regs *, struct irqaction *);
-
 #if defined(CONFIG_CPU_SUBTYPE_SH73180)
 #include <asm/irq-sh73180.h>
 #endif
#4 lore raw

PATCH 4/4 Cleanup - remove unnecessary handle_IRQ_event() prototype (x86_64)

In reply to Kenji Kaneshige

The function prototype for handle_IRQ_event() in include/asm-x86_64/irq.h seems no longer needed because x86_64 uses GENERIC_HARDIRQ. This patch removes it.

 include/asm-x86_64/irq.h |    4 ----
 1 files changed, 4 deletions(-)
include/asm-x86_64/irq.h +0 -4
Index: linux-2.6.13/include/asm-x86_64/irq.h
===================================================================
@@ -48,10 +48,6 @@ static __inline__ int irq_canonicalize(i
 #define ARCH_HAS_NMI_WATCHDOG		/* See include/linux/nmi.h */
 #endif
 
-struct irqaction;
-struct pt_regs;
-int handle_IRQ_event(unsigned int, struct pt_regs *, struct irqaction *);
-
 #ifdef CONFIG_HOTPLUG_CPU
 #include <linux/cpumask.h>
 extern void fixup_irqs(cpumask_t map);