Skip to contentSkip to conversation

: pptp helper: missing expectation flags initialisation

PATCH In review Patrick McHardy 2 participants 2 messages Sep 15, 2005 – Sep 17, 2005

Subsystems (2)
lore
Share & tools
lore
#0 lore raw

PATCH 8/8 : pptp helper: missing expectation flags initialisation

[NETFILTER]: pptp helper: missing expectation flags initialisation

Support for permanent expectations added a flags field to the expectation that needs to be initialized to 0.

---
commit 0ddb4c0a3fcf3cded1b34ec48b66e8874d13f105
tree 0d855d26740383efac8514fdd890786b86921cd6
parent ac7e4424f98eef582b9923011d27c208252a0096
author Patrick McHardy <[email protected]> Fri, 16 Sep 2005 00:21:34 +0200 committer Patrick McHardy <[email protected]> Fri, 16 Sep 2005 00:21:34 +0200

 net/ipv4/netfilter/ip_conntrack_helper_pptp.c |    1 +
 1 files changed, 1 insertions(+), 0 deletions(-)
net/ipv4/netfilter/ip_conntrack_helper_pptp.c +1 -0
@@ -250,6 +250,7 @@ exp_gre(struct ip_conntrack *master,
 		
 	exp_orig->master = master;
 	exp_orig->expectfn = pptp_expectfn;
+	exp_orig->flags = 0;
 
 	exp_orig->dir = IP_CT_DIR_ORIGINAL;
 
#1 lore raw
Quoted 1 line · Patrick McHardy

[NETFILTER]: pptp helper: missing expectation flags initialisation

thanks, all your patches applied to netfilte-2.6.14 git tree. I'll do some testing this afternoon, and then hopefully submit to Davem

Signature · 5 lines
- Harald Welte <[email protected]>                 http://netfilter.org/
============================================================================
  "Fragmentation is like classful addressing -- an interesting early
   architectural error that shows how much experimentation was going
   on while IP was being designed."                    -- Paul Vixie