Skip to contentSkip to conversation

fbdev: Fix reversed back and front porches

PATCH New Antonino A. Daplas 1 participant 1 message Sep 20, 2005 Framebuffer layer

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 fbdev: Fix reversed back and front porches

In fbdev perspective, the frontporch is the lower/right margin and the backporch is the upper/left margin.

Correct.

---
 fbcvt.c |    8 ++++----
 1 files changed, 4 insertions(+), 4 deletions(-)
drivers/video/fbcvt.c +4 -4
@@ -272,11 +272,11 @@ static void fb_cvt_convert_to_mode(struc
 {
 	mode->refresh = cvt->f_refresh;
 	mode->pixclock = KHZ2PICOS(cvt->pixclock/1000);
-	mode->left_margin = cvt->h_front_porch;
-	mode->right_margin = cvt->h_back_porch;
+	mode->left_margin = cvt->h_back_porch;
+	mode->right_margin = cvt->h_front_porch;
 	mode->hsync_len = cvt->hsync;
-	mode->upper_margin = cvt->v_front_porch;
-	mode->lower_margin = cvt->v_back_porch;
+	mode->upper_margin = cvt->v_back_porch;
+	mode->lower_margin = cvt->v_front_porch;
 	mode->vsync_len = cvt->vsync;
 
 	mode->sync &= ~(FB_SYNC_HOR_HIGH_ACT | FB_SYNC_VERT_HIGH_ACT);

-------------------------------------------------------
SF.Net email is sponsored by:
Tame your development challenges with Apache's Geronimo App Server. Download it for free - -and be entered to win a 42" plasma tv or your very own Sony(tm)PSP. Click here to play: http://sourceforge.net/geronimo.php