Skip to contentSkip to conversation

Fix cc-option macro in config.mk

PATCH New Paolo Broggini 3 participants 4 messages Oct 12, 2005 – Dec 21, 2005

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 Fix cc-option macro in config.mk

The following patch fix the compilation problem discussed in thread "Problem building U-Boot for ARM target"

Best regards
-P.Broggini

CHANGELOG:
Fix cc-option macro in config.mk, $(CFLAGS) dropped. Patch by Paolo Broggini, 12 Oct 2005

config.mk +1 -1
@@ -90,7 +90,7 @@ HOSTSTRIP	= strip
  # Option checker (courtesy linux kernel) to ensure
  # only supported compiler options are used
  #
-cc-option = $(shell if $(CC) $(CFLAGS) $(1) -S -o /dev/null -xc /dev/null \
+cc-option = $(shell if $(CC) $(1) -S -o /dev/null -xc /dev/null \
  		> /dev/null 2>&1; then echo "$(1)"; else echo "$(2)"; fi ;)
 
  #
#1 lore raw

PATCH 1/1 Fix cc-option macro in config.mk

Quoted 6 lines · Paolo Broggini

The following patch fix the compilation problem discussed in thread "Problem building U-Boot for ARM target"

Best regards
-P.Broggini

Bump & resubmit...

This particular issue broke cross-compilation for all of our ARM-based projects following a repository sync yesterday.

The attached patch was generated against a 2005.11.29 CVS pull.

CHANGELOG:
* Patch by Cory Tusar, 30 Nov 2005:
* Original patch by Paolo Broggini, 12 Oct 2005:
Fix cc-option macro in config.mk, $(CFLAGS) dropped.

-Cory

Signature · 22 lines
Cory T. Tusar
Embedded Systems Engineer
Videon Central, Inc.
2171 Sandy Drive
State College, PA 16801
(814) 235-1111 x316
(814) 235-1118 fax

"Debugging is twice as hard as writing the code in the first place.
   Therefore, if you write the code as cleverly as possible, you are,
     by definition, not smart enough to debug it."  --Brian W. Kernighan




-------------- next part --------------
A non-text attachment was scrubbed...
Name: cc-option_CFLAGS_removal.patch
Type: text/x-patch
Size: 554 bytes
Desc: not available
Url : http://lists.denx.de/pipermail/u-boot/attachments/20051130/c9c5063c/attachment.bin 
#2 lore raw

PATCH 1/1 Fix cc-option macro in config.mk

In reply to Paolo Broggini
Quoted 28 lines

The following patch fix the compilation problem discussed in thread "Problem building U-Boot for ARM target"

Best regards
-P.Broggini

CHANGELOG:
Fix cc-option macro in config.mk, $(CFLAGS) dropped. Patch by Paolo Broggini, 12 Oct 2005

config.mk +1 -1
@@ -90,7 +90,7 @@ HOSTSTRIP = strip
 # Option checker (courtesy linux kernel) to ensure
 # only supported compiler options are used
 #
-cc-option = $(shell if $(CC) $(CFLAGS) $(1) -S -o /dev/null -xc /dev/null 
 \
+cc-option = $(shell if $(CC) $(1) -S -o /dev/null -xc /dev/null \
 > /dev/null 2>&1; then echo "$(1)"; else echo "$(2)"; fi ;)
 
Quoted 2 lines

#

Hello all,
I have the same error

Quoted 1 line
Quoted 1 line

cc1: invalid option 'abi=apcs-gnu'

with Freescale MC9328MX1 and some other ARM boards and I wonder why this patch has not been applied in 1.1.4.
Is it correct to use it ?
Should I expect to see it in next 1.1.5 ?

Thanks

Marco Cavallini
Koan s.a.s. - Bergamo - ITALIA
Embedded and Real-Time Software Engineering
www.koansoftware.com | www.klinux.org

#3 lore raw

PATCH 1/1 Fix cc-option macro in config.mk

Marco Cavallini ha scritto:

Quoted 7 lines
Quoted 6 lines

CHANGELOG:
Fix cc-option macro in config.mk, $(CFLAGS) dropped. Patch by Paolo Broggini, 12 Oct 2005

Quoted 8 lines

Hello all,
I have the same error

Quoted 1 line
Quoted 1 line

cc1: invalid option 'abi=apcs-gnu'

with Freescale MC9328MX1 and some other ARM boards and I wonder why this patch has not been applied in 1.1.4.

I don't know, maybe is still in Wolfgang's patch queue.

Quoted 1 line

Is it correct to use it ?

Without it I was unable to compile U-Boot.

Regards
-Paolo